bisync: trailing slash in local path arg on Windows causes error #7511
Comments
nielash
added a commit
to nielash/rclone
that referenced
this issue
Dec 22, 2023
Before this change, certain shell quoting / escaping errors (particularly on Windows) were not detected by Bisync, possibly resulting in incorrect expansion and confusing errors. In particular, Windows paths with a single trailing backslash followed by a quote would be interpreted as an escaped quote -- resulting in the quote and subsequent flags being erroneously considered part of the path. After this change, Bisync specifically checks for a few of the most common patterns, and if detected, exits with a more helpful error message before doing any damage.
5 tasks
nielash
added a commit
to nielash/rclone
that referenced
this issue
Jan 20, 2024
Before this change, certain shell quoting / escaping errors (particularly on Windows) were not detected by Bisync, possibly resulting in incorrect expansion and confusing errors. In particular, Windows paths with a single trailing backslash followed by a quote would be interpreted as an escaped quote -- resulting in the quote and subsequent flags being erroneously considered part of the path. After this change, Bisync specifically checks for a few of the most common patterns, and if detected, exits with a more helpful error message before doing any damage.
nielash
added a commit
that referenced
this issue
Jan 20, 2024
Before this change, certain shell quoting / escaping errors (particularly on Windows) were not detected by Bisync, possibly resulting in incorrect expansion and confusing errors. In particular, Windows paths with a single trailing backslash followed by a quote would be interpreted as an escaped quote -- resulting in the quote and subsequent flags being erroneously considered part of the path. After this change, Bisync specifically checks for a few of the most common patterns, and if detected, exits with a more helpful error message before doing any damage.
miku
added a commit
to internetarchive/rclone
that referenced
this issue
Jan 23, 2024
* master: (86 commits) fs: add more detailed logging for file includes/excludes bisync: add --resync-mode for customizing --resync - fixes rclone#5681 bisync: fix --colors flag bisync: factor resync to separate file bisync: skip empty test case dirs bisync: add options to auto-resolve conflicts - fixes rclone#7471 bisync: check for syntax errors in path args - fixes rclone#7511 bisync: add overlapping paths check bisync: allow lock file expiration/renewal with --max-lock - rclone#7470 bisync: Graceful Shutdown, --recover from interruptions without --resync - fixes rclone#7470 bisync: full support for comparing checksum, size, modtime - fixes rclone#5679 fixes rclone#5683 fixes rclone#5684 fixes rclone#5675 bisync: document beta status more clearly - fixes rclone#6082 bisync: normalize session name to non-canonical - fixes rclone#7423 bisync: update version number in docs bisync: account for differences in backend features on integration tests - see rclone#5679 operations: fix renaming a file on macOS bisync: fallback to cryptcheck or --download when can't check hash local: fix cleanRootPath on Windows after go1.21.4 stdlib update bisync: support two --backup-dir paths on different remotes bisync: support files with unknown length, including Google Docs - fixes rclone#5696 ...
Fornax96
pushed a commit
to Fornaxian/rclone
that referenced
this issue
Jul 30, 2024
Before this change, certain shell quoting / escaping errors (particularly on Windows) were not detected by Bisync, possibly resulting in incorrect expansion and confusing errors. In particular, Windows paths with a single trailing backslash followed by a quote would be interpreted as an escaped quote -- resulting in the quote and subsequent flags being erroneously considered part of the path. After this change, Bisync specifically checks for a few of the most common patterns, and if detected, exits with a more helpful error message before doing any damage.
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The associated forum post URL from
https://forum.rclone.orghttps://forum.rclone.org/t/rclone-cant-create-file-system/43471/18?u=nielash
What is the problem you are having with rclone?
A trailing slash in a quoted local path command arg on Windows causes a fatal error. Example:
results in an error like:
Reported on the forum by a user, and I was able to reproduce it. Removing the trailing slash resolves the issue (confirmed by user). While the fix is easy, it's not immediately obvious, so I think it would be worth trying to catch this and handle it better. Looks like possibly the backslash is being interpreted as escaping the quote -- probably an easy fix.
What is your rclone version (output from
rclone version)How to use GitHub
The text was updated successfully, but these errors were encountered: