Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the guideline to markdown #423

Merged
merged 7 commits into from
Jul 7, 2021
Merged

Update the guideline to markdown #423

merged 7 commits into from
Jul 7, 2021

Conversation

iconstudio
Copy link
Contributor

I replace the text description with a better-looking (I think) readme file. Very small but quite important change.

Copy link
Collaborator

@micwoj92 micwoj92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the fact that this file was named with 0000- was, so it would show near the template 0000.lang and would be on top when you open the folder on GitHub. Now it requires to scroll. Also this change requires changes to main readme, because the document that you deleted is linked there.

Langs/README.md Outdated Show resolved Hide resolved
Langs/README.md Outdated Show resolved Hide resolved
Langs/README.md Outdated Show resolved Hide resolved
Langs/README.md Outdated Show resolved Hide resolved
- Changed the filename: rcmaehl#423 (review)

- The bold text is removed: rcmaehl#423 (comment)

- Missing dot: rcmaehl#423 (comment)

- Spelling and Spamming hashtags: rcmaehl#423 (comment)
- Better markdown listing: rcmaehl#423 (comment)
@iconstudio
Copy link
Contributor Author

iconstudio commented Jul 6, 2021

I fixed the issues, but code quotes can't embed hyperlinks.
Like [here](https://github.com/rcmaehl/WhyNotWin11/pull/423) also [here](https://github.com/rcmaehl/WhyNotWin11/pull/423)

@iconstudio iconstudio requested a review from micwoj92 July 6, 2021 23:52
@micwoj92
Copy link
Collaborator

micwoj92 commented Jul 7, 2021

I know that they can't

@micwoj92
Copy link
Collaborator

micwoj92 commented Jul 7, 2021

Looks good for me, what do you think @rcmaehl ?

@rcmaehl rcmaehl merged commit 2df056c into rcmaehl:main Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants