Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sys_pipe to sys_pipe2 #157

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Update sys_pipe to sys_pipe2 #157

merged 1 commit into from
Aug 19, 2020

Conversation

yukiiiteru
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 19, 2020

Pull Request Test Coverage Report for Build 214816046

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 22 of 28 (78.57%) changed or added relevant lines in 5 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 46.804%

Changes Missing Coverage Covered Lines Changed/Added Lines %
linux-object/src/fs/file.rs 0 1 0.0%
linux-syscall/src/file/fd.rs 9 10 90.0%
linux-syscall/src/lib.rs 0 1 0.0%
linux-object/src/process.rs 12 15 80.0%
Files with Coverage Reduction New Missed Lines %
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/bitflags-1.2.1/src/lib.rs 1 42.2%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/hashbrown-0.7.2/src/map.rs 3 87.1%
../../../../../usr/share/rust/.cargo/registry/src/github.com-1ecc6299db9ec823/hashbrown-0.7.2/src/raw/mod.rs 3 80.45%
Totals Coverage Status
Change from base Build 213400297: 0.1%
Covered Lines: 6744
Relevant Lines: 14409

💛 - Coveralls

@@ -44,6 +44,8 @@ pub struct OpenOptions {
pub append: bool,
/// non block open
pub nonblock: bool,
/// close on exec
pub fd_cloexec: bool,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE:
The cloexec flag can be set through fcntl(fd, F_SETFD, FD_CLOEXEC).
So it should be put into the inner or as an AtomicBool in the future.

@wangrunji0408 wangrunji0408 merged commit 550771f into rcore-os:master Aug 19, 2020
zhangsn-19 pushed a commit to zhangsn-19/zCore that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants