Skip to content
This repository has been archived by the owner on Oct 29, 2019. It is now read-only.

Upgrade to FontAwesome 5.0 #27

Open
aeksco opened this issue Feb 15, 2018 · 1 comment
Open

Upgrade to FontAwesome 5.0 #27

aeksco opened this issue Feb 15, 2018 · 1 comment
Labels
great for beginners UI

Comments

@aeksco
Copy link
Member

aeksco commented Feb 15, 2018 •
edited
Loading

We're currently using FontAwesome 4.7.

See FontAwesome 5 icons here.

Steps

  • Begin by following the TASK comments in observatory-client/index.html This will enable FontAwesome 5.0 and disable FontAwesome 4.7.

  • Search through the repository's *.vue files for <i> tags with the fa CSS class.

  • If an icon is missing from FA 5.0, it will display a little warning icon (see attached) indicating that the icon being used has been deprecated. Search for a suitable replacement on the FA 5.0 icons page and update the <i> element accordingly.

Missing Sort icon warning indicator
screenshot from 2018-02-15 11-38-38
aeksco added a commit to aeksco/observatory-client that referenced this issue Feb 15, 2018
@aeksco
Added comment for issue rcos#27
226a977
@aeksco
Copy link
Member Author

aeksco commented Feb 19, 2018

Note - this ticket will be assigned to Joanna Detweiler (jell0s) when she joins the RCOS GitHub organization.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
great for beginners UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeksco @jell0s