Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp panics when Healthcheck encountered #213

Open
kenjones-cisco opened this issue Aug 22, 2017 · 0 comments
Open

exp panics when Healthcheck encountered #213

kenjones-cisco opened this issue Aug 22, 2017 · 0 comments

Comments

@kenjones-cisco
Copy link

go-metrics/exp/exp.go

Line 137 in 1f30fe9

func (exp *exp) syncToExpvar() {

Seems that syncToExpvar is missing support for Healthcheck types. Either Healthcheck needs to be added or the default could be changed to a no-op instead of panic.
vincentbernat added a commit to vincentbernat/go-metrics that referenced this issue Jul 29, 2018
@vincentbernat
exp: export healthcheck status
d6b8316 
This will trigger the check immediately, then export its status as
".status" with value of 1 if the healthcheck is OK and 0 otherwise. If
the status is 0, the error is stored in ".error", otherwise an empty
string is used.

Fix rcrowley#213
@vincentbernat vincentbernat mentioned this issue Jul 29, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kenjones-cisco