Compute Histogram statistics from Sample values #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed by email, here is a PR to compute
HistogramMax/Min/Mean/Sum/Variance/StdDev/Percentile from Sample values.It uses a
Snapshotstruct which copies values. By this way, all statistics can be computed with the same values.This PR doesn't change current
Histogram#Max/Min/.. methods.According to us, the
Histogramstatistics should be delegated to a Snapshot to be consistant with current Sample values (according its implementation, like a SlidingTimeWindowSample). For example, the Percentile(1) result should be the Max() result.The current overall Histogram statistics (which depends on Clear() usage) could be provided in dedicated methods (or sub structure).