Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReducedEncoder: handle DOD as solvent #46

Merged
merged 2 commits into from May 21, 2018
Merged

ReducedEncoder: handle DOD as solvent #46

merged 2 commits into from May 21, 2018

Conversation

pwrose
Copy link
Collaborator

@pwrose pwrose commented May 21, 2018

There was a logic error in the statement that checks for solvents (HOH, DOD): missing parenthesis.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.904% when pulling ea7e0ef on pwrose:master into 7af43fb on rcsb:master.

josemduarte
josemduarte approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@josemduarte josemduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@pwrose pwrose added the bug label May 21, 2018
@pwrose pwrose merged commit 104509f into rcsb:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemduarte josemduarte josemduarte approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pwrose @coveralls @josemduarte