Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for this package - it works great for auto-CSEing dual number primitive definitions in ForwardDiff.
After JuliaDiff/DiffRules.jl#11, some of these primitive definitions contain
if
statements, which basically means that whenever somebody loads ForwardDiff for this first time, they see a bunch of:For ForwardDiff's case, I don't mind if CSE can't be applied to an expression - I'm fine with this package just trying its best and handing me whatever the result is. Thus, this PR will allow me to disable this warning so users don't get scared.
If you could get a new tag quickly after this is merged, I'd be super appreciative. If that's too complicated, right now, though, I can hack around this warning in ForwardDiff in the meantime.