Lighthouse plugin config and about page file links #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Lighthouse plugin config - set `fail_deploy_on_score_thresholds = "true”` in `[plugins.inputs]` to get some of the old behavior back. mastodon discussion: https://mastodon.social/@rdela/112208080966164909 - PR 588 netlify/netlify-plugin-lighthouse#588 Looks like a bunch of the config options and behavior changed and then netlify disabled issues - netlify-plugin-lighthouse is now in maintenance(-only) mode https://github.com/netlify/netlify-plugin-lighthouse/blob/main/CONTRIBUTING.md https://fosstodon.org/@eleventy/112208087737676821 - explain lowering of seo failure threshold due to `x-robots-tag: noindex` header set on deploy previews 2. about page file links - these worked in README but needed full URLs to trunk branch for the site
✅ Deploy Preview for eleventeen ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set
fail_deploy_on_score_thresholds = "true”in[plugins.inputs]to get some of the old behavior back. mastodon discussion: https://mastodon.social/@rdela/112208080966164909PR 588 feat!: Run plugin on live deploy URL by default netlify/netlify-plugin-lighthouse#588 Looks like a bunch of the config options and behavior changed and then netlify disabled issues
netlify-plugin-lighthouse is now in maintenance(-only) mode https://github.com/netlify/netlify-plugin-lighthouse/blob/main/CONTRIBUTING.md https://fosstodon.org/@eleventy/112208087737676821
explain lowering of seo failure threshold due to
x-robots-tag: noindexheader set on deploy previews