Improve specs and fix some Credo warnings #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelotto
requested changes
Jun 20, 2020
There was a problem hiding this comment.
One word of advice for the future when contributing to OSS: do not make such extensive exclusively aesthetic changes. You won't make any maintainer happy with that. It takes considerable amount of time and effort to review that, but doesn't bring any real value to the project. Keep in mind that most maintainers (including myself) doing this in their spare free time. And although many of your changes look nicer, aesthetics is in the end in the eye of the beholder.
marcelotto
approved these changes
Jun 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.