feat: support output as commonjs/es modules/typescript #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpluscode
commented
Jul 20, 2020
bergos
requested changes
Jul 21, 2020
lib/PlainSerializer.js
Outdated
Comment on lines
27
to
43
| let leadingLines | ||
| switch (module) { | ||
| case 'esm': | ||
| leadingLines = ['export const dataset = ({ blankNode, literal, namedNode, quad }) => {'] | ||
| break | ||
| case 'ts': | ||
| leadingLines = [ | ||
| "import { DataFactory, Quad } from 'rdf-js'", | ||
| '', | ||
| 'export const dataset = ({ blankNode, literal, namedNode, quad }: DataFactory): Quad[] => {' | ||
| ] | ||
| break | ||
| default: | ||
| leadingLines = ['module.exports = ({ blankNode, literal, namedNode, quad }) => {'] | ||
| break | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe it makes sense to use subclasses to handle this? E.g. TS may also use a different code style.
There was a problem hiding this comment.
Instead of going for subclassing I went for a strategy pattern. For now only the leadingLines but could extract other portions in the future which shall differ between output types
tpluscode
commented
Jul 21, 2020
| super({ | ||
| objectMode: true, | ||
| read: () => {} | ||
| }) | ||
|
|
||
| getStream.array(input).then(quads => { | ||
| this.push((new PlainSerializer()).transform(quads)) | ||
| this.push((new PlainSerializer(options)).transform(quads)) |
There was a problem hiding this comment.
Also, I missed this class earlier. You want a test for that?
bergos
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding one more change before we refactor, to control the kind of module to produce (commonjs, ESM, TypeScript)
moduleoption