Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libopenrave-core calls exit #355

Open
morxa opened this issue Jul 1, 2015 · 2 comments
Open

libopenrave-core calls exit #355

morxa opened this issue Jul 1, 2015 · 2 comments

Comments

@morxa
Copy link
Contributor

morxa commented Jul 1, 2015

The shared library libopenrave-core.so calls exit(), which is in many cases undesired behavior for a shared library, because it causes the main binary to terminate without any cleanup.

This was found while creating a Fedora package for openrave. Fedora's packaging guidelines recommend to report such issues to upstream.

I haven't looked at it into detail; but it would probably make sense to replace the exit() call with some kind of error handling.

Thanks for your help!

@rdiankov
Copy link
Owner

rdiankov commented Jul 1, 2015

i agree about the exit calls. i just grepped for any exit fn call, but couldn't find any hits. perhaps you can point out where the exit call is so i can remove it.

thanks

@morxa
Copy link
Contributor Author

morxa commented Jul 7, 2015

The call to exit is in the 3rdparty lib ivcon in line 7512. Looking at the code it seems like it's a typical divide by zero error. So maybe you could throw an exception instead of calling exit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants