Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Control): reorders which update methods are called first #508

Merged
merged 2 commits into from
May 9, 2024
Merged

fix(Control): reorders which update methods are called first #508

merged 2 commits into from
May 9, 2024

Conversation

slhay28
Copy link
Collaborator

@slhay28 slhay28 commented May 7, 2024 •
edited
Loading

Description

  • updates visibility of title before the resizing of the control

References

LUI-1391

Testing

  • make sure there is an icon and text within the control
  • set shouldCollapse to true
  • change the focus state and notice how the contents of the control don't overlap and the size adjusts correctly

Automation

Checklist

  • all commented code has been removed
  • any new console issues have been resolved
  • code linter and formatter has been run
  • test coverage meets repo requirements
  • PR name matches the expected semantic-commit syntax

@svc-lightning-ui-components
Copy link
Contributor

Test Execution Passed.

@svc-lightning-ui-components
Copy link
Contributor

Test Execution Passed.

@ImCoolNowRight ImCoolNowRight merged commit d609442 into develop May 9, 2024
12 checks passed
@ImCoolNowRight ImCoolNowRight deleted the fix/Control-contentOverlap branch May 9, 2024 19:10
svc-lightning-ui-components pushed a commit that referenced this pull request May 10, 2024
@semantic-release-bot
chore(release): 2.21.5 [skip ci]
9f30521 
# [@lightningjs/ui-components-v2.21.5](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.21.4...@lightningjs/ui-components-v2.21.5) (2024-05-10)

### Bug Fixes

* **Artwork:** add imageLoadFailed signal ([#509](#509)) ([7f66c04](7f66c04))
* **Control:** reorders which update methods are called first ([#508](#508)) ([d609442](d609442))
* **NavigationManager:** ensure lazyUpCountBuffer remains non-negative ([#510](#510)) ([af13de0](af13de0))
@svc-lightning-ui-components
Copy link
Contributor

🎉 This PR is included in version @lightningjs/ui-components-v2.21.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImCoolNowRight ImCoolNowRight ImCoolNowRight approved these changes

@ctoddy ctoddy ctoddy approved these changes

@erautenberg erautenberg Awaiting requested review from erautenberg erautenberg is a code owner

@joshhowenstine joshhowenstine Awaiting requested review from joshhowenstine joshhowenstine is a code owner

@anthony9187 anthony9187 Awaiting requested review from anthony9187 anthony9187 is a code owner

@THoj13 THoj13 Awaiting requested review from THoj13 THoj13 is a code owner

@arwehrman arwehrman Awaiting requested review from arwehrman

@jazzyw jazzyw Awaiting requested review from jazzyw

@soumyaloka soumyaloka Awaiting requested review from soumyaloka

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@slhay28 @svc-lightning-ui-components @ImCoolNowRight @ctoddy