fix(NavigationManager): ensure lazyUpCountBuffer remains non-negative #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImCoolNowRight
requested review from
erautenberg,
joshhowenstine,
anthony9187,
THoj13,
arwehrman,
jazzyw,
soumyaloka and
slhay28
as code owners
|
Test Execution Passed. |
ctoddy
approved these changes
May 9, 2024
ImCoolNowRight
force-pushed
the
fix/LUI-1399
branch
from
8b3d916
to
3daa929
Compare
|
Test Execution Passed. |
soumyaloka
approved these changes
May 10, 2024
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
May 10, 2024
# [@lightningjs/ui-components-v2.21.5](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.21.4...@lightningjs/ui-components-v2.21.5) (2024-05-10) ### Bug Fixes * **Artwork:** add imageLoadFailed signal ([#509](#509)) ([7f66c04](7f66c04)) * **Control:** reorders which update methods are called first ([#508](#508)) ([d609442](d609442)) * **NavigationManager:** ensure lazyUpCountBuffer remains non-negative ([#510](#510)) ([af13de0](af13de0))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.21.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a check to make sure that any negative numbers passed in for
lazyUpCountBufferthrows a warning and sets it to zero.References
LUI-1399 and LUI-1403
Testing
Enter a negative value for
lazyUpCountBufferin a Column or Row story. Check the console to ensure that the warning is thrown. The story should operate withlazyUpCountBuffernow being zero.Automation
Not sure if this affects any current tests, but it fixes what the automation team caught.
Checklist