Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDK-49088 Enhanced connectivity monitors #5427

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

cmuhammedrafi
Copy link
Contributor

New design logic added

@cmuhammedrafi cmuhammedrafi reopened this Jun 19, 2024
@cmuhammedrafi cmuhammedrafi force-pushed the sprint/24Q2 branch 2 times, most recently from f2020b4 to f7abdb2 Compare June 20, 2024 11:46
retry logic start value changed
@karuna2git karuna2git merged commit d4ec80d into rdkcentral:sprint/24Q2 Jun 21, 2024
4 of 5 checks passed
cmuhammedrafi added a commit to cmuhammedrafi/rdkservices that referenced this pull request Jul 2, 2024
* Enhanced connectivity monitor intial commit

* configuration read code changed

* remove log lines and event posting modified

retry logic start value changed

(cherry picked from commit d4ec80d)
karuna2git added a commit that referenced this pull request Jul 2, 2024
* DELIA-64891 - Network failed to connect after Reset (#5117)

* DELIA-64891 - Network failed to connect after Reset

Reason for change: Added the missing changes from Network
Test Procedure: Build and verified with curl commands
Risks: Low
Priority: P0
Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>

* DELIA-64891 - Network failed to connect after Reset

Reason for change: Added the missing changes from Network
Test Procedure: Build and verified with curl commands
Risks: Low
Priority: P0
Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>
(cherry picked from commit 1e2fc60)

* DELIA-64891, ES1-1048 : Network failed to connect after Reset (#5139)

* DELIA-64891, ES1-1048 : Network failed to connect after Reset

Reason for change: Avoided posting event when the interface state is empty.
Posting the event only when there is a valid interface state.PSB the details
of the interface state for posting event.
Event name : state
onInterfaceStatusChanged : INTERFACE_REMOVED or INTERFACE_ADDED
onConnectionStatusChanged : INTERFACE_LINK_DOWN or INTERFACE_LINK_UP
Test Procedure: Test and verified with GUI
Risks: Medium
Priority: P1
Signed-off-by: Gururaaja ESR <gururaja_erodesriranganramlingham@comcast.com>
(cherry picked from commit 9840031)

* connectivty monitor updated (#5184)

Connectivty monitor synced up with Network plugin

(cherry picked from commit 751fce0)

* Posting the events only for the eth0 and wlan0 interface (#5189)

(cherry picked from commit 854992e)

* RDK-46636 - NetworkManager backward compatibility (#5203)

Reason for change: Added handler2 support for initiateWPSPairing
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>
(cherry picked from commit fcb8eb7)

* DELIA-65168 - Observed telemetry marker "SYST_ERR_ThunderSrvNotReady" (#5223)

Reason for change: Removed the getenv from NetworkManagerLogger as it is
not required
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>
(cherry picked from commit 66a41a0)

* DELIA-65185 - NetworkManager unified plugin - always returns 128.0.0.0 (#5235)

* DELIA-65185 - NetworkManager unified plugin - always returns 128.0.0.0

Reason for change: Added the changes to get the prefix value from netsrvmgr and converting
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR Gururaja_ErodeSriranganRamlingham@comcast.com
(cherry picked from commit ea1485b)

* DELIA-65170 - NetworkManager unified plugin getIPSettings prefix returns 0 (#5242)

* DELIA-65170 - NetworkManager unified plugin getIPSettings prefix returns 0

Reason for change: Added the changes to get the prefix value from IP/Prefix
and added check for NULL prefix
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>
Co-authored-by: Karunakaran A <48997923+karuna2git@users.noreply.github.com>
(cherry picked from commit 673ed3b)

* DELIA-65229 - InterfaceStateChanged Event not posting In NetworkManager plugin (#5249)

* DELIA-65229 - InterfaceStateChanged Event not posting In NetwrokManger plugin

Reason for change: Changed the comparison between string and char array to
proper string to string comparison
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>
(cherry picked from commit 7d3dd07)

* DELIA-65238 - Network failure retry logic timeout remains as 5 sec (#5259)

* DELIA-65238 - Network failure retry logic timeout remains as 5 sec

Reason for change: Added logic to change the notification count and timeout
to default value, when the global internet state is equal to InternetConnectionState
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>
Co-authored-by: Karunakaran A <48997923+karuna2git@users.noreply.github.com>
(cherry picked from commit b4a44b4)

* DELIA-65341 - getPublicIP is not returning proper value (#5331)

getPublicIP is not returning proper value

Reason for change: Without checking the null check, the config stun endpoint
and port value is being set. Added null condition check so that config value
is taken when it is non empty and default value will be taken when config
value is empty
Test Procedure: Build and verified
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>
(cherry picked from commit 6644f86)

* DELIA-65343, RDK-48562 : Refactor NetworkManager Plugin (#5345)

* Restructure the whole NetworkManager code to be single component & updated COMRPC Proxy Implementation

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>
(cherry picked from commit b57ba00)

* RDKTV-30981 - Devices went to offline plui state (#5366)

* RDKTV-30981 - Devices went to offline plui state

Reason for change: Created authorization token and passed the same for
json RPC call to networkmanager from network plugin.
Also added timer logic to subscribe for events.
Corrected SetInterfaceState and GetInterfaceState function calls.
Updated logger to print file name instead of function name.
Test Procedure: Do CDL and confirm the device boots up in online state
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>

* Update NetworkManagerPlugin.md
Co-authored-by: Karunakaran A <48997923+karuna2git@users.noreply.github.com>

(cherry picked from commit 2bda9e6)

* DELIA-65343 : Devices went to offline plui state after the initial change (#5375)

* DELIA-65343 : Devices went to offline plui state after the initial change

Reason for change: Updated with review comments
Test Procedure: Do CDL and confirm the device boots up in online state
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>
(cherry picked from commit 98c2984)

* DELIA-65419: Delay in providing 'oninternetstatuschange' event from Network Thunder Plugin (#5374)

DELIA-65419: Update no internet event logic in both Network and NetworkManager
(cherry picked from commit 3237958)

* DELIA-65343 - Fixing the trace method of network manager (#5383)

Reason for change: Added the trace ouput details in the Json response object
Test Procedure: Run Trace method curl and check
Risks: Low
Priority: P1
Signed-off-by: Gururaaja ESR <Gururaja_ErodeSriranganRamlingham@comcast.com>
(cherry picked from commit 3d2b6b6)

* RDKTV-31166 posting internet event when interface connection changes (#5407)

* RDKTV-31166 internetStatus Event posting updated

* modefiy the same change in network manager

(cherry picked from commit 00a6207)

* DELIA-65343 : Updated the trace results (#5410)

Updated the trace results
Signed-off-by: kamirt573_comcast <karunakaran_amirthalingam@cable.comcast.com>
(cherry picked from commit af758c3)

* Fixed the setStunEndpoint API and the Subscription Timeout error (#5422)

* Fixed the setStunEndpoint API and the Subscription Timeout error

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>
(cherry picked from commit 5c7a0f6)

* Fix the ClearSSID method (#5430)

* Fix the ClearSSID method

Fix the ClearSSID method

(cherry picked from commit c18ce92)

* Updated the version infomation of NetworkManager Plugin (#5431)

Signed-off-by: Karunakaran A <karunakaran_amirthalingam@cable.comcast.com>
(cherry picked from commit c1b939c)

* RDK-49088 Enhanced connectivity monitors (#5427)

* Enhanced connectivity monitor intial commit

* configuration read code changed

* remove log lines and event posting modified

retry logic start value changed

(cherry picked from commit d4ec80d)

* Enhanced connectivity monitor error fix (#5449)

* Enahanced Connectivity monitor

* ip address change event not coming when wifi reconnect happense

(cherry picked from commit c4d1e81)

* Updated Network Manger plugin Version updated (#5452)

* Updated NetworkManger plugin version

* Update NetworkManager.json

* Update NetworkManagerPlugin.md

(cherry picked from commit c871677)

* [DELIA-65505 DELIA-65521: WiFi connection stuck at connecting screen after entering wrong password and another same wifi issue during FSR process (#5445)

* [DELIA-65505 DELIA-65521: WiFi connection stuck at connecting screen after entering wrong password and another same wifi issue during FSR process

Reason for change: onError EventHandling has been added to NetworkManagerInternalEventHandler, allowing us to obtain the WiFi error codes
Test Procedure: Verify in Jenkin Build
Risks: High
Signed-off-by: Thamim Razith tabbas651@cable.comcast.com
(cherry picked from commit ca8f610)

* Updated Network Manger plugin Version updated (#5453)

(cherry picked from commit d9da07c)

---------

Co-authored-by: gururaajar <83449026+gururaajar@users.noreply.github.com>
Co-authored-by: Karunakaran A <48997923+karuna2git@users.noreply.github.com>
Co-authored-by: tabbas651 <74683978+tabbas651@users.noreply.github.com>
karuna2git pushed a commit to karuna2git/rdkservices that referenced this pull request Jul 4, 2024
* Enhanced connectivity monitor intial commit

* configuration read code changed

* remove log lines and event posting modified

retry logic start value changed

(cherry picked from commit d4ec80d)
karuna2git pushed a commit that referenced this pull request Jul 5, 2024
* Enhanced connectivity monitor intial commit

* configuration read code changed

* remove log lines and event posting modified

retry logic start value changed

(cherry picked from commit d4ec80d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants