-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin the version of boost, boost-python, boost-python3 in homebrew formula #65
Comments
As far as I know, 2017_09 and 2018_03 releases are not compatible to boost 1.67 (which is the boost version will be installed by homebrew). |
Alternatively, it should be possible to temporarily apply this patch to RDKit for Boost 1.67 compatibility: Homebrew patch docs: https://github.com/Homebrew/brew/blob/master/docs/Formula-Cookbook.md#patches It looks like that PR is scheduled for inclusion in the 2018.09.1 release. |
You are right, but it seems to me that pinning the version will be more stable compared to fix the dependencies frequently. |
Just a short update. |
This repository is the rdkit tap, so you could in theory just put the boost@1.66 formula in the |
Finally got my mac laptop back. I put my current effort here: https://github.com/hsiaoyi0504/homebrew-rdkit/tree/pin_boost_version_2. However, I meet several problems:
|
Proposed procedures to be run on local (python3 and using pip install numpy): brew install ./Formula/boost@1.66.rb --build-from-source
brew install ./Formula/boost-python3@1.66.rb --build-from-source
brew install ./Formula/rdkit.rb --build-from-source --with-python3 --without-numpy |
This is a very good idea in order to make the brew formula for rdkit much more reproducible. |
done |
I think this can avoid several issues we met before in the future like #62. By default, homebrew formula will install latest boost. By pinning the version, we can make sure rdkit will be installed by specific boost/boost-python/boost-python3 version. I am currently working on submitting the patches that provide formulas like boost@1.66.
The text was updated successfully, but these errors were encountered: