Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with Boost 1.67+ #1864

Merged
merged 1 commit into from
May 20, 2018
Merged

Conversation

mcs07
Copy link
Contributor

@mcs07 mcs07 commented May 11, 2018

Boost 1.67+ uses a version suffix like "python36" or "python27" for the boost python library. This updates CMakeLists.txt to look for this (in addition to the existing lookups).

See: https://github.com/Kitware/CMake/blob/master/Modules/FindBoost.cmake#L43-L50 and also https://github.com/Kitware/CMake/blob/master/Modules/FindBoost.cmake#L202-L207 for more info.

Tested with boost 1.67 from conda-forge on windows, but this should hopefully also fix homebrew boost 1.67 on Mac - see rdkit/homebrew-rdkit#62.

Boost 1.67+ uses a version suffix like "python36" or "python27" for the boost python library.
@greglandrum greglandrum added this to the 2018_09_1 milestone May 20, 2018
@greglandrum
Copy link
Member

Thanks Matt.

@greglandrum greglandrum merged commit 738fc04 into rdkit:master May 20, 2018
ricrogz pushed a commit to ricrogz/rdkit that referenced this pull request Aug 21, 2018
Boost 1.67+ uses a version suffix like "python36" or "python27" for the boost python library.
@UnixJunkie
Copy link
Collaborator

I think there is a similar problem with boost-1.71

CMake Error at /usr/local/lib/cmake/Boost-1.71.0/BoostConfig.cmake:117 (find_package):
  Could not find a package configuration file provided by "boost_python"
  (requested version 1.71.0) with any of the following names:

    boost_pythonConfig.cmake
    boost_python-config.cmake

  Add the installation prefix of "boost_python" to CMAKE_PREFIX_PATH or set
  "boost_python_DIR" to a directory containing one of the above files.  If
  "boost_python" provides a separate development package or SDK, be sure it
  has been installed.
Call Stack (most recent call first):
  /usr/local/lib/cmake/Boost-1.71.0/BoostConfig.cmake:182 (boost_find_component)
  /usr/local/Cellar/cmake/3.15.3/share/cmake/Modules/FindBoost.cmake:443 (find_package)
  CMakeLists.txt:262 (find_package)

@UnixJunkie
Copy link
Collaborator

@mcs07 can you compile rdkit with boost-1.71? I don't manage to fix this.

@mcs07 mcs07 deleted the boost1.67 branch April 2, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants