-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin boost and boost-python3 #73
Pin boost and boost-python3 #73
Conversation
plus, make the rdkit formula depend on them
to the last version (1.70) that was seen working with the current rdkit release (2019_03_2)
There is a risk that the Travis CI will time out. |
since we rely on version-pinned boost and boost-python3 whose brew formulas are in this tap, we need to explicitely install them too
the Travis things also needed an update, tests are underway |
we will decrease it later, if needed
Thanks for beginning the process to update this. Much appreciated |
We have a problem here: the CI tests go over 50 min so they are stopped no matter what. |
@greglandrum do you want that we fix to a specific version of boost and boost-python3? |
because, our formula will force using a given, fixed version of them
instaed of boost and python previously
I think this can be merged, at last... |
@mcs07 Hi Matt, can you provide some feedback on this PR? |
There were no dissident voices, so I merged. |
When installing
|
Try this:
Send the full log (as a gist) if it doesn't work. |
If you want to improve on that (build time), you can work on this issue: |
Hello,
This should make the rdkit formula much more stable.
I did not create the two boost-related formulas (at version 1.70).
I just took them from the history of the homebrew-core
repository of formulas.
The only drawback I see is that the build time for rdkit on macs
will significantly increase.
But, as a Unix user, I have to admit that seeing something broken today
that was working yesterday annoys me a lot.
So, having the rdkit homebrew formula being more reproducible
is a net advantage.
Regards,
F.