Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rdkit.egg-info directory #97

Closed
flying-sheep opened this issue Aug 13, 2020 · 7 comments
Closed

Add rdkit.egg-info directory #97

flying-sheep opened this issue Aug 13, 2020 · 7 comments
Assignees

Comments

@flying-sheep
Copy link

That metadata allows tools like pip and IDEs to detect that the package is installed.

@UnixJunkie
Copy link
Collaborator

A pull request to support this would be welcome.

@zymergen-luke
Copy link

zymergen-luke commented Mar 16, 2021 via email

@UnixJunkie
Copy link
Collaborator

@zymergen-luke to the best of my knowledge, rdkit cannot be installed with pip.
rdkit/rdkit#1812
Several people are interested into having it work, they might even accept some help.

@flying-sheep
Copy link
Author

flying-sheep commented Mar 17, 2021

Yes, this issue is about adding correct metadata no matter how it is installed.

That would make tools see that RDkit is installed, and allow people to add it to their dependencies.

The way things are now, trying to install a package depending on RDkit results in your package manager (likely pip) to complain that it can’t find a way to install RDkit, despite RDkit being already installed.

@zymergen-luke
Copy link

zymergen-luke commented Mar 17, 2021 via email

@UnixJunkie
Copy link
Collaborator

Well, someone has to contribute this.
And I even wonder if this is not an rdkit issue (this repository is just one brew install recipe for rdkit).

@UnixJunkie
Copy link
Collaborator

This is an rdkit issue, so closing:
Cf. rdkit/rdkit#2690
Comment in there if you want things to progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants