Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix member invite for non unique user email #571

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Fix member invite for non unique user email #571

merged 1 commit into from
Jan 21, 2023

Conversation

jochenklar
Copy link
Member

@jochenklar jochenklar commented Jan 20, 2023 •
edited
Loading

Fixes #561

@jochenklar jochenklar changed the base branch from master to dev January 20, 2023 17:54
@jochenklar jochenklar changed the title Fail silently when 2 users have the same email in the MembershipCreat… Fix member invite for non unique user email Jan 20, 2023
m6121
m6121 approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@m6121 m6121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested in my dev environment. Alternatively, multiple users with the same e-amil might be added right away. However, if we assume that the common case is: e-mails are unique, this is great.

@coveralls
Copy link

coveralls commented Jan 21, 2023 •
edited
Loading

Coverage Status

Coverage: 90.43% (+0.04%) from 90.394% when pulling 37f78de on fix_invite into 77581a2 on dev.

@jochenklar
Copy link
Member Author

Yeah, I think multiple users with the same email should not happen, but this will prevent the 500 if it happens. Otherwise we would need to put more effort in, which I guess is spend better elsewhere.

@jochenklar jochenklar merged commit 66bfdbf into dev Jan 21, 2023
@jochenklar jochenklar deleted the fix_invite branch January 21, 2023 10:48
CalamityC pushed a commit to CalamityC/rdmo that referenced this pull request Nov 23, 2023
@jochenklar
Merge pull request rdmorganiser#571 from rdmorganiser/fix_invite
08103df 
Fix member invite for non unique user email
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m6121 m6121 m6121 approved these changes

@MyPyDavid MyPyDavid Awaiting requested review from MyPyDavid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jochenklar @coveralls @m6121