chore: remove obsolete dependency "jsonfield" #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afuetterer
changed the title
|
Can somebody with existing data test if this kind of change corrupts the database? |
|
Ok, I just checked, the version is relevant is so old, we did not even split the system into rdmo and rdmo-app back then, I will merge. |
CalamityC
pushed a commit
to CalamityC/rdmo
that referenced
this pull request
Nov 23, 2023
…eld-dependency chore: remove obsolete dependency "jsonfield"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR proposed the following changes:
jsonfielddependencyThe fields that utilized the jsonfield dependency where part of the models
ProfileandDetailKey, that were both removed six years ago in https://github.com/rdmorganiser/rdmo/blob/44dcda2f419f6dff269ea5e0128cbcdf0d77006b/rdmo/accounts/migrations/0007_additional_fields.pySo I would suggest removing this dependency. Also if we ever need another
JSONField, Django now supports this on its own without any third party package needed.Related issue: #692