Fix count_questions when no attribute is set for a question #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyPyDavid
reviewed
Dec 19, 2023
MyPyDavid
approved these changes
Dec 19, 2023
jochenklar
commented
Dec 21, 2023
rdmo/projects/progress.py
Outdated
| for set_index in set_indexes: | ||
| if set_index not in counted_sets: | ||
| counted_sets.add(set_index) | ||
| if not isinstance(child, Question): |
There was a problem hiding this comment.
This is less readable in my opinion. I reverted the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.1.1not setting an attribute will cause a (hard to track) 500 on the navigation endpoint.