Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto trigger calculation is not working for first rule per day #143

Closed
MrLight opened this issue May 4, 2020 · 8 comments
Closed

Auto trigger calculation is not working for first rule per day #143

MrLight opened this issue May 4, 2020 · 8 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@MrLight
Copy link

MrLight commented May 4, 2020

Describe the bug
The auto trigger calculation is not working for the first rule per day. If I have a first rule per day which is running from 8:00 AM it does not trigger at 8:00AM but sometimes afterwards (auto trigger interval actually set to 20min) the second one until 9:30AM is triggering precisely at the specified time. I think there is an error in the first calculation per day.

To Reproduce
Steps to reproduce the behavior:

  1. take a clock-timer-node set up a rule from 8:00.
  2. setup a second rule from 9:30
  3. setup autotrigger with interval 20min
  4. watch the first trigger will be somewhere around +/- 8:10

System information (please complete the following information):

  • Version 1.0.17
  • Node-Red Version 1.0.6
@Hypnos3 Hypnos3 self-assigned this May 5, 2020
@Hypnos3 Hypnos3 added the 🐛 bug Something isn't working label May 5, 2020
Hypnos3 added a commit that referenced this issue May 5, 2020
@Hypnos3
Copy link
Collaborator

Hypnos3 commented May 5, 2020

I will improve it with the next Version. However, there may still be situations in which the next valid rule is not recognized.

@steffanv
Copy link

I think this problem appears also for a second rule:
image
Based on my current location the second rule should trigger around 9.20 pm
image
Despite an auto trigger with max 10 minutes the second rule usually triggers the blind around 10 pm

@Hypnos3
Copy link
Collaborator

Hypnos3 commented May 17, 2020

I have still changed anything in the beta version.

@Hypnos3
Copy link
Collaborator

Hypnos3 commented May 20, 2020

Please retest with Version 1.1.0

@Hypnos3 Hypnos3 added the 🕙 awaiting feedback waiting for feedback from ticket owner label May 20, 2020
@MrLight
Copy link
Author

MrLight commented May 23, 2020

HI,
I have updated to the latest Version yesterday. But the triggers from today have not fired yet.
I have assumed one ON event at 12:00 until 12:10 and another one from 14:00 to 14:10. But both where not triggered. I will double check that and will try to give you some more valuable feedback in the next days.
In the previous version I used a dummy trigger directly after midnight to get all in sync. That worked great, for the test I have deactivated the dummy trigger. My auto trigger is set to max. 20min at the moment.

@no-response no-response bot removed the 🕙 awaiting feedback waiting for feedback from ticket owner label May 23, 2020
@MrLight
Copy link
Author

MrLight commented May 24, 2020

It looks like the timer node is not sending the configured topic anymore. So my underlying logic is not detecting the event correctly.
I have injected the node manually before the screenshot. Because of that the correct trigger time is not representable, but in this case it fired at the configured timestamp....
image

@Hypnos3
Copy link
Collaborator

Hypnos3 commented May 24, 2020

I have created a new issue for that problem.
Maybe there is something broken.

@MrLight
Copy link
Author

MrLight commented May 25, 2020

The trigger worked correct today!
Thank you for fixing that!

@Hypnos3 Hypnos3 closed this as completed May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Development

No branches or pull requests

3 participants