Use tripleo-ui review and patchset# instead of short commit #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apevec
force-pushed
the
deps-from-review
branch
3 times, most recently
from
dbddb39
to
df4e646
Compare
This allows building ui-deps RPM before upstream change is merged as discussed in http://lists.openstack.org/pipermail/openstack-dev/2018-January/126412.html
|
@honza please review, this is for http://lists.openstack.org/pipermail/openstack-dev/2018-March/127877.html |
honza
reviewed
Mar 27, 2018
| %global commit e1adf4c78e59fe3911c7429f6a321ea4c98640f9 | ||
| %global shortcommit %(c=%{commit}; echo ${c:0:7}) | ||
| %global review 535323 | ||
| %global patchset 4 |
There was a problem hiding this comment.
Why are we hardcoding these values here? Could we pass them in from the build script?
There was a problem hiding this comment.
This is equivalent of the commit above - build procedure will be the same as before, via .spec update, change is that instead of upstream commit input is review + patchset.
|
Tested locally using https://review.openstack.org/#/c/549251/1 as an example, it appears to works well! 👍 Thank you for the patch. Hopefully we can get this moving soon and stop breaking the RPM every few weeks :) |
|
Excellent, thank you. Sorry for the delayed review. |
rdoproject
pushed a commit
to rdo-packages/tripleo-ui-distgit
that referenced
this pull request
Apr 4, 2024
Patch Set 1: Workflow-1 I guess we need to update tripleo-ui-deps for Rocky? This FTBFS could have been prevent by updating ui-deps in advance of upstream merge using rdo-common/openstack-tripleo-ui-deps#19 @ui team please re-review that! Patch-set: 1 Reviewer: Gerrit User 85 <85@270e2033-b340-4cff-9539-693957ebf0e7> Label: Workflow=-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows building ui-deps RPM before upstream change is merged as discussed in
http://lists.openstack.org/pipermail/openstack-dev/2018-January/126412.html