Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for use with PHPUnit Phar #36

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Dec 11, 2020

When PHPUnit is packaged as a Phar, certain classes are prefixed to prevent conflicts with project dependencies which may use the same files, but in a different version.

For this package, only one referenced class is impacted by this.

The small fix now applied allows for using this package both when running PHPUnit installed via Composer, as well as running Composer installed as a Phar.

@jrfnl
Copy link
Collaborator Author

jrfnl commented Dec 11, 2020

Note: the build failure of this (and the other) PRs is unrelated to the PRs.
The versions of the coding standards (Doctrine, Slevomat, DMS) you are using, don't allow for installing version 0.7.0 (or higher) of the dealerdirect/phpcodesniffer-composer-installer package. That version however is needed for Composer 2.0 support.

I suppose there must be a way to let GHA use Composer 1.x ? For now, that would be the simplest solution to get the builds running & passing again.

When PHPUnit is packaged as a Phar, certain classes are prefixed to prevent conflicts with project dependencies which may use the same files, but in a different version.

For this package, only one referenced class is impacted by this.

The small fix now applied allows for using this package both when running PHPUnit installed via Composer, as well as running Composer installed as a Phar.
@jrfnl jrfnl force-pushed the feature/add-support-for-phpunit-phar branch from f095ae4 to c9086cf Compare April 7, 2021 21:26
@rdohms rdohms added the Feature New feature or request label Apr 7, 2021
@rdohms rdohms merged commit 2c671bf into rdohms:master Apr 7, 2021
@jrfnl jrfnl deleted the feature/add-support-for-phpunit-phar branch April 7, 2021 21:35
@rdohms rdohms added this to the v0.3.0 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants