[NEP-9115] Upgrade to Apartment 2 causes Patches to Fail #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlick
reviewed
Nov 19, 2019
lib/patches/tenant_run_concern.rb
Outdated
| @@ -1,7 +1,7 @@ | |||
| module Patches | |||
| module TenantRunConcern | |||
| def run(tenant_name, path = nil) | |||
| Apartment::Tenant.switch(tenant_name) | |||
| Apartment::Tenant.switch!(tenant_name) | |||
There was a problem hiding this comment.
What about:
Apartment::Tenant.switch(tenant_name) do
Patches::Runner.new(path).perform
end
As recommended by https://github.com/influitive/apartment#switching-tenants
I guess it's so that you don't end up staying switched to the last tenant at the end of the run.
It looks like the change was introduced in apartments v1.0.0:
https://github.com/influitive/apartment/blob/development/HISTORY.md#100
There was a problem hiding this comment.
Thanks @schlick. Good catch. I thought the block was introduced in v2.
msxavi
force-pushed
the
NEP-9115-apartment_upgrade
branch
from
520b509
to
ac350e4
Compare
schlick
approved these changes
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.