Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(error-handling): fix error-handling issues with suspense #54

Merged
merged 2 commits into from
Jul 9, 2020

Conversation

josepot
Copy link
Member

@josepot josepot commented Jul 9, 2020

This was fun! 馃槄

This PR finishes the work that @voliva started on #53
Thanks a lot @voliva for reporting this issue and for all the details that you've provided in #53, we should go over all this stuff at some point.

@josepot josepot requested a review from voliva July 9, 2020 01:38
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #54 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          216       234   +18     
  Branches        23        29    +6     
=========================================
+ Hits           216       234   +18     
Impacted Files Coverage 螖
src/internal/react-enhancer.ts 100.00% <100.00%> (酶)
src/internal/share-latest.ts 100.00% <100.00%> (酶)
src/internal/useObservable.ts 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 869be66...356f9b0. Read the comment docs.

src/internal/useObservable.ts Outdated Show resolved Hide resolved
test/connectFactoryObservable.test.tsx Outdated Show resolved Hide resolved
@josepot josepot merged commit 92ac139 into main Jul 9, 2020
@josepot josepot deleted the fix/boundary-suspense branch July 9, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants