fix(connectObservable): fix updates when dealing with many component #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 246 246
Branches 31 33 +2
=========================================
Hits 246 246
Continue to review full report at Codecov.
|
voliva
commented
Jul 14, 2020
src/internal/react-enhancer.ts
Outdated
| const result = new Observable<T>(subscriber => { | ||
| let isActive = true | ||
| const subscription = source$.subscribe({ | ||
| next(value) { | ||
| if ( | ||
| isActive && | ||
| value !== (COMPLETE as any) && | ||
| !Object.is(latestValue, value) | ||
| !Object.is(initialSyncValue, value) |
There was a problem hiding this comment.
This was the cause. latestValue is shared among all subscribers of the same observable, so only the first one would get the value.
This check was added in #54, and IRC it was done for the batch updates test (at least, it's the test that fails if I remove this check)
voliva
force-pushed
the
propagate-updates
branch
from
3b6b122
to
4a87371
Compare
josepot
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.