Protect Against Solidity Keywords in Structs/Objects #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeapostrophe
requested changes
Jun 2, 2021
DanBurton
approved these changes
Jun 2, 2021
| @@ -0,0 +1 @@ | |||
| reachc: error: ./Err_Sol_Reserved.rsh:5:24:application: `super` is not a valid field name because it is reserved in Solidity. | |||
There was a problem hiding this comment.
Does the _ prefix treatment not handle this use case? Do we intend for it to handle it in the future?
There was a problem hiding this comment.
It's not handled because the Structs have to obey an interface with remote contracts and AFAIK it wouldn't be possible to construct such an object, with an illegal field, before making the call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structnames against a list of reserved wordsObjects preface field names with_.munge/unmungeadds/removes the_appropriately