Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add change language in sidebar and update translation json files #1017

Conversation

ansh-saini
Copy link

@ansh-saini ansh-saini commented Oct 17, 2020

Description

Add a dropdrown for change language in sidebar as requested in #1005

Motivation

Hacktoberfest 2020

Testing Guidelines

Release Checklist

  • This code has unit tests
  • I have a plan to verify that these changes are working as expected after deploy
  • I have a plan for how to revert, rollback, or disable these changes if things are not working as expected

Security Checklist

This PR creates, modifies, or deletes:

  • API routes: API routes, parameters, or user authorization
  • Authentication: Authentication mechanism
  • Credentials: Server side credentials, or secrets in configuration / source code
  • Cryptography: Encryption, hashing, certificates, signatures, random numbers, etc.
  • User data: personal information handling, logs, error messages, etc.

Additional Notes

@shayantist
Copy link
Member

@ethanstrominger why was this closed before merging?

@ashwinkjoseph
Copy link
Contributor

@ethanstrominger there were a few more improvements I would have liked @ansh-saini to make here but overall it looked all right.
I don't think we should close PRs without appropriate reason and explaining it. We should also try to request changes and get a PR fixed rather than closing it. We should resort to closing only if the PR is not relevant to us.
I am re-opening this PR, please mention the reason why this has to be closed

@ashwinkjoseph ashwinkjoseph reopened this Oct 18, 2020
Copy link
Contributor

@ashwinkjoseph ashwinkjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!,
@ansh-saini you only had to change the language in English translation file, we had a tool that would automatically fill it in for the other languages.
I guess this is what you were asking for in slack, sorry misunderstood you then.

@ashwinkjoseph
Copy link
Contributor

@ethanstrominger I am not merging it now, have a look at it and let me know if it can be merged or not.

@ethanstrominger
Copy link
Contributor

@ashwinkjoseph I closed it by mistake.

@ashwinkjoseph ashwinkjoseph merged commit faefed3 into reach4help:development Oct 18, 2020
@ashwinkjoseph
Copy link
Contributor

alright, I've merged it

@ansh-saini
Copy link
Author

Thank you 😄

@ansh-saini
Copy link
Author

@ethanstrominger Can you please add the hacktoberfest-accepted label to this PR?

@ethanstrominger
Copy link
Contributor

@ansh-saini I applied the hacktoberfest-accepted label.

@shayantist
Copy link
Member

Thanks for the help Ansh! @all-contributors please add @ansh-saini for code

@allcontributors
Copy link
Contributor

@schowdhury8

I've put up a pull request to add @ansh-saini! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants