-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add change language in sidebar and update translation json files #1017
feat: add change language in sidebar and update translation json files #1017
Conversation
@ethanstrominger why was this closed before merging? |
@ethanstrominger there were a few more improvements I would have liked @ansh-saini to make here but overall it looked all right. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!,
@ansh-saini you only had to change the language in English translation file, we had a tool that would automatically fill it in for the other languages.
I guess this is what you were asking for in slack, sorry misunderstood you then.
@ethanstrominger I am not merging it now, have a look at it and let me know if it can be merged or not. |
@ashwinkjoseph I closed it by mistake. |
alright, I've merged it |
Thank you 😄 |
@ethanstrominger Can you please add the |
@ansh-saini I applied the hacktoberfest-accepted label. |
Thanks for the help Ansh! @all-contributors please add @ansh-saini for code |
@schowdhury8 I've put up a pull request to add @ansh-saini! 🎉 |
Description
Add a dropdrown for change language in sidebar as requested in #1005
Motivation
Hacktoberfest 2020
Testing Guidelines
Release Checklist
Security Checklist
This PR creates, modifies, or deletes:
Additional Notes