Skip to content

Commit

Permalink
Add missing getType implementation to reactR-generated input bindings…
Browse files Browse the repository at this point in the history
…. Fixes shiny::registerInputHandler with reactR inputs.
  • Loading branch information
alandipert committed Apr 23, 2019
1 parent 6ace2ed commit 0fb80be
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# master

* Add support for `shiny::registerInputHandler` in Shiny inputs; [pull 26](https://github.com/react-R/reactR/pull/26)

# reactR 0.4.0

* Add Shiny input scaffold and functionality; [tutorial](https://react-r.github.io/reactR/articles/intro_inputs.html) and [pull 22](https://github.com/react-R/reactR/pull/22) thanks @alandipert
Expand Down
3 changes: 3 additions & 0 deletions srcjs/input.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ export function reactShinyInput(selector,
find(scope) {
return $(scope).find(selector);
}
getType(el) {
return name;
}
getValue(el) {
return this.getInputValue(el);
}
Expand Down

0 comments on commit 0fb80be

Please sign in to comment.