Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead link in documentation #1638

Closed
timburgess opened this issue Mar 11, 2017 · 1 comment
Closed

Dead link in documentation #1638

timburgess opened this issue Mar 11, 2017 · 1 comment

Comments

@timburgess
Copy link

On the router documentation page,
the link at the very end to https://github.com/ReactTraining/react-router/blob/master/docs/API.md#props-3 404's.

JonathanMerklin added a commit to JonathanMerklin/react-boilerplate that referenced this issue Mar 14, 2017
JonathanMerklin added a commit to JonathanMerklin/react-boilerplate that referenced this issue Mar 14, 2017
gretzky pushed a commit that referenced this issue Dec 28, 2017
* Merge v3.5 release (#1929)

* Docs Update: sass.md | New webpack version -loader suffix (#1484)

* New webpack version -loader suffix

New webpack version no longer allowed to omit the '-loader' suffix when using loaders.

* Webpack 2 migration module.loaders => module.rules

* Fix Loaders/Rules

* chore(docs): fix link to redux-saga docs

Fix a broken link to redux-saga docs.

* feat(webpack): Support OpenType fonts with .otf file extension (#1471)

* chore(docs): improve testing documentation

* [doc] improve code snippet syntax in unit-testing doc

linted code snippet and removed uneeded import

* [doc] add overview of reducer test in unit testing doc

add the completed reducer test file as overview in unit testing documentation

* [doc] improve component testing doc

linted code snippets, added complete test file as refernce and link to next doc page.

* chore(setup): remove LGTM config files (#1317)

* chore(setup): remove LGTM

* Add collaborating guidelines

* Add @KarandikarMihir

* Remove .react.js extensions (#1469)

* Remove .react.js extensions

* Restore file names in the title comments

* Remove hyphens

* chore(deps): update deps roll-up Jan-21-2017 (#1501)

* fix(tests): Replace sinon restore (#1512)

* Remove sinon.restore()

* Lock down sinon version

* chore(all): move to an organisation on GitHub

* Make webpack build less verbose (#1510)

* removed route names from app/routes (#1509)

* removed route names from app/routes

* removed name prop from internals/templates/routes

* removed name from internals/gens/route/route.hbs and routeWithReducer.hbs

* fix(eslint): Enable rule react/no-array-index-key (#1521)

* enable rule react/no-array-index-key

* fix test of List component

* fix(dependencies.js): clean up console clutter for install scripts (#1532)

Ref #1506

* Fix typo i18n.md (#1541)

* chore(deps): update deps roll-up Jan-28-2017 (#1531)

* chore(deps): update deps roll-up Jan-28-2017

* Update package.json

* Set history@3.2.1

* Using optimised version of the banner (#1560)

Taken from #907

* test(build:clean script): remove test:clean from build:clean - fixes coveralls reporting? (#1563)

* Update docs (README.md, Gotchas.md) (#1534)

* Update README.md

* Update gotchas.md

* Add links to gotchas

* Update docs

* Remove redundant sentence

* Move reinstall steps to gotchas.md

* Update README.md

* Minor corrections

* Add jest cache clean to gotchas.md

* Fix team of devs link (#1566)

* chore(deps): update deps roll-up Feb-04-2017 (#1561)

* Add iOS home screen icon (#1585)

* fix manifest icons (#1568)

* manifest(fix) (#1594)

* Change dev source map style (#1559)

* (fix) ProgressBar state error (#1553)

* Bind listener to the current instance of component

* Bring up coverage

* Reassign listener with newly bound listener

* Minor changes

* Separated dev and prod middlewares (#1556)

* Update FAQ with Styles getting overridden (#1592)

* Improve <List> tests (#1134)

* Fix imported styles (#1599)

* Migrate webpack loaders

* Add comment to CSS loader
This should help clarify and reduce common problems

* Split css rules into two

* Updated docs

* First draft of new styling docs

* Fix Sass heading

* Fix links and wording

* Add LESS and other improvements

* Post test fixes

* Updated headings and added more info section

* fix: Intl polyfill for language generator (#1611)

* fix: Intl polyfill for language generator
* fix: appveyor chrome issue by adding suggested --ignore-checksums

* Fix broken link in documentation. Fixes #1638. (#1643)

* refactor(react-router-scroll): Import only useScroll (#1609)

* chore(package.json): sort ESLint config (#1660)

This PR will sort the ESLint configuration alphabetically in `package.json`.

* Fix iOS home screen icons (#1604)



* Use absolute paths

* AppVeyor install chrome ignoring checksums

* Add Stateless Functions to Container Generator (#1494)

* Add Stateless Functions to Container Generator

* Fix linting test for generators

* Tightened up generator type names

- Also made component and container use similar order and language

* Fix odd node5 issue

* and disable eslint for the var

* Fix missing reference (#1725)

* Moving Contrib documentation to the right place (#1721)

* refactor(react-router): Import only necessary components (#1608)

Instead of importing the entire library, cherry-pick the components we use.
This is [supported and encouraged](https://github.com/ReactTraining/react-router/blob/master/docs/guides/MinimizingBundleSize.md) by react-router.

Reduced the size of the main bundle by 9 KB (709 KB -> 700 KB).

* Fixing links for the contributing.md (#1738)

* a grammatical item (#1740)

* Remove state update in componentWillUpdate (#1769)

* syntatical improvements to progress bar (#1633)

* syntatical improvements to progress bar

* declare propTypes and defaultProps on the class instead of using the static keyword

* Improve the setup to recognize our own repo before clearing it. (#1720)

* Add intelligence to the setup to recognize our own repo, before nuking it. (#760, #1719)

* Cleaning up console messages upon setup

* Adding a prompt for deciding whether to clear the repo or not. Fixed: #760, #1719

* Fixing the scenario where it was not exiting this file after not removing the repository

* Doing minor changes suggested

* Updating quickstart file location (#1712)

* Request utils: handle 204 and 205 HTTP response (#1780)

* feat(core): styled-components v2 update (#1775)

* feat(core): styled-components v2 update

* fix(deps): lock version for styled plugin

* Fix: Use local instance of shelljs (#1782)

* Use local instance of shelljs

* Replace var with const

* Switching deprecated babel-preset-latest to babel-preset-env (#1736)

* adding babel-preset-env package

* replacing deprecated babel-preset-latest with babel-preset-env

to avoid the following npm installation warning:
```
npm WARN deprecated babel-preset-latest@6.24.0:
preset-latest accomplishes the same task as babel-preset-env.
Please install it with 'npm install babel-preset-env --save-dev'.
'{ "presets": ["latest"] }' to '{ "presets": ["env"] }'.
For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env
```

Ref. #1667

* removing deprecated babel-preset-latest package

* Add missing word (#1789)

* Migrating from React.PropTypes to PropTypes (#1787)

* adding prop-types dependency

* migrating from React.PropTypes to PropTypes

* Adding some tests (#1784)

* tests(FeaturePage): testing shouldComponentUpdate function

* tests(HomePage): testing if username prop is missing

* tests(ProgressBar): testing when route is not changing

* tests: removing global-styles.js from coverage collect

* tests(Toggle): adding tests for empty values prop

* tests(store): adding missing tests

* tests(ProgressBar): adding missing tests

* chore(deps): update deps roll-up Jun-01-2017 (#1794)

* chore(deps): update deps roll-up Jun-01-2017

* Add react-test-renderer as dev dependency

* Remove `react-addons-test-utils`

* Use new `react-helmet` API

* Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'
Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'

* Revert line that wasn't meant to be commited

* docs(maintenance): Create dependency update doc (#1790)

* docs(maintenance): Create dependency update doc

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Add link to #598

* Update the 'tagged template literals' link to point to its new home at styled-components.com (#1824)

* feat(core): React Router v4, React-Loadable, asyncInjectors (#1746)

* Migrate to react router v4.

* Make sure Switch renders after redux state change by passing in redux location, propagate computedMatch to Route, and make not-found matcher non-exact.

* Fix route generator.

* Implicitly pass store into loader from AsyncRoute to simplify custom child route components.

* Fix route prop propagation.

* Regen yarn.lock

* Keep track of route loading in redux state and read in progress bar.

* Replace AsyncRoute with react-loadable

* Add `DefaultLoadingComponentProvider`

* Rename `loader.js` to `Loadable.js`

* Revert 9f44f1b

* small chores

* Add tests

* Update generators

* Exclude component/Loadable from coverage

* Update docs

* Make App a class that extends React.Component to enable hot reloading

* Add a link to RR4 API

* Improve generators

* Fix linting errors

* Update react-loadable

* Update yarn.lock

* Propagate InnerLoadable props to the rendered component, for Route props like match.

* Refactor

* rename withMappedState -> withConnect

* rename name to key

* Use constants

* Make 'daemon' a default mode for `injectReducer`

* Simplify `ejectSaga`

* Improve docs

* clean up

* recommend to use `ConnectedSwitch`

* turn `App` into a function like it was before

* Run CI

* Import `memoryHistory` and `browserHistory` from `react-router-dom` instead of `react-router`

* Remove path from a 'not found' route

* Update deps

* Simplify tests

* Remove modes from `injectReducer`

* Make second argument to be a descriptor in `sagaInjectors`

* Change `constants` to have consistent values

* Remove non-daemon saga descriptors in production in `ejectSaga`

* Save an entire descriptor in the saga registry

* Fix `constants` in templates

* fix(hmr): Replace `preset-hmre` with vanilla webpack HMR (#1871)

* Replace react-hmre with bare webpack hmr

* Explicitly unmount the main component

* Prevent recomputing reducers for `replaceReducer`

* Add a link to Wepack HMR to the docs

* Remove `overlay=true`

* Accept an array of modules to hot reload

* Add Debugging section in Docs + VS Code instructions (#1698)

* Add debugging section in README

* Move WebStorm FAQ to debugging section

* Add VS Code to debugging section

* Update VS Code launch config

* Update VS Code config to work in dev branch

* Add VS Code launch.json config

* Update launch.json to be compatible with master

* Update VS Code launch to be compatible with master

* Remove .vscode launch config

* Add notice on source map issue for VS Code.

* move onSubmitForm test into mapDispatchToProps test (#1644)

* Use camelcase for reducer and saga key to match selector. (#1888)

* chore(deps): remove unusable deps sinon (#1882)

* chore(deps): downgrade `sanitize.css` (#1872)

* chore(templates): turn `App` into a functional component (#1892)

Fixes #1884

* fix(generators): use correct selector names in tests and regular selectors should not be nested (#1873)

* Rename store.js to configureStore.js to Prevent conflict with storeJS… (#1904)

* Rename store.js to configureStore.js to Prevent conflict with storeJS npm package

* Fix store -> configureStore

* Bump webpack to 3.0.0 and update related deps (#1823)

* Bump webpack to 3.0.0 and related deps

* Add ModuleConcatenationPlugin to webpack base config

* Check in mysterious change in yarn.lock

* Install latest html-webpack-plugin and resolve incorrect peer dep issue

* Update webpack to 3.5.4

* Bump webpack to 3.5.5

* Move ModuleConcatenationPlugin from base to prod config, add  --display-optimization-bailout flag

* Serve Dlls via add-asset-html-webpack-plugin (#1849)

* Serve Dlls via add-asset-html-webpack-plugin

* Remove duplicate dll script tags and cheerio dependency

* Remove cheerio refs from docs

* Minor whitespace change

* Remove eslint exception in webpack.dll.babel.js

* chore(deps): Upgrade React to v15.6 (#1832)

* chore(deps): regenerate `yarn.lock` (#1931)

* chore(deps): regenerate `yarn.lock`

* Empty commit to restart netlify

* chore(3.5): Update changelog.md

* chore(deps): Bump version to 3.5.0

* fix(internals): Update RBP version string in internal config (#2002)

closes #2001

* Correct babel plugin order

here is related issue comment:
babel/babel#5325 (comment)

* fix incorrect merge
@lock
Copy link

lock bot commented May 29, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 29, 2018
gretzky added a commit that referenced this issue Jun 11, 2018
* cherry-pick Webpack v4

* revert reducers.js back to original

* cherry-pick react v16

* Updating order of module resolution in Webpack config, splitting onto multiple lines (#2202)

Boom lets do it

* cherry-pick svg

* cherry-pick webpack v4 addendum

* cherry-pick eslint --fix option

* cherry-pick eslint --fix option

* Correct babel plugin order (#2022)

* Merge v3.5 release (#1929)

* Docs Update: sass.md | New webpack version -loader suffix (#1484)

* New webpack version -loader suffix

New webpack version no longer allowed to omit the '-loader' suffix when using loaders.

* Webpack 2 migration module.loaders => module.rules

* Fix Loaders/Rules

* chore(docs): fix link to redux-saga docs

Fix a broken link to redux-saga docs.

* feat(webpack): Support OpenType fonts with .otf file extension (#1471)

* chore(docs): improve testing documentation

* [doc] improve code snippet syntax in unit-testing doc

linted code snippet and removed uneeded import

* [doc] add overview of reducer test in unit testing doc

add the completed reducer test file as overview in unit testing documentation

* [doc] improve component testing doc

linted code snippets, added complete test file as refernce and link to next doc page.

* chore(setup): remove LGTM config files (#1317)

* chore(setup): remove LGTM

* Add collaborating guidelines

* Add @KarandikarMihir

* Remove .react.js extensions (#1469)

* Remove .react.js extensions

* Restore file names in the title comments

* Remove hyphens

* chore(deps): update deps roll-up Jan-21-2017 (#1501)

* fix(tests): Replace sinon restore (#1512)

* Remove sinon.restore()

* Lock down sinon version

* chore(all): move to an organisation on GitHub

* Make webpack build less verbose (#1510)

* removed route names from app/routes (#1509)

* removed route names from app/routes

* removed name prop from internals/templates/routes

* removed name from internals/gens/route/route.hbs and routeWithReducer.hbs

* fix(eslint): Enable rule react/no-array-index-key (#1521)

* enable rule react/no-array-index-key

* fix test of List component

* fix(dependencies.js): clean up console clutter for install scripts (#1532)

Ref #1506

* Fix typo i18n.md (#1541)

* chore(deps): update deps roll-up Jan-28-2017 (#1531)

* chore(deps): update deps roll-up Jan-28-2017

* Update package.json

* Set history@3.2.1

* Using optimised version of the banner (#1560)

Taken from #907

* test(build:clean script): remove test:clean from build:clean - fixes coveralls reporting? (#1563)

* Update docs (README.md, Gotchas.md) (#1534)

* Update README.md

* Update gotchas.md

* Add links to gotchas

* Update docs

* Remove redundant sentence

* Move reinstall steps to gotchas.md

* Update README.md

* Minor corrections

* Add jest cache clean to gotchas.md

* Fix team of devs link (#1566)

* chore(deps): update deps roll-up Feb-04-2017 (#1561)

* Add iOS home screen icon (#1585)

* fix manifest icons (#1568)

* manifest(fix) (#1594)

* Change dev source map style (#1559)

* (fix) ProgressBar state error (#1553)

* Bind listener to the current instance of component

* Bring up coverage

* Reassign listener with newly bound listener

* Minor changes

* Separated dev and prod middlewares (#1556)

* Update FAQ with Styles getting overridden (#1592)

* Improve <List> tests (#1134)

* Fix imported styles (#1599)

* Migrate webpack loaders

* Add comment to CSS loader
This should help clarify and reduce common problems

* Split css rules into two

* Updated docs

* First draft of new styling docs

* Fix Sass heading

* Fix links and wording

* Add LESS and other improvements

* Post test fixes

* Updated headings and added more info section

* fix: Intl polyfill for language generator (#1611)

* fix: Intl polyfill for language generator
* fix: appveyor chrome issue by adding suggested --ignore-checksums

* Fix broken link in documentation. Fixes #1638. (#1643)

* refactor(react-router-scroll): Import only useScroll (#1609)

* chore(package.json): sort ESLint config (#1660)

This PR will sort the ESLint configuration alphabetically in `package.json`.

* Fix iOS home screen icons (#1604)



* Use absolute paths

* AppVeyor install chrome ignoring checksums

* Add Stateless Functions to Container Generator (#1494)

* Add Stateless Functions to Container Generator

* Fix linting test for generators

* Tightened up generator type names

- Also made component and container use similar order and language

* Fix odd node5 issue

* and disable eslint for the var

* Fix missing reference (#1725)

* Moving Contrib documentation to the right place (#1721)

* refactor(react-router): Import only necessary components (#1608)

Instead of importing the entire library, cherry-pick the components we use.
This is [supported and encouraged](https://github.com/ReactTraining/react-router/blob/master/docs/guides/MinimizingBundleSize.md) by react-router.

Reduced the size of the main bundle by 9 KB (709 KB -> 700 KB).

* Fixing links for the contributing.md (#1738)

* a grammatical item (#1740)

* Remove state update in componentWillUpdate (#1769)

* syntatical improvements to progress bar (#1633)

* syntatical improvements to progress bar

* declare propTypes and defaultProps on the class instead of using the static keyword

* Improve the setup to recognize our own repo before clearing it. (#1720)

* Add intelligence to the setup to recognize our own repo, before nuking it. (#760, #1719)

* Cleaning up console messages upon setup

* Adding a prompt for deciding whether to clear the repo or not. Fixed: #760, #1719

* Fixing the scenario where it was not exiting this file after not removing the repository

* Doing minor changes suggested

* Updating quickstart file location (#1712)

* Request utils: handle 204 and 205 HTTP response (#1780)

* feat(core): styled-components v2 update (#1775)

* feat(core): styled-components v2 update

* fix(deps): lock version for styled plugin

* Fix: Use local instance of shelljs (#1782)

* Use local instance of shelljs

* Replace var with const

* Switching deprecated babel-preset-latest to babel-preset-env (#1736)

* adding babel-preset-env package

* replacing deprecated babel-preset-latest with babel-preset-env

to avoid the following npm installation warning:
```
npm WARN deprecated babel-preset-latest@6.24.0:
preset-latest accomplishes the same task as babel-preset-env.
Please install it with 'npm install babel-preset-env --save-dev'.
'{ "presets": ["latest"] }' to '{ "presets": ["env"] }'.
For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env
```

Ref. #1667

* removing deprecated babel-preset-latest package

* Add missing word (#1789)

* Migrating from React.PropTypes to PropTypes (#1787)

* adding prop-types dependency

* migrating from React.PropTypes to PropTypes

* Adding some tests (#1784)

* tests(FeaturePage): testing shouldComponentUpdate function

* tests(HomePage): testing if username prop is missing

* tests(ProgressBar): testing when route is not changing

* tests: removing global-styles.js from coverage collect

* tests(Toggle): adding tests for empty values prop

* tests(store): adding missing tests

* tests(ProgressBar): adding missing tests

* chore(deps): update deps roll-up Jun-01-2017 (#1794)

* chore(deps): update deps roll-up Jun-01-2017

* Add react-test-renderer as dev dependency

* Remove `react-addons-test-utils`

* Use new `react-helmet` API

* Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'
Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'

* Revert line that wasn't meant to be commited

* docs(maintenance): Create dependency update doc (#1790)

* docs(maintenance): Create dependency update doc

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Add link to #598

* Update the 'tagged template literals' link to point to its new home at styled-components.com (#1824)

* feat(core): React Router v4, React-Loadable, asyncInjectors (#1746)

* Migrate to react router v4.

* Make sure Switch renders after redux state change by passing in redux location, propagate computedMatch to Route, and make not-found matcher non-exact.

* Fix route generator.

* Implicitly pass store into loader from AsyncRoute to simplify custom child route components.

* Fix route prop propagation.

* Regen yarn.lock

* Keep track of route loading in redux state and read in progress bar.

* Replace AsyncRoute with react-loadable

* Add `DefaultLoadingComponentProvider`

* Rename `loader.js` to `Loadable.js`

* Revert 9f44f1b

* small chores

* Add tests

* Update generators

* Exclude component/Loadable from coverage

* Update docs

* Make App a class that extends React.Component to enable hot reloading

* Add a link to RR4 API

* Improve generators

* Fix linting errors

* Update react-loadable

* Update yarn.lock

* Propagate InnerLoadable props to the rendered component, for Route props like match.

* Refactor

* rename withMappedState -> withConnect

* rename name to key

* Use constants

* Make 'daemon' a default mode for `injectReducer`

* Simplify `ejectSaga`

* Improve docs

* clean up

* recommend to use `ConnectedSwitch`

* turn `App` into a function like it was before

* Run CI

* Import `memoryHistory` and `browserHistory` from `react-router-dom` instead of `react-router`

* Remove path from a 'not found' route

* Update deps

* Simplify tests

* Remove modes from `injectReducer`

* Make second argument to be a descriptor in `sagaInjectors`

* Change `constants` to have consistent values

* Remove non-daemon saga descriptors in production in `ejectSaga`

* Save an entire descriptor in the saga registry

* Fix `constants` in templates

* fix(hmr): Replace `preset-hmre` with vanilla webpack HMR (#1871)

* Replace react-hmre with bare webpack hmr

* Explicitly unmount the main component

* Prevent recomputing reducers for `replaceReducer`

* Add a link to Wepack HMR to the docs

* Remove `overlay=true`

* Accept an array of modules to hot reload

* Add Debugging section in Docs + VS Code instructions (#1698)

* Add debugging section in README

* Move WebStorm FAQ to debugging section

* Add VS Code to debugging section

* Update VS Code launch config

* Update VS Code config to work in dev branch

* Add VS Code launch.json config

* Update launch.json to be compatible with master

* Update VS Code launch to be compatible with master

* Remove .vscode launch config

* Add notice on source map issue for VS Code.

* move onSubmitForm test into mapDispatchToProps test (#1644)

* Use camelcase for reducer and saga key to match selector. (#1888)

* chore(deps): remove unusable deps sinon (#1882)

* chore(deps): downgrade `sanitize.css` (#1872)

* chore(templates): turn `App` into a functional component (#1892)

Fixes #1884

* fix(generators): use correct selector names in tests and regular selectors should not be nested (#1873)

* Rename store.js to configureStore.js to Prevent conflict with storeJS… (#1904)

* Rename store.js to configureStore.js to Prevent conflict with storeJS npm package

* Fix store -> configureStore

* Bump webpack to 3.0.0 and update related deps (#1823)

* Bump webpack to 3.0.0 and related deps

* Add ModuleConcatenationPlugin to webpack base config

* Check in mysterious change in yarn.lock

* Install latest html-webpack-plugin and resolve incorrect peer dep issue

* Update webpack to 3.5.4

* Bump webpack to 3.5.5

* Move ModuleConcatenationPlugin from base to prod config, add  --display-optimization-bailout flag

* Serve Dlls via add-asset-html-webpack-plugin (#1849)

* Serve Dlls via add-asset-html-webpack-plugin

* Remove duplicate dll script tags and cheerio dependency

* Remove cheerio refs from docs

* Minor whitespace change

* Remove eslint exception in webpack.dll.babel.js

* chore(deps): Upgrade React to v15.6 (#1832)

* chore(deps): regenerate `yarn.lock` (#1931)

* chore(deps): regenerate `yarn.lock`

* Empty commit to restart netlify

* chore(3.5): Update changelog.md

* chore(deps): Bump version to 3.5.0

* fix(internals): Update RBP version string in internal config (#2002)

closes #2001

* Correct babel plugin order

here is related issue comment:
babel/babel#5325 (comment)

* fix incorrect merge

* Import prop types in component class and stateless generators (#2085)

* updated documentation with more details and missing steps (#2122)

* Remove unnecessary onRejected function from frontFaceObserver (#2155)

* Docs: Add "Setting  up your editor" (#2130)

Follow up on #2073

Adds a new docs page about setting up your editor. This page specifically documents creating a `jsconfig.json` to improve the editing experinace with VS Code

* add ref to login flow example in docs (#2069)

* fix(internals): Fix extract-intl incorrect variable declaring (#2025)

* Fix ejection error of done sagas (#2040)

* Fix ejection error of done sagas

* Correct test for real scenario

* update to redux 4 🎉

* lint

* remove lint:css reference

* add enzyme-to-json to jest snapshot config

* reconfigure the way we test styled-components

* reconfig reducers test
julienben pushed a commit that referenced this issue Jun 20, 2018
* Merge v3.5 release (#1929)

* Docs Update: sass.md | New webpack version -loader suffix (#1484)

* New webpack version -loader suffix

New webpack version no longer allowed to omit the '-loader' suffix when using loaders.

* Webpack 2 migration module.loaders => module.rules

* Fix Loaders/Rules

* chore(docs): fix link to redux-saga docs

Fix a broken link to redux-saga docs.

* feat(webpack): Support OpenType fonts with .otf file extension (#1471)

* chore(docs): improve testing documentation

* [doc] improve code snippet syntax in unit-testing doc

linted code snippet and removed uneeded import

* [doc] add overview of reducer test in unit testing doc

add the completed reducer test file as overview in unit testing documentation

* [doc] improve component testing doc

linted code snippets, added complete test file as refernce and link to next doc page.

* chore(setup): remove LGTM config files (#1317)

* chore(setup): remove LGTM

* Add collaborating guidelines

* Add @KarandikarMihir

* Remove .react.js extensions (#1469)

* Remove .react.js extensions

* Restore file names in the title comments

* Remove hyphens

* chore(deps): update deps roll-up Jan-21-2017 (#1501)

* fix(tests): Replace sinon restore (#1512)

* Remove sinon.restore()

* Lock down sinon version

* chore(all): move to an organisation on GitHub

* Make webpack build less verbose (#1510)

* removed route names from app/routes (#1509)

* removed route names from app/routes

* removed name prop from internals/templates/routes

* removed name from internals/gens/route/route.hbs and routeWithReducer.hbs

* fix(eslint): Enable rule react/no-array-index-key (#1521)

* enable rule react/no-array-index-key

* fix test of List component

* fix(dependencies.js): clean up console clutter for install scripts (#1532)

Ref #1506

* Fix typo i18n.md (#1541)

* chore(deps): update deps roll-up Jan-28-2017 (#1531)

* chore(deps): update deps roll-up Jan-28-2017

* Update package.json

* Set history@3.2.1

* Using optimised version of the banner (#1560)

Taken from #907

* test(build:clean script): remove test:clean from build:clean - fixes coveralls reporting? (#1563)

* Update docs (README.md, Gotchas.md) (#1534)

* Update README.md

* Update gotchas.md

* Add links to gotchas

* Update docs

* Remove redundant sentence

* Move reinstall steps to gotchas.md

* Update README.md

* Minor corrections

* Add jest cache clean to gotchas.md

* Fix team of devs link (#1566)

* chore(deps): update deps roll-up Feb-04-2017 (#1561)

* Add iOS home screen icon (#1585)

* fix manifest icons (#1568)

* manifest(fix) (#1594)

* Change dev source map style (#1559)

* (fix) ProgressBar state error (#1553)

* Bind listener to the current instance of component

* Bring up coverage

* Reassign listener with newly bound listener

* Minor changes

* Separated dev and prod middlewares (#1556)

* Update FAQ with Styles getting overridden (#1592)

* Improve <List> tests (#1134)

* Fix imported styles (#1599)

* Migrate webpack loaders

* Add comment to CSS loader
This should help clarify and reduce common problems

* Split css rules into two

* Updated docs

* First draft of new styling docs

* Fix Sass heading

* Fix links and wording

* Add LESS and other improvements

* Post test fixes

* Updated headings and added more info section

* fix: Intl polyfill for language generator (#1611)

* fix: Intl polyfill for language generator
* fix: appveyor chrome issue by adding suggested --ignore-checksums

* Fix broken link in documentation. Fixes #1638. (#1643)

* refactor(react-router-scroll): Import only useScroll (#1609)

* chore(package.json): sort ESLint config (#1660)

This PR will sort the ESLint configuration alphabetically in `package.json`.

* Fix iOS home screen icons (#1604)



* Use absolute paths

* AppVeyor install chrome ignoring checksums

* Add Stateless Functions to Container Generator (#1494)

* Add Stateless Functions to Container Generator

* Fix linting test for generators

* Tightened up generator type names

- Also made component and container use similar order and language

* Fix odd node5 issue

* and disable eslint for the var

* Fix missing reference (#1725)

* Moving Contrib documentation to the right place (#1721)

* refactor(react-router): Import only necessary components (#1608)

Instead of importing the entire library, cherry-pick the components we use.
This is [supported and encouraged](https://github.com/ReactTraining/react-router/blob/master/docs/guides/MinimizingBundleSize.md) by react-router.

Reduced the size of the main bundle by 9 KB (709 KB -> 700 KB).

* Fixing links for the contributing.md (#1738)

* a grammatical item (#1740)

* Remove state update in componentWillUpdate (#1769)

* syntatical improvements to progress bar (#1633)

* syntatical improvements to progress bar

* declare propTypes and defaultProps on the class instead of using the static keyword

* Improve the setup to recognize our own repo before clearing it. (#1720)

* Add intelligence to the setup to recognize our own repo, before nuking it. (#760, #1719)

* Cleaning up console messages upon setup

* Adding a prompt for deciding whether to clear the repo or not. Fixed: #760, #1719

* Fixing the scenario where it was not exiting this file after not removing the repository

* Doing minor changes suggested

* Updating quickstart file location (#1712)

* Request utils: handle 204 and 205 HTTP response (#1780)

* feat(core): styled-components v2 update (#1775)

* feat(core): styled-components v2 update

* fix(deps): lock version for styled plugin

* Fix: Use local instance of shelljs (#1782)

* Use local instance of shelljs

* Replace var with const

* Switching deprecated babel-preset-latest to babel-preset-env (#1736)

* adding babel-preset-env package

* replacing deprecated babel-preset-latest with babel-preset-env

to avoid the following npm installation warning:
```
npm WARN deprecated babel-preset-latest@6.24.0:
preset-latest accomplishes the same task as babel-preset-env.
Please install it with 'npm install babel-preset-env --save-dev'.
'{ "presets": ["latest"] }' to '{ "presets": ["env"] }'.
For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env
```

Ref. #1667

* removing deprecated babel-preset-latest package

* Add missing word (#1789)

* Migrating from React.PropTypes to PropTypes (#1787)

* adding prop-types dependency

* migrating from React.PropTypes to PropTypes

* Adding some tests (#1784)

* tests(FeaturePage): testing shouldComponentUpdate function

* tests(HomePage): testing if username prop is missing

* tests(ProgressBar): testing when route is not changing

* tests: removing global-styles.js from coverage collect

* tests(Toggle): adding tests for empty values prop

* tests(store): adding missing tests

* tests(ProgressBar): adding missing tests

* chore(deps): update deps roll-up Jun-01-2017 (#1794)

* chore(deps): update deps roll-up Jun-01-2017

* Add react-test-renderer as dev dependency

* Remove `react-addons-test-utils`

* Use new `react-helmet` API

* Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'
Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'

* Revert line that wasn't meant to be commited

* docs(maintenance): Create dependency update doc (#1790)

* docs(maintenance): Create dependency update doc

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Add link to #598

* Update the 'tagged template literals' link to point to its new home at styled-components.com (#1824)

* feat(core): React Router v4, React-Loadable, asyncInjectors (#1746)

* Migrate to react router v4.

* Make sure Switch renders after redux state change by passing in redux location, propagate computedMatch to Route, and make not-found matcher non-exact.

* Fix route generator.

* Implicitly pass store into loader from AsyncRoute to simplify custom child route components.

* Fix route prop propagation.

* Regen yarn.lock

* Keep track of route loading in redux state and read in progress bar.

* Replace AsyncRoute with react-loadable

* Add `DefaultLoadingComponentProvider`

* Rename `loader.js` to `Loadable.js`

* Revert 9f44f1b

* small chores

* Add tests

* Update generators

* Exclude component/Loadable from coverage

* Update docs

* Make App a class that extends React.Component to enable hot reloading

* Add a link to RR4 API

* Improve generators

* Fix linting errors

* Update react-loadable

* Update yarn.lock

* Propagate InnerLoadable props to the rendered component, for Route props like match.

* Refactor

* rename withMappedState -> withConnect

* rename name to key

* Use constants

* Make 'daemon' a default mode for `injectReducer`

* Simplify `ejectSaga`

* Improve docs

* clean up

* recommend to use `ConnectedSwitch`

* turn `App` into a function like it was before

* Run CI

* Import `memoryHistory` and `browserHistory` from `react-router-dom` instead of `react-router`

* Remove path from a 'not found' route

* Update deps

* Simplify tests

* Remove modes from `injectReducer`

* Make second argument to be a descriptor in `sagaInjectors`

* Change `constants` to have consistent values

* Remove non-daemon saga descriptors in production in `ejectSaga`

* Save an entire descriptor in the saga registry

* Fix `constants` in templates

* fix(hmr): Replace `preset-hmre` with vanilla webpack HMR (#1871)

* Replace react-hmre with bare webpack hmr

* Explicitly unmount the main component

* Prevent recomputing reducers for `replaceReducer`

* Add a link to Wepack HMR to the docs

* Remove `overlay=true`

* Accept an array of modules to hot reload

* Add Debugging section in Docs + VS Code instructions (#1698)

* Add debugging section in README

* Move WebStorm FAQ to debugging section

* Add VS Code to debugging section

* Update VS Code launch config

* Update VS Code config to work in dev branch

* Add VS Code launch.json config

* Update launch.json to be compatible with master

* Update VS Code launch to be compatible with master

* Remove .vscode launch config

* Add notice on source map issue for VS Code.

* move onSubmitForm test into mapDispatchToProps test (#1644)

* Use camelcase for reducer and saga key to match selector. (#1888)

* chore(deps): remove unusable deps sinon (#1882)

* chore(deps): downgrade `sanitize.css` (#1872)

* chore(templates): turn `App` into a functional component (#1892)

Fixes #1884

* fix(generators): use correct selector names in tests and regular selectors should not be nested (#1873)

* Rename store.js to configureStore.js to Prevent conflict with storeJS… (#1904)

* Rename store.js to configureStore.js to Prevent conflict with storeJS npm package

* Fix store -> configureStore

* Bump webpack to 3.0.0 and update related deps (#1823)

* Bump webpack to 3.0.0 and related deps

* Add ModuleConcatenationPlugin to webpack base config

* Check in mysterious change in yarn.lock

* Install latest html-webpack-plugin and resolve incorrect peer dep issue

* Update webpack to 3.5.4

* Bump webpack to 3.5.5

* Move ModuleConcatenationPlugin from base to prod config, add  --display-optimization-bailout flag

* Serve Dlls via add-asset-html-webpack-plugin (#1849)

* Serve Dlls via add-asset-html-webpack-plugin

* Remove duplicate dll script tags and cheerio dependency

* Remove cheerio refs from docs

* Minor whitespace change

* Remove eslint exception in webpack.dll.babel.js

* chore(deps): Upgrade React to v15.6 (#1832)

* chore(deps): regenerate `yarn.lock` (#1931)

* chore(deps): regenerate `yarn.lock`

* Empty commit to restart netlify

* chore(3.5): Update changelog.md

* chore(deps): Bump version to 3.5.0

* fix(internals): Update RBP version string in internal config (#2002)

closes #2001

* Correct babel plugin order

here is related issue comment:
babel/babel#5325 (comment)

* fix incorrect merge
gretzky pushed a commit that referenced this issue Jun 21, 2018
* Merge v3.5 release (#1929)

* Docs Update: sass.md | New webpack version -loader suffix (#1484)

* New webpack version -loader suffix

New webpack version no longer allowed to omit the '-loader' suffix when using loaders.

* Webpack 2 migration module.loaders => module.rules

* Fix Loaders/Rules

* chore(docs): fix link to redux-saga docs

Fix a broken link to redux-saga docs.

* feat(webpack): Support OpenType fonts with .otf file extension (#1471)

* chore(docs): improve testing documentation

* [doc] improve code snippet syntax in unit-testing doc

linted code snippet and removed uneeded import

* [doc] add overview of reducer test in unit testing doc

add the completed reducer test file as overview in unit testing documentation

* [doc] improve component testing doc

linted code snippets, added complete test file as refernce and link to next doc page.

* chore(setup): remove LGTM config files (#1317)

* chore(setup): remove LGTM

* Add collaborating guidelines

* Add @KarandikarMihir

* Remove .react.js extensions (#1469)

* Remove .react.js extensions

* Restore file names in the title comments

* Remove hyphens

* chore(deps): update deps roll-up Jan-21-2017 (#1501)

* fix(tests): Replace sinon restore (#1512)

* Remove sinon.restore()

* Lock down sinon version

* chore(all): move to an organisation on GitHub

* Make webpack build less verbose (#1510)

* removed route names from app/routes (#1509)

* removed route names from app/routes

* removed name prop from internals/templates/routes

* removed name from internals/gens/route/route.hbs and routeWithReducer.hbs

* fix(eslint): Enable rule react/no-array-index-key (#1521)

* enable rule react/no-array-index-key

* fix test of List component

* fix(dependencies.js): clean up console clutter for install scripts (#1532)

Ref #1506

* Fix typo i18n.md (#1541)

* chore(deps): update deps roll-up Jan-28-2017 (#1531)

* chore(deps): update deps roll-up Jan-28-2017

* Update package.json

* Set history@3.2.1

* Using optimised version of the banner (#1560)

Taken from #907

* test(build:clean script): remove test:clean from build:clean - fixes coveralls reporting? (#1563)

* Update docs (README.md, Gotchas.md) (#1534)

* Update README.md

* Update gotchas.md

* Add links to gotchas

* Update docs

* Remove redundant sentence

* Move reinstall steps to gotchas.md

* Update README.md

* Minor corrections

* Add jest cache clean to gotchas.md

* Fix team of devs link (#1566)

* chore(deps): update deps roll-up Feb-04-2017 (#1561)

* Add iOS home screen icon (#1585)

* fix manifest icons (#1568)

* manifest(fix) (#1594)

* Change dev source map style (#1559)

* (fix) ProgressBar state error (#1553)

* Bind listener to the current instance of component

* Bring up coverage

* Reassign listener with newly bound listener

* Minor changes

* Separated dev and prod middlewares (#1556)

* Update FAQ with Styles getting overridden (#1592)

* Improve <List> tests (#1134)

* Fix imported styles (#1599)

* Migrate webpack loaders

* Add comment to CSS loader
This should help clarify and reduce common problems

* Split css rules into two

* Updated docs

* First draft of new styling docs

* Fix Sass heading

* Fix links and wording

* Add LESS and other improvements

* Post test fixes

* Updated headings and added more info section

* fix: Intl polyfill for language generator (#1611)

* fix: Intl polyfill for language generator
* fix: appveyor chrome issue by adding suggested --ignore-checksums

* Fix broken link in documentation. Fixes #1638. (#1643)

* refactor(react-router-scroll): Import only useScroll (#1609)

* chore(package.json): sort ESLint config (#1660)

This PR will sort the ESLint configuration alphabetically in `package.json`.

* Fix iOS home screen icons (#1604)



* Use absolute paths

* AppVeyor install chrome ignoring checksums

* Add Stateless Functions to Container Generator (#1494)

* Add Stateless Functions to Container Generator

* Fix linting test for generators

* Tightened up generator type names

- Also made component and container use similar order and language

* Fix odd node5 issue

* and disable eslint for the var

* Fix missing reference (#1725)

* Moving Contrib documentation to the right place (#1721)

* refactor(react-router): Import only necessary components (#1608)

Instead of importing the entire library, cherry-pick the components we use.
This is [supported and encouraged](https://github.com/ReactTraining/react-router/blob/master/docs/guides/MinimizingBundleSize.md) by react-router.

Reduced the size of the main bundle by 9 KB (709 KB -> 700 KB).

* Fixing links for the contributing.md (#1738)

* a grammatical item (#1740)

* Remove state update in componentWillUpdate (#1769)

* syntatical improvements to progress bar (#1633)

* syntatical improvements to progress bar

* declare propTypes and defaultProps on the class instead of using the static keyword

* Improve the setup to recognize our own repo before clearing it. (#1720)

* Add intelligence to the setup to recognize our own repo, before nuking it. (#760, #1719)

* Cleaning up console messages upon setup

* Adding a prompt for deciding whether to clear the repo or not. Fixed: #760, #1719

* Fixing the scenario where it was not exiting this file after not removing the repository

* Doing minor changes suggested

* Updating quickstart file location (#1712)

* Request utils: handle 204 and 205 HTTP response (#1780)

* feat(core): styled-components v2 update (#1775)

* feat(core): styled-components v2 update

* fix(deps): lock version for styled plugin

* Fix: Use local instance of shelljs (#1782)

* Use local instance of shelljs

* Replace var with const

* Switching deprecated babel-preset-latest to babel-preset-env (#1736)

* adding babel-preset-env package

* replacing deprecated babel-preset-latest with babel-preset-env

to avoid the following npm installation warning:
```
npm WARN deprecated babel-preset-latest@6.24.0:
preset-latest accomplishes the same task as babel-preset-env.
Please install it with 'npm install babel-preset-env --save-dev'.
'{ "presets": ["latest"] }' to '{ "presets": ["env"] }'.
For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env
```

Ref. #1667

* removing deprecated babel-preset-latest package

* Add missing word (#1789)

* Migrating from React.PropTypes to PropTypes (#1787)

* adding prop-types dependency

* migrating from React.PropTypes to PropTypes

* Adding some tests (#1784)

* tests(FeaturePage): testing shouldComponentUpdate function

* tests(HomePage): testing if username prop is missing

* tests(ProgressBar): testing when route is not changing

* tests: removing global-styles.js from coverage collect

* tests(Toggle): adding tests for empty values prop

* tests(store): adding missing tests

* tests(ProgressBar): adding missing tests

* chore(deps): update deps roll-up Jun-01-2017 (#1794)

* chore(deps): update deps roll-up Jun-01-2017

* Add react-test-renderer as dev dependency

* Remove `react-addons-test-utils`

* Use new `react-helmet` API

* Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'
Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'

* Revert line that wasn't meant to be commited

* docs(maintenance): Create dependency update doc (#1790)

* docs(maintenance): Create dependency update doc

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Add link to #598

* Update the 'tagged template literals' link to point to its new home at styled-components.com (#1824)

* feat(core): React Router v4, React-Loadable, asyncInjectors (#1746)

* Migrate to react router v4.

* Make sure Switch renders after redux state change by passing in redux location, propagate computedMatch to Route, and make not-found matcher non-exact.

* Fix route generator.

* Implicitly pass store into loader from AsyncRoute to simplify custom child route components.

* Fix route prop propagation.

* Regen yarn.lock

* Keep track of route loading in redux state and read in progress bar.

* Replace AsyncRoute with react-loadable

* Add `DefaultLoadingComponentProvider`

* Rename `loader.js` to `Loadable.js`

* Revert 9f44f1b

* small chores

* Add tests

* Update generators

* Exclude component/Loadable from coverage

* Update docs

* Make App a class that extends React.Component to enable hot reloading

* Add a link to RR4 API

* Improve generators

* Fix linting errors

* Update react-loadable

* Update yarn.lock

* Propagate InnerLoadable props to the rendered component, for Route props like match.

* Refactor

* rename withMappedState -> withConnect

* rename name to key

* Use constants

* Make 'daemon' a default mode for `injectReducer`

* Simplify `ejectSaga`

* Improve docs

* clean up

* recommend to use `ConnectedSwitch`

* turn `App` into a function like it was before

* Run CI

* Import `memoryHistory` and `browserHistory` from `react-router-dom` instead of `react-router`

* Remove path from a 'not found' route

* Update deps

* Simplify tests

* Remove modes from `injectReducer`

* Make second argument to be a descriptor in `sagaInjectors`

* Change `constants` to have consistent values

* Remove non-daemon saga descriptors in production in `ejectSaga`

* Save an entire descriptor in the saga registry

* Fix `constants` in templates

* fix(hmr): Replace `preset-hmre` with vanilla webpack HMR (#1871)

* Replace react-hmre with bare webpack hmr

* Explicitly unmount the main component

* Prevent recomputing reducers for `replaceReducer`

* Add a link to Wepack HMR to the docs

* Remove `overlay=true`

* Accept an array of modules to hot reload

* Add Debugging section in Docs + VS Code instructions (#1698)

* Add debugging section in README

* Move WebStorm FAQ to debugging section

* Add VS Code to debugging section

* Update VS Code launch config

* Update VS Code config to work in dev branch

* Add VS Code launch.json config

* Update launch.json to be compatible with master

* Update VS Code launch to be compatible with master

* Remove .vscode launch config

* Add notice on source map issue for VS Code.

* move onSubmitForm test into mapDispatchToProps test (#1644)

* Use camelcase for reducer and saga key to match selector. (#1888)

* chore(deps): remove unusable deps sinon (#1882)

* chore(deps): downgrade `sanitize.css` (#1872)

* chore(templates): turn `App` into a functional component (#1892)

Fixes #1884

* fix(generators): use correct selector names in tests and regular selectors should not be nested (#1873)

* Rename store.js to configureStore.js to Prevent conflict with storeJS… (#1904)

* Rename store.js to configureStore.js to Prevent conflict with storeJS npm package

* Fix store -> configureStore

* Bump webpack to 3.0.0 and update related deps (#1823)

* Bump webpack to 3.0.0 and related deps

* Add ModuleConcatenationPlugin to webpack base config

* Check in mysterious change in yarn.lock

* Install latest html-webpack-plugin and resolve incorrect peer dep issue

* Update webpack to 3.5.4

* Bump webpack to 3.5.5

* Move ModuleConcatenationPlugin from base to prod config, add  --display-optimization-bailout flag

* Serve Dlls via add-asset-html-webpack-plugin (#1849)

* Serve Dlls via add-asset-html-webpack-plugin

* Remove duplicate dll script tags and cheerio dependency

* Remove cheerio refs from docs

* Minor whitespace change

* Remove eslint exception in webpack.dll.babel.js

* chore(deps): Upgrade React to v15.6 (#1832)

* chore(deps): regenerate `yarn.lock` (#1931)

* chore(deps): regenerate `yarn.lock`

* Empty commit to restart netlify

* chore(3.5): Update changelog.md

* chore(deps): Bump version to 3.5.0

* fix(internals): Update RBP version string in internal config (#2002)

closes #2001

* Correct babel plugin order

here is related issue comment:
babel/babel#5325 (comment)

* fix incorrect merge
julienben added a commit that referenced this issue Jul 3, 2018
* Merge v3.5 release (#1929)

* Docs Update: sass.md | New webpack version -loader suffix (#1484)

* New webpack version -loader suffix

New webpack version no longer allowed to omit the '-loader' suffix when using loaders.

* Webpack 2 migration module.loaders => module.rules

* Fix Loaders/Rules

* chore(docs): fix link to redux-saga docs

Fix a broken link to redux-saga docs.

* feat(webpack): Support OpenType fonts with .otf file extension (#1471)

* chore(docs): improve testing documentation

* [doc] improve code snippet syntax in unit-testing doc

linted code snippet and removed uneeded import

* [doc] add overview of reducer test in unit testing doc

add the completed reducer test file as overview in unit testing documentation

* [doc] improve component testing doc

linted code snippets, added complete test file as refernce and link to next doc page.

* chore(setup): remove LGTM config files (#1317)

* chore(setup): remove LGTM

* Add collaborating guidelines

* Add @KarandikarMihir

* Remove .react.js extensions (#1469)

* Remove .react.js extensions

* Restore file names in the title comments

* Remove hyphens

* chore(deps): update deps roll-up Jan-21-2017 (#1501)

* fix(tests): Replace sinon restore (#1512)

* Remove sinon.restore()

* Lock down sinon version

* chore(all): move to an organisation on GitHub

* Make webpack build less verbose (#1510)

* removed route names from app/routes (#1509)

* removed route names from app/routes

* removed name prop from internals/templates/routes

* removed name from internals/gens/route/route.hbs and routeWithReducer.hbs

* fix(eslint): Enable rule react/no-array-index-key (#1521)

* enable rule react/no-array-index-key

* fix test of List component

* fix(dependencies.js): clean up console clutter for install scripts (#1532)

Ref #1506

* Fix typo i18n.md (#1541)

* chore(deps): update deps roll-up Jan-28-2017 (#1531)

* chore(deps): update deps roll-up Jan-28-2017

* Update package.json

* Set history@3.2.1

* Using optimised version of the banner (#1560)

Taken from #907

* test(build:clean script): remove test:clean from build:clean - fixes coveralls reporting? (#1563)

* Update docs (README.md, Gotchas.md) (#1534)

* Update README.md

* Update gotchas.md

* Add links to gotchas

* Update docs

* Remove redundant sentence

* Move reinstall steps to gotchas.md

* Update README.md

* Minor corrections

* Add jest cache clean to gotchas.md

* Fix team of devs link (#1566)

* chore(deps): update deps roll-up Feb-04-2017 (#1561)

* Add iOS home screen icon (#1585)

* fix manifest icons (#1568)

* manifest(fix) (#1594)

* Change dev source map style (#1559)

* (fix) ProgressBar state error (#1553)

* Bind listener to the current instance of component

* Bring up coverage

* Reassign listener with newly bound listener

* Minor changes

* Separated dev and prod middlewares (#1556)

* Update FAQ with Styles getting overridden (#1592)

* Improve <List> tests (#1134)

* Fix imported styles (#1599)

* Migrate webpack loaders

* Add comment to CSS loader
This should help clarify and reduce common problems

* Split css rules into two

* Updated docs

* First draft of new styling docs

* Fix Sass heading

* Fix links and wording

* Add LESS and other improvements

* Post test fixes

* Updated headings and added more info section

* fix: Intl polyfill for language generator (#1611)

* fix: Intl polyfill for language generator
* fix: appveyor chrome issue by adding suggested --ignore-checksums

* Fix broken link in documentation. Fixes #1638. (#1643)

* refactor(react-router-scroll): Import only useScroll (#1609)

* chore(package.json): sort ESLint config (#1660)

This PR will sort the ESLint configuration alphabetically in `package.json`.

* Fix iOS home screen icons (#1604)



* Use absolute paths

* AppVeyor install chrome ignoring checksums

* Add Stateless Functions to Container Generator (#1494)

* Add Stateless Functions to Container Generator

* Fix linting test for generators

* Tightened up generator type names

- Also made component and container use similar order and language

* Fix odd node5 issue

* and disable eslint for the var

* Fix missing reference (#1725)

* Moving Contrib documentation to the right place (#1721)

* refactor(react-router): Import only necessary components (#1608)

Instead of importing the entire library, cherry-pick the components we use.
This is [supported and encouraged](https://github.com/ReactTraining/react-router/blob/master/docs/guides/MinimizingBundleSize.md) by react-router.

Reduced the size of the main bundle by 9 KB (709 KB -> 700 KB).

* Fixing links for the contributing.md (#1738)

* a grammatical item (#1740)

* Remove state update in componentWillUpdate (#1769)

* syntatical improvements to progress bar (#1633)

* syntatical improvements to progress bar

* declare propTypes and defaultProps on the class instead of using the static keyword

* Improve the setup to recognize our own repo before clearing it. (#1720)

* Add intelligence to the setup to recognize our own repo, before nuking it. (#760, #1719)

* Cleaning up console messages upon setup

* Adding a prompt for deciding whether to clear the repo or not. Fixed: #760, #1719

* Fixing the scenario where it was not exiting this file after not removing the repository

* Doing minor changes suggested

* Updating quickstart file location (#1712)

* Request utils: handle 204 and 205 HTTP response (#1780)

* feat(core): styled-components v2 update (#1775)

* feat(core): styled-components v2 update

* fix(deps): lock version for styled plugin

* Fix: Use local instance of shelljs (#1782)

* Use local instance of shelljs

* Replace var with const

* Switching deprecated babel-preset-latest to babel-preset-env (#1736)

* adding babel-preset-env package

* replacing deprecated babel-preset-latest with babel-preset-env

to avoid the following npm installation warning:
```
npm WARN deprecated babel-preset-latest@6.24.0:
preset-latest accomplishes the same task as babel-preset-env.
Please install it with 'npm install babel-preset-env --save-dev'.
'{ "presets": ["latest"] }' to '{ "presets": ["env"] }'.
For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env
```

Ref. #1667

* removing deprecated babel-preset-latest package

* Add missing word (#1789)

* Migrating from React.PropTypes to PropTypes (#1787)

* adding prop-types dependency

* migrating from React.PropTypes to PropTypes

* Adding some tests (#1784)

* tests(FeaturePage): testing shouldComponentUpdate function

* tests(HomePage): testing if username prop is missing

* tests(ProgressBar): testing when route is not changing

* tests: removing global-styles.js from coverage collect

* tests(Toggle): adding tests for empty values prop

* tests(store): adding missing tests

* tests(ProgressBar): adding missing tests

* chore(deps): update deps roll-up Jun-01-2017 (#1794)

* chore(deps): update deps roll-up Jun-01-2017

* Add react-test-renderer as dev dependency

* Remove `react-addons-test-utils`

* Use new `react-helmet` API

* Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'
Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'

* Revert line that wasn't meant to be commited

* docs(maintenance): Create dependency update doc (#1790)

* docs(maintenance): Create dependency update doc

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Add link to #598

* Update the 'tagged template literals' link to point to its new home at styled-components.com (#1824)

* feat(core): React Router v4, React-Loadable, asyncInjectors (#1746)

* Migrate to react router v4.

* Make sure Switch renders after redux state change by passing in redux location, propagate computedMatch to Route, and make not-found matcher non-exact.

* Fix route generator.

* Implicitly pass store into loader from AsyncRoute to simplify custom child route components.

* Fix route prop propagation.

* Regen yarn.lock

* Keep track of route loading in redux state and read in progress bar.

* Replace AsyncRoute with react-loadable

* Add `DefaultLoadingComponentProvider`

* Rename `loader.js` to `Loadable.js`

* Revert 9f44f1b

* small chores

* Add tests

* Update generators

* Exclude component/Loadable from coverage

* Update docs

* Make App a class that extends React.Component to enable hot reloading

* Add a link to RR4 API

* Improve generators

* Fix linting errors

* Update react-loadable

* Update yarn.lock

* Propagate InnerLoadable props to the rendered component, for Route props like match.

* Refactor

* rename withMappedState -> withConnect

* rename name to key

* Use constants

* Make 'daemon' a default mode for `injectReducer`

* Simplify `ejectSaga`

* Improve docs

* clean up

* recommend to use `ConnectedSwitch`

* turn `App` into a function like it was before

* Run CI

* Import `memoryHistory` and `browserHistory` from `react-router-dom` instead of `react-router`

* Remove path from a 'not found' route

* Update deps

* Simplify tests

* Remove modes from `injectReducer`

* Make second argument to be a descriptor in `sagaInjectors`

* Change `constants` to have consistent values

* Remove non-daemon saga descriptors in production in `ejectSaga`

* Save an entire descriptor in the saga registry

* Fix `constants` in templates

* fix(hmr): Replace `preset-hmre` with vanilla webpack HMR (#1871)

* Replace react-hmre with bare webpack hmr

* Explicitly unmount the main component

* Prevent recomputing reducers for `replaceReducer`

* Add a link to Wepack HMR to the docs

* Remove `overlay=true`

* Accept an array of modules to hot reload

* Add Debugging section in Docs + VS Code instructions (#1698)

* Add debugging section in README

* Move WebStorm FAQ to debugging section

* Add VS Code to debugging section

* Update VS Code launch config

* Update VS Code config to work in dev branch

* Add VS Code launch.json config

* Update launch.json to be compatible with master

* Update VS Code launch to be compatible with master

* Remove .vscode launch config

* Add notice on source map issue for VS Code.

* move onSubmitForm test into mapDispatchToProps test (#1644)

* Use camelcase for reducer and saga key to match selector. (#1888)

* chore(deps): remove unusable deps sinon (#1882)

* chore(deps): downgrade `sanitize.css` (#1872)

* chore(templates): turn `App` into a functional component (#1892)

Fixes #1884

* fix(generators): use correct selector names in tests and regular selectors should not be nested (#1873)

* Rename store.js to configureStore.js to Prevent conflict with storeJS… (#1904)

* Rename store.js to configureStore.js to Prevent conflict with storeJS npm package

* Fix store -> configureStore

* Bump webpack to 3.0.0 and update related deps (#1823)

* Bump webpack to 3.0.0 and related deps

* Add ModuleConcatenationPlugin to webpack base config

* Check in mysterious change in yarn.lock

* Install latest html-webpack-plugin and resolve incorrect peer dep issue

* Update webpack to 3.5.4

* Bump webpack to 3.5.5

* Move ModuleConcatenationPlugin from base to prod config, add  --display-optimization-bailout flag

* Serve Dlls via add-asset-html-webpack-plugin (#1849)

* Serve Dlls via add-asset-html-webpack-plugin

* Remove duplicate dll script tags and cheerio dependency

* Remove cheerio refs from docs

* Minor whitespace change

* Remove eslint exception in webpack.dll.babel.js

* chore(deps): Upgrade React to v15.6 (#1832)

* chore(deps): regenerate `yarn.lock` (#1931)

* chore(deps): regenerate `yarn.lock`

* Empty commit to restart netlify

* chore(3.5): Update changelog.md

* chore(deps): Bump version to 3.5.0

* fix(internals): Update RBP version string in internal config (#2002)

closes #2001

* adds jest -watch / jest -o in package.json

* Revert "adds jest -watch / jest -o in package.json"

This reverts commit 40ff07a.

* Correct a few misspellings (#2133)

Ty ✨

* Revert "Correct a few misspellings (#2133)" (#2134)

This reverts commit 9b3b735.

* update readme to add brief announcement on releases/updates (#2201)

* Update README.md (#2207)

* add Lock app template (#2223)

* Fix eslints (#2229)

* Revert "Fix eslints (#2229)" (#2231)

This reverts commit e173c70.

* Fix ejection error of done sagas (#2040)

* Fix ejection error of done sagas

* Correct test for real scenario

* fix(internals): Fix extract-intl incorrect variable declaring (#2025)

* add ref to login flow example in docs (#2069)

* cherry-pick react v16

* Import prop types in component class and stateless generators (#2085)

* Correct babel plugin order (#2022)

* Merge v3.5 release (#1929)

* Docs Update: sass.md | New webpack version -loader suffix (#1484)

* New webpack version -loader suffix

New webpack version no longer allowed to omit the '-loader' suffix when using loaders.

* Webpack 2 migration module.loaders => module.rules

* Fix Loaders/Rules

* chore(docs): fix link to redux-saga docs

Fix a broken link to redux-saga docs.

* feat(webpack): Support OpenType fonts with .otf file extension (#1471)

* chore(docs): improve testing documentation

* [doc] improve code snippet syntax in unit-testing doc

linted code snippet and removed uneeded import

* [doc] add overview of reducer test in unit testing doc

add the completed reducer test file as overview in unit testing documentation

* [doc] improve component testing doc

linted code snippets, added complete test file as refernce and link to next doc page.

* chore(setup): remove LGTM config files (#1317)

* chore(setup): remove LGTM

* Add collaborating guidelines

* Add @KarandikarMihir

* Remove .react.js extensions (#1469)

* Remove .react.js extensions

* Restore file names in the title comments

* Remove hyphens

* chore(deps): update deps roll-up Jan-21-2017 (#1501)

* fix(tests): Replace sinon restore (#1512)

* Remove sinon.restore()

* Lock down sinon version

* chore(all): move to an organisation on GitHub

* Make webpack build less verbose (#1510)

* removed route names from app/routes (#1509)

* removed route names from app/routes

* removed name prop from internals/templates/routes

* removed name from internals/gens/route/route.hbs and routeWithReducer.hbs

* fix(eslint): Enable rule react/no-array-index-key (#1521)

* enable rule react/no-array-index-key

* fix test of List component

* fix(dependencies.js): clean up console clutter for install scripts (#1532)

Ref #1506

* Fix typo i18n.md (#1541)

* chore(deps): update deps roll-up Jan-28-2017 (#1531)

* chore(deps): update deps roll-up Jan-28-2017

* Update package.json

* Set history@3.2.1

* Using optimised version of the banner (#1560)

Taken from #907

* test(build:clean script): remove test:clean from build:clean - fixes coveralls reporting? (#1563)

* Update docs (README.md, Gotchas.md) (#1534)

* Update README.md

* Update gotchas.md

* Add links to gotchas

* Update docs

* Remove redundant sentence

* Move reinstall steps to gotchas.md

* Update README.md

* Minor corrections

* Add jest cache clean to gotchas.md

* Fix team of devs link (#1566)

* chore(deps): update deps roll-up Feb-04-2017 (#1561)

* Add iOS home screen icon (#1585)

* fix manifest icons (#1568)

* manifest(fix) (#1594)

* Change dev source map style (#1559)

* (fix) ProgressBar state error (#1553)

* Bind listener to the current instance of component

* Bring up coverage

* Reassign listener with newly bound listener

* Minor changes

* Separated dev and prod middlewares (#1556)

* Update FAQ with Styles getting overridden (#1592)

* Improve <List> tests (#1134)

* Fix imported styles (#1599)

* Migrate webpack loaders

* Add comment to CSS loader
This should help clarify and reduce common problems

* Split css rules into two

* Updated docs

* First draft of new styling docs

* Fix Sass heading

* Fix links and wording

* Add LESS and other improvements

* Post test fixes

* Updated headings and added more info section

* fix: Intl polyfill for language generator (#1611)

* fix: Intl polyfill for language generator
* fix: appveyor chrome issue by adding suggested --ignore-checksums

* Fix broken link in documentation. Fixes #1638. (#1643)

* refactor(react-router-scroll): Import only useScroll (#1609)

* chore(package.json): sort ESLint config (#1660)

This PR will sort the ESLint configuration alphabetically in `package.json`.

* Fix iOS home screen icons (#1604)



* Use absolute paths

* AppVeyor install chrome ignoring checksums

* Add Stateless Functions to Container Generator (#1494)

* Add Stateless Functions to Container Generator

* Fix linting test for generators

* Tightened up generator type names

- Also made component and container use similar order and language

* Fix odd node5 issue

* and disable eslint for the var

* Fix missing reference (#1725)

* Moving Contrib documentation to the right place (#1721)

* refactor(react-router): Import only necessary components (#1608)

Instead of importing the entire library, cherry-pick the components we use.
This is [supported and encouraged](https://github.com/ReactTraining/react-router/blob/master/docs/guides/MinimizingBundleSize.md) by react-router.

Reduced the size of the main bundle by 9 KB (709 KB -> 700 KB).

* Fixing links for the contributing.md (#1738)

* a grammatical item (#1740)

* Remove state update in componentWillUpdate (#1769)

* syntatical improvements to progress bar (#1633)

* syntatical improvements to progress bar

* declare propTypes and defaultProps on the class instead of using the static keyword

* Improve the setup to recognize our own repo before clearing it. (#1720)

* Add intelligence to the setup to recognize our own repo, before nuking it. (#760, #1719)

* Cleaning up console messages upon setup

* Adding a prompt for deciding whether to clear the repo or not. Fixed: #760, #1719

* Fixing the scenario where it was not exiting this file after not removing the repository

* Doing minor changes suggested

* Updating quickstart file location (#1712)

* Request utils: handle 204 and 205 HTTP response (#1780)

* feat(core): styled-components v2 update (#1775)

* feat(core): styled-components v2 update

* fix(deps): lock version for styled plugin

* Fix: Use local instance of shelljs (#1782)

* Use local instance of shelljs

* Replace var with const

* Switching deprecated babel-preset-latest to babel-preset-env (#1736)

* adding babel-preset-env package

* replacing deprecated babel-preset-latest with babel-preset-env

to avoid the following npm installation warning:
```
npm WARN deprecated babel-preset-latest@6.24.0:
preset-latest accomplishes the same task as babel-preset-env.
Please install it with 'npm install babel-preset-env --save-dev'.
'{ "presets": ["latest"] }' to '{ "presets": ["env"] }'.
For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env
```

Ref. #1667

* removing deprecated babel-preset-latest package

* Add missing word (#1789)

* Migrating from React.PropTypes to PropTypes (#1787)

* adding prop-types dependency

* migrating from React.PropTypes to PropTypes

* Adding some tests (#1784)

* tests(FeaturePage): testing shouldComponentUpdate function

* tests(HomePage): testing if username prop is missing

* tests(ProgressBar): testing when route is not changing

* tests: removing global-styles.js from coverage collect

* tests(Toggle): adding tests for empty values prop

* tests(store): adding missing tests

* tests(ProgressBar): adding missing tests

* chore(deps): update deps roll-up Jun-01-2017 (#1794)

* chore(deps): update deps roll-up Jun-01-2017

* Add react-test-renderer as dev dependency

* Remove `react-addons-test-utils`

* Use new `react-helmet` API

* Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'
Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'

* Revert line that wasn't meant to be commited

* docs(maintenance): Create dependency update doc (#1790)

* docs(maintenance): Create dependency update doc

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Add link to #598

* Update the 'tagged template literals' link to point to its new home at styled-components.com (#1824)

* feat(core): React Router v4, React-Loadable, asyncInjectors (#1746)

* Migrate to react router v4.

* Make sure Switch renders after redux state change by passing in redux location, propagate computedMatch to Route, and make not-found matcher non-exact.

* Fix route generator.

* Implicitly pass store into loader from AsyncRoute to simplify custom child route components.

* Fix route prop propagation.

* Regen yarn.lock

* Keep track of route loading in redux state and read in progress bar.

* Replace AsyncRoute with react-loadable

* Add `DefaultLoadingComponentProvider`

* Rename `loader.js` to `Loadable.js`

* Revert 9f44f1b

* small chores

* Add tests

* Update generators

* Exclude component/Loadable from coverage

* Update docs

* Make App a class that extends React.Component to enable hot reloading

* Add a link to RR4 API

* Improve generators

* Fix linting errors

* Update react-loadable

* Update yarn.lock

* Propagate InnerLoadable props to the rendered component, for Route props like match.

* Refactor

* rename withMappedState -> withConnect

* rename name to key

* Use constants

* Make 'daemon' a default mode for `injectReducer`

* Simplify `ejectSaga`

* Improve docs

* clean up

* recommend to use `ConnectedSwitch`

* turn `App` into a function like it was before

* Run CI

* Import `memoryHistory` and `browserHistory` from `react-router-dom` instead of `react-router`

* Remove path from a 'not found' route

* Update deps

* Simplify tests

* Remove modes from `injectReducer`

* Make second argument to be a descriptor in `sagaInjectors`

* Change `constants` to have consistent values

* Remove non-daemon saga descriptors in production in `ejectSaga`

* Save an entire descriptor in the saga registry

* Fix `constants` in templates

* fix(hmr): Replace `preset-hmre` with vanilla webpack HMR (#1871)

* Replace react-hmre with bare webpack hmr

* Explicitly unmount the main component

* Prevent recomputing reducers for `replaceReducer`

* Add a link to Wepack HMR to the docs

* Remove `overlay=true`

* Accept an array of modules to hot reload

* Add Debugging section in Docs + VS Code instructions (#1698)

* Add debugging section in README

* Move WebStorm FAQ to debugging section

* Add VS Code to debugging section

* Update VS Code launch config

* Update VS Code config to work in dev branch

* Add VS Code launch.json config

* Update launch.json to be compatible with master

* Update VS Code launch to be compatible with master

* Remove .vscode launch config

* Add notice on source map issue for VS Code.

* move onSubmitForm test into mapDispatchToProps test (#1644)

* Use camelcase for reducer and saga key to match selector. (#1888)

* chore(deps): remove unusable deps sinon (#1882)

* chore(deps): downgrade `sanitize.css` (#1872)

* chore(templates): turn `App` into a functional component (#1892)

Fixes #1884

* fix(generators): use correct selector names in tests and regular selectors should not be nested (#1873)

* Rename store.js to configureStore.js to Prevent conflict with storeJS… (#1904)

* Rename store.js to configureStore.js to Prevent conflict with storeJS npm package

* Fix store -> configureStore

* Bump webpack to 3.0.0 and update related deps (#1823)

* Bump webpack to 3.0.0 and related deps

* Add ModuleConcatenationPlugin to webpack base config

* Check in mysterious change in yarn.lock

* Install latest html-webpack-plugin and resolve incorrect peer dep issue

* Update webpack to 3.5.4

* Bump webpack to 3.5.5

* Move ModuleConcatenationPlugin from base to prod config, add  --display-optimization-bailout flag

* Serve Dlls via add-asset-html-webpack-plugin (#1849)

* Serve Dlls via add-asset-html-webpack-plugin

* Remove duplicate dll script tags and cheerio dependency

* Remove cheerio refs from docs

* Minor whitespace change

* Remove eslint exception in webpack.dll.babel.js

* chore(deps): Upgrade React to v15.6 (#1832)

* chore(deps): regenerate `yarn.lock` (#1931)

* chore(deps): regenerate `yarn.lock`

* Empty commit to restart netlify

* chore(3.5): Update changelog.md

* chore(deps): Bump version to 3.5.0

* fix(internals): Update RBP version string in internal config (#2002)

closes #2001

* Correct babel plugin order

here is related issue comment:
babel/babel#5325 (comment)

* fix incorrect merge

* cherry-pick eslint --fix option

* Docs: Add "Setting  up your editor" (#2130)

Follow up on #2073

Adds a new docs page about setting up your editor. This page specifically documents creating a `jsconfig.json` to improve the editing experinace with VS Code

* cherry-pick Webpack v4

* cherry-pick webpack v4 addendum

* Remove unnecessary onRejected function from frontFaceObserver (#2155)

* cherry-pick svg

* updated documentation with more details and missing steps (#2122)

* Updating order of module resolution in Webpack config, splitting onto multiple lines (#2202)

Boom lets do it

* revert reducers.js back to original

* cherry-pick eslint --fix option

* update to redux 4 🎉

* lint

* remove lint:css reference

* add enzyme-to-json to jest snapshot config

* reconfigure the way we test styled-components

* reconfig reducers test

* Fixed issues with reducers and selectors

* Improve travis build time and node versions

* Some dependency upgrades

* Rever node-plop upgrade

* Ensure that eslint fixes get added to a commit + updated Maintainers list

* Upgrade styled-components to 3.3.2

* Changed eslint setup slightly to avoid breaking existing mechanisms + A few major version upgrades:
- circular-dependency-plugin: latest version required for webpack v4
- babel-plugin-react-transform: deprecated in favor of react-hot-loader but switching to it is a refactor for another time
- babel-eslint: v8 has no breaking changes, simply babel v7 dependencies
- warning: no breaking changes in API
- coveralls: no breaking changes
Changed eslint setup slightly to avoid breaking existing mechanisms + A few major version upgrades:
- circular-dependency-plugin: latest version required for webpack v4
- babel-plugin-react-transform: deprecated in favor of react-hot-loader but switching to it is a refactor for another time
- babel-eslint: v8 has no breaking changes, simply babel v7 dependencies
- warning: no breaking changes in API
- coveralls: no breaking changes

* Small update to docs with better (automatic) MD formatting

* Updated offline-plugin to v5 which supports webpack v4 + AppCache is now disabled by default

* Updated react and other deps to 16.4.1

* Missing a small option in offline-plugin

* Fix new repository setup (#2245)

* ESLint upgrade + Prettier (#2244)

* Started eslint upgrade process

* Full prettier setup, including ESLint integration

* Major code formatting updates post-prettier integration

* Reverted /internals trailing commas for older Node compatibility

* On generator usage, prettify relevant files

* Updated generators to output code more in line with prettier's expectations

* Removed a trailing comma for Node 6

* Removed a trailing comma for Node 6

* Set prettierrc with es5 trailing commas to maintain Node 6 support

* Prettier + ESLint fixes

* Forced to switch everything to ES5 trailing commas for Node 6 compatibility

* Reformatted all the MD files using Prettier

* Potential fix for Appveyor

* Stylelint setup + other dependency upgrades

* Reverted node-plop to the last version which supported node 6

* Fix for script post-plop upgrade + minor doc change

* fix(ci): Remove import from `extract-intl` script

* fix(internal): minor internal fixes and cleanup

- attempt cross-OS compatabilty by running `extract-intl` natively
- make `i18n.js` source of truth for DEFAULT_LOCALE
- update templates
- add missing root `reducer.tests` and `i18n.tests` to generator templates
- remove unused constants from templates

* changelog

* fix(ci): Removes Node 6, async/await in `extract-intl`

* fix(i18n): update plop regex substitutions/templates

* fix(ci): updates test templates to reflect generated app

* More updates made possible by removal of Node v6 support

* nvmrc for netlify + fixes for generators

* Removal of node 6 support means a return of the newer trailing commas

* Added a step to prettify code from the generators

* Node v8 minimum in package.json

* Many documentation updates + no throw on stderr as potential AppVeyor fix

* No more need for prettification in generate script since generators do it themselves

* Added a step about ensuring presence of node v8 in quick start

* Added gretzky to maintainers.md

* ESLint exception no longer necessary after upgrade

* Tiny eslint config update
julienben pushed a commit that referenced this issue Jul 18, 2018
* chore(all): move to an organisation on GitHub

* Add visualizer info (#1732)

I find Chris Bateman'as visualizer to be more useful, especially given the number of dependencies this boilerplate has. Works with the same json stats format.

* Update README.md (#1785)

* Update README.md

* Update README.md

* Update README.md

* Merge v3.5 release (#1929)

* Docs Update: sass.md | New webpack version -loader suffix (#1484)

* New webpack version -loader suffix

New webpack version no longer allowed to omit the '-loader' suffix when using loaders.

* Webpack 2 migration module.loaders => module.rules

* Fix Loaders/Rules

* chore(docs): fix link to redux-saga docs

Fix a broken link to redux-saga docs.

* feat(webpack): Support OpenType fonts with .otf file extension (#1471)

* chore(docs): improve testing documentation

* [doc] improve code snippet syntax in unit-testing doc

linted code snippet and removed uneeded import

* [doc] add overview of reducer test in unit testing doc

add the completed reducer test file as overview in unit testing documentation

* [doc] improve component testing doc

linted code snippets, added complete test file as refernce and link to next doc page.

* chore(setup): remove LGTM config files (#1317)

* chore(setup): remove LGTM

* Add collaborating guidelines

* Add @KarandikarMihir

* Remove .react.js extensions (#1469)

* Remove .react.js extensions

* Restore file names in the title comments

* Remove hyphens

* chore(deps): update deps roll-up Jan-21-2017 (#1501)

* fix(tests): Replace sinon restore (#1512)

* Remove sinon.restore()

* Lock down sinon version

* chore(all): move to an organisation on GitHub

* Make webpack build less verbose (#1510)

* removed route names from app/routes (#1509)

* removed route names from app/routes

* removed name prop from internals/templates/routes

* removed name from internals/gens/route/route.hbs and routeWithReducer.hbs

* fix(eslint): Enable rule react/no-array-index-key (#1521)

* enable rule react/no-array-index-key

* fix test of List component

* fix(dependencies.js): clean up console clutter for install scripts (#1532)

Ref #1506

* Fix typo i18n.md (#1541)

* chore(deps): update deps roll-up Jan-28-2017 (#1531)

* chore(deps): update deps roll-up Jan-28-2017

* Update package.json

* Set history@3.2.1

* Using optimised version of the banner (#1560)

Taken from #907

* test(build:clean script): remove test:clean from build:clean - fixes coveralls reporting? (#1563)

* Update docs (README.md, Gotchas.md) (#1534)

* Update README.md

* Update gotchas.md

* Add links to gotchas

* Update docs

* Remove redundant sentence

* Move reinstall steps to gotchas.md

* Update README.md

* Minor corrections

* Add jest cache clean to gotchas.md

* Fix team of devs link (#1566)

* chore(deps): update deps roll-up Feb-04-2017 (#1561)

* Add iOS home screen icon (#1585)

* fix manifest icons (#1568)

* manifest(fix) (#1594)

* Change dev source map style (#1559)

* (fix) ProgressBar state error (#1553)

* Bind listener to the current instance of component

* Bring up coverage

* Reassign listener with newly bound listener

* Minor changes

* Separated dev and prod middlewares (#1556)

* Update FAQ with Styles getting overridden (#1592)

* Improve <List> tests (#1134)

* Fix imported styles (#1599)

* Migrate webpack loaders

* Add comment to CSS loader
This should help clarify and reduce common problems

* Split css rules into two

* Updated docs

* First draft of new styling docs

* Fix Sass heading

* Fix links and wording

* Add LESS and other improvements

* Post test fixes

* Updated headings and added more info section

* fix: Intl polyfill for language generator (#1611)

* fix: Intl polyfill for language generator
* fix: appveyor chrome issue by adding suggested --ignore-checksums

* Fix broken link in documentation. Fixes #1638. (#1643)

* refactor(react-router-scroll): Import only useScroll (#1609)

* chore(package.json): sort ESLint config (#1660)

This PR will sort the ESLint configuration alphabetically in `package.json`.

* Fix iOS home screen icons (#1604)



* Use absolute paths

* AppVeyor install chrome ignoring checksums

* Add Stateless Functions to Container Generator (#1494)

* Add Stateless Functions to Container Generator

* Fix linting test for generators

* Tightened up generator type names

- Also made component and container use similar order and language

* Fix odd node5 issue

* and disable eslint for the var

* Fix missing reference (#1725)

* Moving Contrib documentation to the right place (#1721)

* refactor(react-router): Import only necessary components (#1608)

Instead of importing the entire library, cherry-pick the components we use.
This is [supported and encouraged](https://github.com/ReactTraining/react-router/blob/master/docs/guides/MinimizingBundleSize.md) by react-router.

Reduced the size of the main bundle by 9 KB (709 KB -> 700 KB).

* Fixing links for the contributing.md (#1738)

* a grammatical item (#1740)

* Remove state update in componentWillUpdate (#1769)

* syntatical improvements to progress bar (#1633)

* syntatical improvements to progress bar

* declare propTypes and defaultProps on the class instead of using the static keyword

* Improve the setup to recognize our own repo before clearing it. (#1720)

* Add intelligence to the setup to recognize our own repo, before nuking it. (#760, #1719)

* Cleaning up console messages upon setup

* Adding a prompt for deciding whether to clear the repo or not. Fixed: #760, #1719

* Fixing the scenario where it was not exiting this file after not removing the repository

* Doing minor changes suggested

* Updating quickstart file location (#1712)

* Request utils: handle 204 and 205 HTTP response (#1780)

* feat(core): styled-components v2 update (#1775)

* feat(core): styled-components v2 update

* fix(deps): lock version for styled plugin

* Fix: Use local instance of shelljs (#1782)

* Use local instance of shelljs

* Replace var with const

* Switching deprecated babel-preset-latest to babel-preset-env (#1736)

* adding babel-preset-env package

* replacing deprecated babel-preset-latest with babel-preset-env

to avoid the following npm installation warning:
```
npm WARN deprecated babel-preset-latest@6.24.0:
preset-latest accomplishes the same task as babel-preset-env.
Please install it with 'npm install babel-preset-env --save-dev'.
'{ "presets": ["latest"] }' to '{ "presets": ["env"] }'.
For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env
```

Ref. #1667

* removing deprecated babel-preset-latest package

* Add missing word (#1789)

* Migrating from React.PropTypes to PropTypes (#1787)

* adding prop-types dependency

* migrating from React.PropTypes to PropTypes

* Adding some tests (#1784)

* tests(FeaturePage): testing shouldComponentUpdate function

* tests(HomePage): testing if username prop is missing

* tests(ProgressBar): testing when route is not changing

* tests: removing global-styles.js from coverage collect

* tests(Toggle): adding tests for empty values prop

* tests(store): adding missing tests

* tests(ProgressBar): adding missing tests

* chore(deps): update deps roll-up Jun-01-2017 (#1794)

* chore(deps): update deps roll-up Jun-01-2017

* Add react-test-renderer as dev dependency

* Remove `react-addons-test-utils`

* Use new `react-helmet` API

* Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'
Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'

* Revert line that wasn't meant to be commited

* docs(maintenance): Create dependency update doc (#1790)

* docs(maintenance): Create dependency update doc

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Add link to #598

* Update the 'tagged template literals' link to point to its new home at styled-components.com (#1824)

* feat(core): React Router v4, React-Loadable, asyncInjectors (#1746)

* Migrate to react router v4.

* Make sure Switch renders after redux state change by passing in redux location, propagate computedMatch to Route, and make not-found matcher non-exact.

* Fix route generator.

* Implicitly pass store into loader from AsyncRoute to simplify custom child route components.

* Fix route prop propagation.

* Regen yarn.lock

* Keep track of route loading in redux state and read in progress bar.

* Replace AsyncRoute with react-loadable

* Add `DefaultLoadingComponentProvider`

* Rename `loader.js` to `Loadable.js`

* Revert 9f44f1b

* small chores

* Add tests

* Update generators

* Exclude component/Loadable from coverage

* Update docs

* Make App a class that extends React.Component to enable hot reloading

* Add a link to RR4 API

* Improve generators

* Fix linting errors

* Update react-loadable

* Update yarn.lock

* Propagate InnerLoadable props to the rendered component, for Route props like match.

* Refactor

* rename withMappedState -> withConnect

* rename name to key

* Use constants

* Make 'daemon' a default mode for `injectReducer`

* Simplify `ejectSaga`

* Improve docs

* clean up

* recommend to use `ConnectedSwitch`

* turn `App` into a function like it was before

* Run CI

* Import `memoryHistory` and `browserHistory` from `react-router-dom` instead of `react-router`

* Remove path from a 'not found' route

* Update deps

* Simplify tests

* Remove modes from `injectReducer`

* Make second argument to be a descriptor in `sagaInjectors`

* Change `constants` to have consistent values

* Remove non-daemon saga descriptors in production in `ejectSaga`

* Save an entire descriptor in the saga registry

* Fix `constants` in templates

* fix(hmr): Replace `preset-hmre` with vanilla webpack HMR (#1871)

* Replace react-hmre with bare webpack hmr

* Explicitly unmount the main component

* Prevent recomputing reducers for `replaceReducer`

* Add a link to Wepack HMR to the docs

* Remove `overlay=true`

* Accept an array of modules to hot reload

* Add Debugging section in Docs + VS Code instructions (#1698)

* Add debugging section in README

* Move WebStorm FAQ to debugging section

* Add VS Code to debugging section

* Update VS Code launch config

* Update VS Code config to work in dev branch

* Add VS Code launch.json config

* Update launch.json to be compatible with master

* Update VS Code launch to be compatible with master

* Remove .vscode launch config

* Add notice on source map issue for VS Code.

* move onSubmitForm test into mapDispatchToProps test (#1644)

* Use camelcase for reducer and saga key to match selector. (#1888)

* chore(deps): remove unusable deps sinon (#1882)

* chore(deps): downgrade `sanitize.css` (#1872)

* chore(templates): turn `App` into a functional component (#1892)

Fixes #1884

* fix(generators): use correct selector names in tests and regular selectors should not be nested (#1873)

* Rename store.js to configureStore.js to Prevent conflict with storeJS… (#1904)

* Rename store.js to configureStore.js to Prevent conflict with storeJS npm package

* Fix store -> configureStore

* Bump webpack to 3.0.0 and update related deps (#1823)

* Bump webpack to 3.0.0 and related deps

* Add ModuleConcatenationPlugin to webpack base config

* Check in mysterious change in yarn.lock

* Install latest html-webpack-plugin and resolve incorrect peer dep issue

* Update webpack to 3.5.4

* Bump webpack to 3.5.5

* Move ModuleConcatenationPlugin from base to prod config, add  --display-optimization-bailout flag

* Serve Dlls via add-asset-html-webpack-plugin (#1849)

* Serve Dlls via add-asset-html-webpack-plugin

* Remove duplicate dll script tags and cheerio dependency

* Remove cheerio refs from docs

* Minor whitespace change

* Remove eslint exception in webpack.dll.babel.js

* chore(deps): Upgrade React to v15.6 (#1832)

* chore(deps): regenerate `yarn.lock` (#1931)

* chore(deps): regenerate `yarn.lock`

* Empty commit to restart netlify

* chore(3.5): Update changelog.md

* chore(deps): Bump version to 3.5.0

* fix(internals): Update RBP version string in internal config (#2002)

closes #2001

* adds jest -watch / jest -o in package.json

* Revert "adds jest -watch / jest -o in package.json"

This reverts commit 40ff07a.

* Correct a few misspellings (#2133)

Ty ✨

* Revert "Correct a few misspellings (#2133)" (#2134)

This reverts commit 9b3b735.

* update readme to add brief announcement on releases/updates (#2201)

* Update README.md (#2207)

* add Lock app template (#2223)

* Fix eslints (#2229)

* Revert "Fix eslints (#2229)" (#2231)

This reverts commit e173c70.

* Fix ejection error of done sagas (#2040)

* Fix ejection error of done sagas

* Correct test for real scenario

* fix(internals): Fix extract-intl incorrect variable declaring (#2025)

* add ref to login flow example in docs (#2069)

* cherry-pick react v16

* Import prop types in component class and stateless generators (#2085)

* Correct babel plugin order (#2022)

* Merge v3.5 release (#1929)

* Docs Update: sass.md | New webpack version -loader suffix (#1484)

* New webpack version -loader suffix

New webpack version no longer allowed to omit the '-loader' suffix when using loaders.

* Webpack 2 migration module.loaders => module.rules

* Fix Loaders/Rules

* chore(docs): fix link to redux-saga docs

Fix a broken link to redux-saga docs.

* feat(webpack): Support OpenType fonts with .otf file extension (#1471)

* chore(docs): improve testing documentation

* [doc] improve code snippet syntax in unit-testing doc

linted code snippet and removed uneeded import

* [doc] add overview of reducer test in unit testing doc

add the completed reducer test file as overview in unit testing documentation

* [doc] improve component testing doc

linted code snippets, added complete test file as refernce and link to next doc page.

* chore(setup): remove LGTM config files (#1317)

* chore(setup): remove LGTM

* Add collaborating guidelines

* Add @KarandikarMihir

* Remove .react.js extensions (#1469)

* Remove .react.js extensions

* Restore file names in the title comments

* Remove hyphens

* chore(deps): update deps roll-up Jan-21-2017 (#1501)

* fix(tests): Replace sinon restore (#1512)

* Remove sinon.restore()

* Lock down sinon version

* chore(all): move to an organisation on GitHub

* Make webpack build less verbose (#1510)

* removed route names from app/routes (#1509)

* removed route names from app/routes

* removed name prop from internals/templates/routes

* removed name from internals/gens/route/route.hbs and routeWithReducer.hbs

* fix(eslint): Enable rule react/no-array-index-key (#1521)

* enable rule react/no-array-index-key

* fix test of List component

* fix(dependencies.js): clean up console clutter for install scripts (#1532)

Ref #1506

* Fix typo i18n.md (#1541)

* chore(deps): update deps roll-up Jan-28-2017 (#1531)

* chore(deps): update deps roll-up Jan-28-2017

* Update package.json

* Set history@3.2.1

* Using optimised version of the banner (#1560)

Taken from #907

* test(build:clean script): remove test:clean from build:clean - fixes coveralls reporting? (#1563)

* Update docs (README.md, Gotchas.md) (#1534)

* Update README.md

* Update gotchas.md

* Add links to gotchas

* Update docs

* Remove redundant sentence

* Move reinstall steps to gotchas.md

* Update README.md

* Minor corrections

* Add jest cache clean to gotchas.md

* Fix team of devs link (#1566)

* chore(deps): update deps roll-up Feb-04-2017 (#1561)

* Add iOS home screen icon (#1585)

* fix manifest icons (#1568)

* manifest(fix) (#1594)

* Change dev source map style (#1559)

* (fix) ProgressBar state error (#1553)

* Bind listener to the current instance of component

* Bring up coverage

* Reassign listener with newly bound listener

* Minor changes

* Separated dev and prod middlewares (#1556)

* Update FAQ with Styles getting overridden (#1592)

* Improve <List> tests (#1134)

* Fix imported styles (#1599)

* Migrate webpack loaders

* Add comment to CSS loader
This should help clarify and reduce common problems

* Split css rules into two

* Updated docs

* First draft of new styling docs

* Fix Sass heading

* Fix links and wording

* Add LESS and other improvements

* Post test fixes

* Updated headings and added more info section

* fix: Intl polyfill for language generator (#1611)

* fix: Intl polyfill for language generator
* fix: appveyor chrome issue by adding suggested --ignore-checksums

* Fix broken link in documentation. Fixes #1638. (#1643)

* refactor(react-router-scroll): Import only useScroll (#1609)

* chore(package.json): sort ESLint config (#1660)

This PR will sort the ESLint configuration alphabetically in `package.json`.

* Fix iOS home screen icons (#1604)



* Use absolute paths

* AppVeyor install chrome ignoring checksums

* Add Stateless Functions to Container Generator (#1494)

* Add Stateless Functions to Container Generator

* Fix linting test for generators

* Tightened up generator type names

- Also made component and container use similar order and language

* Fix odd node5 issue

* and disable eslint for the var

* Fix missing reference (#1725)

* Moving Contrib documentation to the right place (#1721)

* refactor(react-router): Import only necessary components (#1608)

Instead of importing the entire library, cherry-pick the components we use.
This is [supported and encouraged](https://github.com/ReactTraining/react-router/blob/master/docs/guides/MinimizingBundleSize.md) by react-router.

Reduced the size of the main bundle by 9 KB (709 KB -> 700 KB).

* Fixing links for the contributing.md (#1738)

* a grammatical item (#1740)

* Remove state update in componentWillUpdate (#1769)

* syntatical improvements to progress bar (#1633)

* syntatical improvements to progress bar

* declare propTypes and defaultProps on the class instead of using the static keyword

* Improve the setup to recognize our own repo before clearing it. (#1720)

* Add intelligence to the setup to recognize our own repo, before nuking it. (#760, #1719)

* Cleaning up console messages upon setup

* Adding a prompt for deciding whether to clear the repo or not. Fixed: #760, #1719

* Fixing the scenario where it was not exiting this file after not removing the repository

* Doing minor changes suggested

* Updating quickstart file location (#1712)

* Request utils: handle 204 and 205 HTTP response (#1780)

* feat(core): styled-components v2 update (#1775)

* feat(core): styled-components v2 update

* fix(deps): lock version for styled plugin

* Fix: Use local instance of shelljs (#1782)

* Use local instance of shelljs

* Replace var with const

* Switching deprecated babel-preset-latest to babel-preset-env (#1736)

* adding babel-preset-env package

* replacing deprecated babel-preset-latest with babel-preset-env

to avoid the following npm installation warning:
```
npm WARN deprecated babel-preset-latest@6.24.0:
preset-latest accomplishes the same task as babel-preset-env.
Please install it with 'npm install babel-preset-env --save-dev'.
'{ "presets": ["latest"] }' to '{ "presets": ["env"] }'.
For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env
```

Ref. #1667

* removing deprecated babel-preset-latest package

* Add missing word (#1789)

* Migrating from React.PropTypes to PropTypes (#1787)

* adding prop-types dependency

* migrating from React.PropTypes to PropTypes

* Adding some tests (#1784)

* tests(FeaturePage): testing shouldComponentUpdate function

* tests(HomePage): testing if username prop is missing

* tests(ProgressBar): testing when route is not changing

* tests: removing global-styles.js from coverage collect

* tests(Toggle): adding tests for empty values prop

* tests(store): adding missing tests

* tests(ProgressBar): adding missing tests

* chore(deps): update deps roll-up Jun-01-2017 (#1794)

* chore(deps): update deps roll-up Jun-01-2017

* Add react-test-renderer as dev dependency

* Remove `react-addons-test-utils`

* Use new `react-helmet` API

* Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'
Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.'

* Revert line that wasn't meant to be commited

* docs(maintenance): Create dependency update doc (#1790)

* docs(maintenance): Create dependency update doc

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Update dependency.md

* Add link to #598

* Update the 'tagged template literals' link to point to its new home at styled-components.com (#1824)

* feat(core): React Router v4, React-Loadable, asyncInjectors (#1746)

* Migrate to react router v4.

* Make sure Switch renders after redux state change by passing in redux location, propagate computedMatch to Route, and make not-found matcher non-exact.

* Fix route generator.

* Implicitly pass store into loader from AsyncRoute to simplify custom child route components.

* Fix route prop propagation.

* Regen yarn.lock

* Keep track of route loading in redux state and read in progress bar.

* Replace AsyncRoute with react-loadable

* Add `DefaultLoadingComponentProvider`

* Rename `loader.js` to `Loadable.js`

* Revert 9f44f1b

* small chores

* Add tests

* Update generators

* Exclude component/Loadable from coverage

* Update docs

* Make App a class that extends React.Component to enable hot reloading

* Add a link to RR4 API

* Improve generators

* Fix linting errors

* Update react-loadable

* Update yarn.lock

* Propagate InnerLoadable props to the rendered component, for Route props like match.

* Refactor

* rename withMappedState -> withConnect

* rename name to key

* Use constants

* Make 'daemon' a default mode for `injectReducer`

* Simplify `ejectSaga`

* Improve docs

* clean up

* recommend to use `ConnectedSwitch`

* turn `App` into a function like it was before

* Run CI

* Import `memoryHistory` and `browserHistory` from `react-router-dom` instead of `react-router`

* Remove path from a 'not found' route

* Update deps

* Simplify tests

* Remove modes from `injectReducer`

* Make second argument to be a descriptor in `sagaInjectors`

* Change `constants` to have consistent values

* Remove non-daemon saga descriptors in production in `ejectSaga`

* Save an entire descriptor in the saga registry

* Fix `constants` in templates

* fix(hmr): Replace `preset-hmre` with vanilla webpack HMR (#1871)

* Replace react-hmre with bare webpack hmr

* Explicitly unmount the main component

* Prevent recomputing reducers for `replaceReducer`

* Add a link to Wepack HMR to the docs

* Remove `overlay=true`

* Accept an array of modules to hot reload

* Add Debugging section in Docs + VS Code instructions (#1698)

* Add debugging section in README

* Move WebStorm FAQ to debugging section

* Add VS Code to debugging section

* Update VS Code launch config

* Update VS Code config to work in dev branch

* Add VS Code launch.json config

* Update launch.json to be compatible with master

* Update VS Code launch to be compatible with master

* Remove .vscode launch config

* Add notice on source map issue for VS Code.

* move onSubmitForm test into mapDispatchToProps test (#1644)

* Use camelcase for reducer and saga key to match selector. (#1888)

* chore(deps): remove unusable deps sinon (#1882)

* chore(deps): downgrade `sanitize.css` (#1872)

* chore(templates): turn `App` into a functional component (#1892)

Fixes #1884

* fix(generators): use correct selector names in tests and regular selectors should not be nested (#1873)

* Rename store.js to configureStore.js to Prevent conflict with storeJS… (#1904)

* Rename store.js to configureStore.js to Prevent conflict with storeJS npm package

* Fix store -> configureStore

* Bump webpack to 3.0.0 and update related deps (#1823)

* Bump webpack to 3.0.0 and related deps

* Add ModuleConcatenationPlugin to webpack base config

* Check in mysterious change in yarn.lock

* Install latest html-webpack-plugin and resolve incorrect peer dep issue

* Update webpack to 3.5.4

* Bump webpack to 3.5.5

* Move ModuleConcatenationPlugin from base to prod config, add  --display-optimization-bailout flag

* Serve Dlls via add-asset-html-webpack-plugin (#1849)

* Serve Dlls via add-asset-html-webpack-plugin

* Remove duplicate dll script tags and cheerio dependency

* Remove cheerio refs from docs

* Minor whitespace change

* Remove eslint exception in webpack.dll.babel.js

* chore(deps): Upgrade React to v15.6 (#1832)

* chore(deps): regenerate `yarn.lock` (#1931)

* chore(deps): regenerate `yarn.lock`

* Empty commit to restart netlify

* chore(3.5): Update changelog.md

* chore(deps): Bump version to 3.5.0

* fix(internals): Update RBP version string in internal config (#2002)

closes #2001

* Correct babel plugin order

here is related issue comment:
babel/babel#5325 (comment)

* fix incorrect merge

* cherry-pick eslint --fix option

* Docs: Add "Setting  up your editor" (#2130)

Follow up on #2073

Adds a new docs page about setting up your editor. This page specifically documents creating a `jsconfig.json` to improve the editing experinace with VS Code

* cherry-pick Webpack v4

* cherry-pick webpack v4 addendum

* Remove unnecessary onRejected function from frontFaceObserver (#2155)

* cherry-pick svg

* updated documentation with more details and missing steps (#2122)

* Updating order of module resolution in Webpack config, splitting onto multiple lines (#2202)

Boom lets do it

* revert reducers.js back to original

* cherry-pick eslint --fix option

* update to redux 4 🎉

* lint

* remove lint:css reference

* add enzyme-to-json to jest snapshot config

* reconfigure the way we test styled-components

* reconfig reducers test

* Fixed issues with reducers and selectors

* Improve travis build time and node versions

* Some dependency upgrades

* Rever node-plop upgrade

* Ensure that eslint fixes get added to a commit + updated Maintainers list

* Upgrade styled-components to 3.3.2

* Changed eslint setup slightly to avoid breaking existing mechanisms + A few major version upgrades:
- circular-dependency-plugin: latest version required for webpack v4
- babel-plugin-react-transform: deprecated in favor of react-hot-loader but switching to it is a refactor for another time
- babel-eslint: v8 has no breaking changes, simply babel v7 dependencies
- warning: no breaking changes in API
- coveralls: no breaking changes
Changed eslint setup slightly to avoid breaking existing mechanisms + A few major version upgrades:
- circular-dependency-plugin: latest version required for webpack v4
- babel-plugin-react-transform: deprecated in favor of react-hot-loader but switching to it is a refactor for another time
- babel-eslint: v8 has no breaking changes, simply babel v7 dependencies
- warning: no breaking changes in API
- coveralls: no breaking changes

* Small update to docs with better (automatic) MD formatting

* Updated offline-plugin to v5 which supports webpack v4 + AppCache is now disabled by default

* Updated react and other deps to 16.4.1

* Missing a small option in offline-plugin

* Fix new repository setup (#2245)

* ESLint upgrade + Prettier (#2244)

* Started eslint upgrade process

* Full prettier setup, including ESLint integration

* Major code formatting updates post-prettier integration

* Reverted /internals trailing commas for older Node compatibility

* On generator usage, prettify relevant files

* Updated generators to output code more in line with prettier's expectations

* Removed a trailing comma for Node 6

* Removed a trailing comma for Node 6

* Set prettierrc with es5 trailing commas to maintain Node 6 support

* Prettier + ESLint fixes

* Forced to switch everything to ES5 trailing commas for Node 6 compatibility

* Reformatted all the MD files using Prettier

* Potential fix for Appveyor

* Stylelint setup + other dependency upgrades

* Reverted node-plop to the last version which supported node 6

* Fix for script post-plop upgrade + minor doc change

* fix(ci): Remove import from `extract-intl` script

* fix(internal): minor internal fixes and cleanup

- attempt cross-OS compatabilty by running `extract-intl` natively
- make `i18n.js` source of truth for DEFAULT_LOCALE
- update templates
- add missing root `reducer.tests` and `i18n.tests` to generator templates
- remove unused constants from templates

* changelog

* fix(ci): Removes Node 6, async/await in `extract-intl`

* fix(i18n): update plop regex substitutions/templates

* fix(ci): updates test templates to reflect generated app

* More updates made possible by removal of Node v6 support

* nvmrc for netlify + fixes for generators

* Removal of node 6 support means a return of the newer trailing commas

* Added a step to prettify code from the generators

* Node v8 minimum in package.json

* Many documentation updates + no throw on stderr as potential AppVeyor fix

* No more need for prettification in generate script since generators do it themselves

* Added a step about ensuring presence of node v8 in quick start

* Added gretzky to maintainers.md

* ESLint exception no longer necessary after upgrade

* Tiny eslint config update
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant