Update docs (README.md, Gotchas.md) #1534

mihir0x69 · 2017-01-29T11:57:48Z

It's still in progress.

UPDATE
I think this one's ready for scrutiny.

mxstbr

Love the additions, two small nitpicks!

mxstbr · 2017-01-29T15:10:06Z

README.md

@@ -97,6 +97,8 @@ There’s also a <a href="https://vimeo.com/168648012">fantastic video</a> on ho

 ## Quick start

+**We strongly recommend that you use yarn over npm because yarn installs dependencies in a stable and predictable way. As a bonus, you'll get faster installation and cleaner console!**


I don't think we need to make such a highlighted statement, imo the section below should be good enough. There's more important stuff for beginners to worry about rather than "Wtf is yarn"?

😄 That's right. Removing!

mxstbr · 2017-01-29T15:10:44Z

docs/general/gotchas.md

+]
+```
+
+## Running tests in `watch` mode<a name="watch-test"></a>


These <a name tags are unnecessary, GitHub automatically assigns an id to all headings so you can deep link to them! 😊

Thanks! I was wondering why do I have to add those ugly anchor tags.

gihrig · 2017-01-29T17:45:41Z

README.md

+
+Remove node_modules and build
+- `rm -rf node_modules`
+- `rm -rf build`


I don't think it's necessary manually remove build.

It does not affect deve mode.

It gets erased and rebuilt is prod mode

True... I would remove it out of habit. I know it's not necessary.

gihrig · 2017-01-29T17:47:13Z

README.md

+Using npm
+- `npm cache clean`
+- `npm install`
+


Probably a good idea to complete the process (after either yarn or npm) with npm run build. Then everything is up to date.

I've added that line. But why would you build after installing? If it's dll that we need, we can run npm run build:dll

Because the production build folder is not updated by install. If was built with bad deps and the prod server is started with start:prod that will still be a bad build. Just being cautious/complete.

Ah! Clever! 😄 👍

I'm thinking this should go in Gatchas (don't make it look like trouble is expected). It would be good to reference gotchas from README, perhaps under the title of "Troubleshooting".

gihrig · 2017-01-29T17:55:33Z

docs/general/gotchas.md

+## Load reducers optimistically<a name="optimistic-reducers"></a>
+
+If you have some `containers` that aren't _route specific_ and that should be available throughout the app, like a `NavigationBar`, you need to add their respective reducers to the root reducer with the help of `combineReducers`.
+


Restructure for clarity:

If you have containers that should be available throughout the app, like a NavigationBar (they aren't route specific), you need to add their respective reducers to the root reducer with the help of combineReducers.

Done 👍 ☺️

gihrig · 2017-01-29T17:57:34Z

docs/general/gotchas.md

+## Exclude modules from Babel processing<a name="exclude-modules"></a>
+
+Excluding modules from babel processing has never been so easy! Just add the package name to `exclude` array in `internals/config.js` and you're all set!
+


Would be good to briefly explain why one might need to exclude a module from Babel processing.

gihrig · 2017-01-29T18:02:04Z

docs/general/gotchas.md

+## Running tests in `watch` mode<a name="watch-test"></a>
+
+You may have to install `watchman` to run tests in watch mode. If you're using a Mac, simply run `brew install watchman`
+


Clarify that installing watchman is not an expected requirement:

If you are unable to run tests in watch mode, you may have to install watchman. If you're using...

gihrig · 2017-01-29T18:04:36Z

Have scrutinized 😁

Suggestions are included in comments added to the doc., see source.

mihir0x69 · 2017-01-30T15:03:02Z

@gihrig @mxstbr Thank you!! 👍 ✌️

gihrig · 2017-01-30T17:55:05Z

docs/general/gotchas.md


-You may have to install `watchman` to run tests in watch mode. If you're using a Mac, simply run `brew install watchman`
+If you are unable to run tests in watch mode, you may have to install `watchman` to run tests in watch mode. If you're using a Mac, simply run `brew install watchman`



If you are unable to run tests in watch mode, you may have to install watchman to run tests in watch mode.

Remove redundant clause:

If you are unable to run tests in watch mode, you may have to install watchman for this to work.

gihrig · 2017-01-30T18:01:51Z

@KarandikarMihir Looking good! One additional comment on watchman, see source.

Also, we have a 'circular dependency' with #1462 requiring a gatchas.md entry per this comment.

mihir0x69 · 2017-01-31T14:53:56Z

@gihrig Done! Anything else? 😅 Merging this would resolve that 'circular dependency', right?

gihrig · 2017-01-31T17:52:58Z

docs/general/gotchas.md

+## Exclude modules from Babel processing
+
+You need to exclude node packages from babel processing which are not intended for browsers. Just add the package name to `exclude` array in `internals/config.js` and you're all set!
+


not intended for browsers.

There's more to this. sanitize.css is certainly intended for browsers, why is it here?

It's in our config.js 🙇 It's there in exclude because babel doesn't process css, maybe?

Maybe we should change the wording and say something like-

You need to exclude node packages from babel processing which are not intended to be processed by babel. For eg. a CSS file.

That being said, why are chalk, cross-env, compression etc. included in dependencies? Shouldn't they be listed as devDependencies?

You need to exclude node packages from babel processing which are not intended to be processed by babel. For eg. a CSS file.

I would keep the not intended for browser part but add something about not to be processed by Babel. e.g.

You need to exclude packages which are not intended to be processed by babel. For e.g. Server packages such as 'express' or a CSS file.

gihrig · 2017-01-31T17:58:42Z

Also Watch mode 1 day ago...

And see README last comment

(I need to figure out this code review system, seem arbitrary as to when comments appear on the main age... :-/)

mihir0x69 · 2017-02-01T09:22:44Z

Also Watch mode 1 day ago...

WUT. Watch mode gotcha is already there. Am I missing something?

mihir0x69 · 2017-02-01T14:34:17Z

@gihrig I found it. Adding that.

gihrig · 2017-02-01T20:54:38Z

@KarandikarMihir If you agree with my last wording, I'll approve. I'll also dismiss @mxstbr's change requests as those have been handled.

mihir0x69 · 2017-02-02T04:25:34Z

@gihrig Alright!

gihrig · 2017-02-02T04:32:57Z

@KarandikarMihir And now we have #1493 😁

mihir0x69 · 2017-02-02T05:13:02Z

@gihrig I have the changes ready but GitHub has locked me out of my account because of that stupid two factor authentication 😅 I can't push this until I get my hands on the recovery codes. Sorry for the delay.

gihrig · 2017-02-02T05:17:23Z

GitHub has locked me out of my account because of that stupid two factor authentication 😅

That's why security is still a big fat FAIL in today's world, just too much PITA ☹️

No sweat, I'll be watching for your updates...

mihir0x69 · 2017-02-02T14:57:19Z

@gihrig IKR 😞 I fixed it.

Pushing changes now. Please review and then hopefully we'll merge this 😁

@mxstbr

Corrections made and verified. Haven't heard from @mxstbr for for a few days, but I'll give him a chance to check in before merging 😁

gihrig

Perfect! ✨

Thanks for hanging in through all the (grueling) changes! This is a BIG improvement! 🎉

mihir0x69 · 2017-02-03T04:37:59Z

Yaw! 😎

coveralls · 2017-02-06T08:37:10Z

Coverage remained the same at 99.24% when pulling ec5c157 on KarandikarMihir:update-docs into d898c43 on react-boilerplate:dev.

gihrig · 2017-02-11T17:51:43Z

I want to refer to this doc in a gitter chat - 9 days, no comments - merging...

* Docs Update: sass.md | New webpack version -loader suffix (#1484) * New webpack version -loader suffix New webpack version no longer allowed to omit the '-loader' suffix when using loaders. * Webpack 2 migration module.loaders => module.rules * Fix Loaders/Rules * chore(docs): fix link to redux-saga docs Fix a broken link to redux-saga docs. * feat(webpack): Support OpenType fonts with .otf file extension (#1471) * chore(docs): improve testing documentation * [doc] improve code snippet syntax in unit-testing doc linted code snippet and removed uneeded import * [doc] add overview of reducer test in unit testing doc add the completed reducer test file as overview in unit testing documentation * [doc] improve component testing doc linted code snippets, added complete test file as refernce and link to next doc page. * chore(setup): remove LGTM config files (#1317) * chore(setup): remove LGTM * Add collaborating guidelines * Add @KarandikarMihir * Remove .react.js extensions (#1469) * Remove .react.js extensions * Restore file names in the title comments * Remove hyphens * chore(deps): update deps roll-up Jan-21-2017 (#1501) * fix(tests): Replace sinon restore (#1512) * Remove sinon.restore() * Lock down sinon version * chore(all): move to an organisation on GitHub * Make webpack build less verbose (#1510) * removed route names from app/routes (#1509) * removed route names from app/routes * removed name prop from internals/templates/routes * removed name from internals/gens/route/route.hbs and routeWithReducer.hbs * fix(eslint): Enable rule react/no-array-index-key (#1521) * enable rule react/no-array-index-key * fix test of List component * fix(dependencies.js): clean up console clutter for install scripts (#1532) Ref #1506 * Fix typo i18n.md (#1541) * chore(deps): update deps roll-up Jan-28-2017 (#1531) * chore(deps): update deps roll-up Jan-28-2017 * Update package.json * Set history@3.2.1 * Using optimised version of the banner (#1560) Taken from #907 * test(build:clean script): remove test:clean from build:clean - fixes coveralls reporting? (#1563) * Update docs (README.md, Gotchas.md) (#1534) * Update README.md * Update gotchas.md * Add links to gotchas * Update docs * Remove redundant sentence * Move reinstall steps to gotchas.md * Update README.md * Minor corrections * Add jest cache clean to gotchas.md * Fix team of devs link (#1566) * chore(deps): update deps roll-up Feb-04-2017 (#1561) * Add iOS home screen icon (#1585) * fix manifest icons (#1568) * manifest(fix) (#1594) * Change dev source map style (#1559) * (fix) ProgressBar state error (#1553) * Bind listener to the current instance of component * Bring up coverage * Reassign listener with newly bound listener * Minor changes * Separated dev and prod middlewares (#1556) * Update FAQ with Styles getting overridden (#1592) * Improve <List> tests (#1134) * Fix imported styles (#1599) * Migrate webpack loaders * Add comment to CSS loader This should help clarify and reduce common problems * Split css rules into two * Updated docs * First draft of new styling docs * Fix Sass heading * Fix links and wording * Add LESS and other improvements * Post test fixes * Updated headings and added more info section * fix: Intl polyfill for language generator (#1611) * fix: Intl polyfill for language generator * fix: appveyor chrome issue by adding suggested --ignore-checksums * Fix broken link in documentation. Fixes #1638. (#1643) * refactor(react-router-scroll): Import only useScroll (#1609) * chore(package.json): sort ESLint config (#1660) This PR will sort the ESLint configuration alphabetically in `package.json`. * Fix iOS home screen icons (#1604) * Use absolute paths * AppVeyor install chrome ignoring checksums * Add Stateless Functions to Container Generator (#1494) * Add Stateless Functions to Container Generator * Fix linting test for generators * Tightened up generator type names - Also made component and container use similar order and language * Fix odd node5 issue * and disable eslint for the var * Fix missing reference (#1725) * Moving Contrib documentation to the right place (#1721) * refactor(react-router): Import only necessary components (#1608) Instead of importing the entire library, cherry-pick the components we use. This is [supported and encouraged](https://github.com/ReactTraining/react-router/blob/master/docs/guides/MinimizingBundleSize.md) by react-router. Reduced the size of the main bundle by 9 KB (709 KB -> 700 KB). * Fixing links for the contributing.md (#1738) * a grammatical item (#1740) * Remove state update in componentWillUpdate (#1769) * syntatical improvements to progress bar (#1633) * syntatical improvements to progress bar * declare propTypes and defaultProps on the class instead of using the static keyword * Improve the setup to recognize our own repo before clearing it. (#1720) * Add intelligence to the setup to recognize our own repo, before nuking it. (#760, #1719) * Cleaning up console messages upon setup * Adding a prompt for deciding whether to clear the repo or not. Fixed: #760, #1719 * Fixing the scenario where it was not exiting this file after not removing the repository * Doing minor changes suggested * Updating quickstart file location (#1712) * Request utils: handle 204 and 205 HTTP response (#1780) * feat(core): styled-components v2 update (#1775) * feat(core): styled-components v2 update * fix(deps): lock version for styled plugin * Fix: Use local instance of shelljs (#1782) * Use local instance of shelljs * Replace var with const * Switching deprecated babel-preset-latest to babel-preset-env (#1736) * adding babel-preset-env package * replacing deprecated babel-preset-latest with babel-preset-env to avoid the following npm installation warning: ``` npm WARN deprecated babel-preset-latest@6.24.0: preset-latest accomplishes the same task as babel-preset-env. Please install it with 'npm install babel-preset-env --save-dev'. '{ "presets": ["latest"] }' to '{ "presets": ["env"] }'. For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env ``` Ref. #1667 * removing deprecated babel-preset-latest package * Add missing word (#1789) * Migrating from React.PropTypes to PropTypes (#1787) * adding prop-types dependency * migrating from React.PropTypes to PropTypes * Adding some tests (#1784) * tests(FeaturePage): testing shouldComponentUpdate function * tests(HomePage): testing if username prop is missing * tests(ProgressBar): testing when route is not changing * tests: removing global-styles.js from coverage collect * tests(Toggle): adding tests for empty values prop * tests(store): adding missing tests * tests(ProgressBar): adding missing tests * chore(deps): update deps roll-up Jun-01-2017 (#1794) * chore(deps): update deps roll-up Jun-01-2017 * Add react-test-renderer as dev dependency * Remove `react-addons-test-utils` * Use new `react-helmet` API * Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.' Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.' * Revert line that wasn't meant to be commited * docs(maintenance): Create dependency update doc (#1790) * docs(maintenance): Create dependency update doc * Update dependency.md * Update dependency.md * Update dependency.md * Update dependency.md * Add link to #598 * Update the 'tagged template literals' link to point to its new home at styled-components.com (#1824) * feat(core): React Router v4, React-Loadable, asyncInjectors (#1746) * Migrate to react router v4. * Make sure Switch renders after redux state change by passing in redux location, propagate computedMatch to Route, and make not-found matcher non-exact. * Fix route generator. * Implicitly pass store into loader from AsyncRoute to simplify custom child route components. * Fix route prop propagation. * Regen yarn.lock * Keep track of route loading in redux state and read in progress bar. * Replace AsyncRoute with react-loadable * Add `DefaultLoadingComponentProvider` * Rename `loader.js` to `Loadable.js` * Revert 9f44f1b * small chores * Add tests * Update generators * Exclude component/Loadable from coverage * Update docs * Make App a class that extends React.Component to enable hot reloading * Add a link to RR4 API * Improve generators * Fix linting errors * Update react-loadable * Update yarn.lock * Propagate InnerLoadable props to the rendered component, for Route props like match. * Refactor * rename withMappedState -> withConnect * rename name to key * Use constants * Make 'daemon' a default mode for `injectReducer` * Simplify `ejectSaga` * Improve docs * clean up * recommend to use `ConnectedSwitch` * turn `App` into a function like it was before * Run CI * Import `memoryHistory` and `browserHistory` from `react-router-dom` instead of `react-router` * Remove path from a 'not found' route * Update deps * Simplify tests * Remove modes from `injectReducer` * Make second argument to be a descriptor in `sagaInjectors` * Change `constants` to have consistent values * Remove non-daemon saga descriptors in production in `ejectSaga` * Save an entire descriptor in the saga registry * Fix `constants` in templates * fix(hmr): Replace `preset-hmre` with vanilla webpack HMR (#1871) * Replace react-hmre with bare webpack hmr * Explicitly unmount the main component * Prevent recomputing reducers for `replaceReducer` * Add a link to Wepack HMR to the docs * Remove `overlay=true` * Accept an array of modules to hot reload * Add Debugging section in Docs + VS Code instructions (#1698) * Add debugging section in README * Move WebStorm FAQ to debugging section * Add VS Code to debugging section * Update VS Code launch config * Update VS Code config to work in dev branch * Add VS Code launch.json config * Update launch.json to be compatible with master * Update VS Code launch to be compatible with master * Remove .vscode launch config * Add notice on source map issue for VS Code. * move onSubmitForm test into mapDispatchToProps test (#1644) * Use camelcase for reducer and saga key to match selector. (#1888) * chore(deps): remove unusable deps sinon (#1882) * chore(deps): downgrade `sanitize.css` (#1872) * chore(templates): turn `App` into a functional component (#1892) Fixes #1884 * fix(generators): use correct selector names in tests and regular selectors should not be nested (#1873) * Rename store.js to configureStore.js to Prevent conflict with storeJS… (#1904) * Rename store.js to configureStore.js to Prevent conflict with storeJS npm package * Fix store -> configureStore * Bump webpack to 3.0.0 and update related deps (#1823) * Bump webpack to 3.0.0 and related deps * Add ModuleConcatenationPlugin to webpack base config * Check in mysterious change in yarn.lock * Install latest html-webpack-plugin and resolve incorrect peer dep issue * Update webpack to 3.5.4 * Bump webpack to 3.5.5 * Move ModuleConcatenationPlugin from base to prod config, add --display-optimization-bailout flag * Serve Dlls via add-asset-html-webpack-plugin (#1849) * Serve Dlls via add-asset-html-webpack-plugin * Remove duplicate dll script tags and cheerio dependency * Remove cheerio refs from docs * Minor whitespace change * Remove eslint exception in webpack.dll.babel.js * chore(deps): Upgrade React to v15.6 (#1832) * chore(deps): regenerate `yarn.lock` (#1931) * chore(deps): regenerate `yarn.lock` * Empty commit to restart netlify * chore(3.5): Update changelog.md

* Merge v3.5 release (#1929) * Docs Update: sass.md | New webpack version -loader suffix (#1484) * New webpack version -loader suffix New webpack version no longer allowed to omit the '-loader' suffix when using loaders. * Webpack 2 migration module.loaders => module.rules * Fix Loaders/Rules * chore(docs): fix link to redux-saga docs Fix a broken link to redux-saga docs. * feat(webpack): Support OpenType fonts with .otf file extension (#1471) * chore(docs): improve testing documentation * [doc] improve code snippet syntax in unit-testing doc linted code snippet and removed uneeded import * [doc] add overview of reducer test in unit testing doc add the completed reducer test file as overview in unit testing documentation * [doc] improve component testing doc linted code snippets, added complete test file as refernce and link to next doc page. * chore(setup): remove LGTM config files (#1317) * chore(setup): remove LGTM * Add collaborating guidelines * Add @KarandikarMihir * Remove .react.js extensions (#1469) * Remove .react.js extensions * Restore file names in the title comments * Remove hyphens * chore(deps): update deps roll-up Jan-21-2017 (#1501) * fix(tests): Replace sinon restore (#1512) * Remove sinon.restore() * Lock down sinon version * chore(all): move to an organisation on GitHub * Make webpack build less verbose (#1510) * removed route names from app/routes (#1509) * removed route names from app/routes * removed name prop from internals/templates/routes * removed name from internals/gens/route/route.hbs and routeWithReducer.hbs * fix(eslint): Enable rule react/no-array-index-key (#1521) * enable rule react/no-array-index-key * fix test of List component * fix(dependencies.js): clean up console clutter for install scripts (#1532) Ref #1506 * Fix typo i18n.md (#1541) * chore(deps): update deps roll-up Jan-28-2017 (#1531) * chore(deps): update deps roll-up Jan-28-2017 * Update package.json * Set history@3.2.1 * Using optimised version of the banner (#1560) Taken from #907 * test(build:clean script): remove test:clean from build:clean - fixes coveralls reporting? (#1563) * Update docs (README.md, Gotchas.md) (#1534) * Update README.md * Update gotchas.md * Add links to gotchas * Update docs * Remove redundant sentence * Move reinstall steps to gotchas.md * Update README.md * Minor corrections * Add jest cache clean to gotchas.md * Fix team of devs link (#1566) * chore(deps): update deps roll-up Feb-04-2017 (#1561) * Add iOS home screen icon (#1585) * fix manifest icons (#1568) * manifest(fix) (#1594) * Change dev source map style (#1559) * (fix) ProgressBar state error (#1553) * Bind listener to the current instance of component * Bring up coverage * Reassign listener with newly bound listener * Minor changes * Separated dev and prod middlewares (#1556) * Update FAQ with Styles getting overridden (#1592) * Improve <List> tests (#1134) * Fix imported styles (#1599) * Migrate webpack loaders * Add comment to CSS loader This should help clarify and reduce common problems * Split css rules into two * Updated docs * First draft of new styling docs * Fix Sass heading * Fix links and wording * Add LESS and other improvements * Post test fixes * Updated headings and added more info section * fix: Intl polyfill for language generator (#1611) * fix: Intl polyfill for language generator * fix: appveyor chrome issue by adding suggested --ignore-checksums * Fix broken link in documentation. Fixes #1638. (#1643) * refactor(react-router-scroll): Import only useScroll (#1609) * chore(package.json): sort ESLint config (#1660) This PR will sort the ESLint configuration alphabetically in `package.json`. * Fix iOS home screen icons (#1604) * Use absolute paths * AppVeyor install chrome ignoring checksums * Add Stateless Functions to Container Generator (#1494) * Add Stateless Functions to Container Generator * Fix linting test for generators * Tightened up generator type names - Also made component and container use similar order and language * Fix odd node5 issue * and disable eslint for the var * Fix missing reference (#1725) * Moving Contrib documentation to the right place (#1721) * refactor(react-router): Import only necessary components (#1608) Instead of importing the entire library, cherry-pick the components we use. This is [supported and encouraged](https://github.com/ReactTraining/react-router/blob/master/docs/guides/MinimizingBundleSize.md) by react-router. Reduced the size of the main bundle by 9 KB (709 KB -> 700 KB). * Fixing links for the contributing.md (#1738) * a grammatical item (#1740) * Remove state update in componentWillUpdate (#1769) * syntatical improvements to progress bar (#1633) * syntatical improvements to progress bar * declare propTypes and defaultProps on the class instead of using the static keyword * Improve the setup to recognize our own repo before clearing it. (#1720) * Add intelligence to the setup to recognize our own repo, before nuking it. (#760, #1719) * Cleaning up console messages upon setup * Adding a prompt for deciding whether to clear the repo or not. Fixed: #760, #1719 * Fixing the scenario where it was not exiting this file after not removing the repository * Doing minor changes suggested * Updating quickstart file location (#1712) * Request utils: handle 204 and 205 HTTP response (#1780) * feat(core): styled-components v2 update (#1775) * feat(core): styled-components v2 update * fix(deps): lock version for styled plugin * Fix: Use local instance of shelljs (#1782) * Use local instance of shelljs * Replace var with const * Switching deprecated babel-preset-latest to babel-preset-env (#1736) * adding babel-preset-env package * replacing deprecated babel-preset-latest with babel-preset-env to avoid the following npm installation warning: ``` npm WARN deprecated babel-preset-latest@6.24.0: preset-latest accomplishes the same task as babel-preset-env. Please install it with 'npm install babel-preset-env --save-dev'. '{ "presets": ["latest"] }' to '{ "presets": ["env"] }'. For more info, please check the docs: http://babeljs.io/docs/plugins/preset-env ``` Ref. #1667 * removing deprecated babel-preset-latest package * Add missing word (#1789) * Migrating from React.PropTypes to PropTypes (#1787) * adding prop-types dependency * migrating from React.PropTypes to PropTypes * Adding some tests (#1784) * tests(FeaturePage): testing shouldComponentUpdate function * tests(HomePage): testing if username prop is missing * tests(ProgressBar): testing when route is not changing * tests: removing global-styles.js from coverage collect * tests(Toggle): adding tests for empty values prop * tests(store): adding missing tests * tests(ProgressBar): adding missing tests * chore(deps): update deps roll-up Jun-01-2017 (#1794) * chore(deps): update deps roll-up Jun-01-2017 * Add react-test-renderer as dev dependency * Remove `react-addons-test-utils` * Use new `react-helmet` API * Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.' Get rid of the warning: 'DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see webpack/loader-utils#56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.' * Revert line that wasn't meant to be commited * docs(maintenance): Create dependency update doc (#1790) * docs(maintenance): Create dependency update doc * Update dependency.md * Update dependency.md * Update dependency.md * Update dependency.md * Add link to #598 * Update the 'tagged template literals' link to point to its new home at styled-components.com (#1824) * feat(core): React Router v4, React-Loadable, asyncInjectors (#1746) * Migrate to react router v4. * Make sure Switch renders after redux state change by passing in redux location, propagate computedMatch to Route, and make not-found matcher non-exact. * Fix route generator. * Implicitly pass store into loader from AsyncRoute to simplify custom child route components. * Fix route prop propagation. * Regen yarn.lock * Keep track of route loading in redux state and read in progress bar. * Replace AsyncRoute with react-loadable * Add `DefaultLoadingComponentProvider` * Rename `loader.js` to `Loadable.js` * Revert 9f44f1b * small chores * Add tests * Update generators * Exclude component/Loadable from coverage * Update docs * Make App a class that extends React.Component to enable hot reloading * Add a link to RR4 API * Improve generators * Fix linting errors * Update react-loadable * Update yarn.lock * Propagate InnerLoadable props to the rendered component, for Route props like match. * Refactor * rename withMappedState -> withConnect * rename name to key * Use constants * Make 'daemon' a default mode for `injectReducer` * Simplify `ejectSaga` * Improve docs * clean up * recommend to use `ConnectedSwitch` * turn `App` into a function like it was before * Run CI * Import `memoryHistory` and `browserHistory` from `react-router-dom` instead of `react-router` * Remove path from a 'not found' route * Update deps * Simplify tests * Remove modes from `injectReducer` * Make second argument to be a descriptor in `sagaInjectors` * Change `constants` to have consistent values * Remove non-daemon saga descriptors in production in `ejectSaga` * Save an entire descriptor in the saga registry * Fix `constants` in templates * fix(hmr): Replace `preset-hmre` with vanilla webpack HMR (#1871) * Replace react-hmre with bare webpack hmr * Explicitly unmount the main component * Prevent recomputing reducers for `replaceReducer` * Add a link to Wepack HMR to the docs * Remove `overlay=true` * Accept an array of modules to hot reload * Add Debugging section in Docs + VS Code instructions (#1698) * Add debugging section in README * Move WebStorm FAQ to debugging section * Add VS Code to debugging section * Update VS Code launch config * Update VS Code config to work in dev branch * Add VS Code launch.json config * Update launch.json to be compatible with master * Update VS Code launch to be compatible with master * Remove .vscode launch config * Add notice on source map issue for VS Code. * move onSubmitForm test into mapDispatchToProps test (#1644) * Use camelcase for reducer and saga key to match selector. (#1888) * chore(deps): remove unusable deps sinon (#1882) * chore(deps): downgrade `sanitize.css` (#1872) * chore(templates): turn `App` into a functional component (#1892) Fixes #1884 * fix(generators): use correct selector names in tests and regular selectors should not be nested (#1873) * Rename store.js to configureStore.js to Prevent conflict with storeJS… (#1904) * Rename store.js to configureStore.js to Prevent conflict with storeJS npm package * Fix store -> configureStore * Bump webpack to 3.0.0 and update related deps (#1823) * Bump webpack to 3.0.0 and related deps * Add ModuleConcatenationPlugin to webpack base config * Check in mysterious change in yarn.lock * Install latest html-webpack-plugin and resolve incorrect peer dep issue * Update webpack to 3.5.4 * Bump webpack to 3.5.5 * Move ModuleConcatenationPlugin from base to prod config, add --display-optimization-bailout flag * Serve Dlls via add-asset-html-webpack-plugin (#1849) * Serve Dlls via add-asset-html-webpack-plugin * Remove duplicate dll script tags and cheerio dependency * Remove cheerio refs from docs * Minor whitespace change * Remove eslint exception in webpack.dll.babel.js * chore(deps): Upgrade React to v15.6 (#1832) * chore(deps): regenerate `yarn.lock` (#1931) * chore(deps): regenerate `yarn.lock` * Empty commit to restart netlify * chore(3.5): Update changelog.md * chore(deps): Bump version to 3.5.0 * fix(internals): Update RBP version string in internal config (#2002) closes #2001 * Correct babel plugin order here is related issue comment: babel/babel#5325 (comment) * fix incorrect merge

lock · 2018-05-29T05:20:08Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Update README.md

e825f59

mihir0x69 changed the title ~~Update docs~~ Update docs (README.md, Gotchas.md) Jan 29, 2017

mihir0x69 added 2 commits January 29, 2017 18:14

Update gotchas.md

95798d4

Add links to gotchas

960120c

mxstbr previously requested changes Jan 29, 2017

View reviewed changes

gihrig reviewed Jan 29, 2017

View reviewed changes

Update docs

d597bdb

gihrig reviewed Jan 30, 2017

View reviewed changes

gihrig mentioned this pull request Jan 30, 2017

feat(internals): Improve generator warnings (#1462) #1523

Closed

Remove redundant sentence

b6697bd

Merge branch 'dev' into update-docs

5076f99

gihrig reviewed Jan 31, 2017

View reviewed changes

mihir0x69 and others added 3 commits February 1, 2017 20:36

Move reinstall steps to gotchas.md

0b47327

Update README.md

23dbd00

Minor corrections

4638f57

mihir0x69 mentioned this pull request Feb 2, 2017

Istanbul report bad info #1493

Closed

Add jest cache clean to gotchas.md

de0d3c2

gihrig approved these changes Feb 2, 2017

View reviewed changes

Merge branch 'dev' into update-docs

ec5c157

gihrig merged commit bed2126 into react-boilerplate:dev Feb 11, 2017

lock bot locked as resolved and limited conversation to collaborators May 29, 2018

		@@ -97,6 +97,8 @@ There’s also a <a href="https://vimeo.com/168648012">fantastic video</a> on ho

		## Quick start

		We strongly recommend that you use yarn over npm because yarn installs dependencies in a stable and predictable way. As a bonus, you'll get faster installation and cleaner console!

		## Load reducers optimistically<a name="optimistic-reducers"></a>

		If you have some `containers` that aren't _route specific_ and that should be available throughout the app, like a `NavigationBar`, you need to add their respective reducers to the root reducer with the help of `combineReducers`.

		## Exclude modules from Babel processing<a name="exclude-modules"></a>

		Excluding modules from babel processing has never been so easy! Just add the package name to `exclude` array in `internals/config.js` and you're all set!

		## Running tests in `watch` mode<a name="watch-test"></a>

		You may have to install `watchman` to run tests in watch mode. If you're using a Mac, simply run `brew install watchman`

Update docs (README.md, Gotchas.md) #1534

Update docs (README.md, Gotchas.md) #1534

Conversation

mihir0x69 commented Jan 29, 2017 • edited Loading

mxstbr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gihrig Jan 31, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gihrig commented Jan 29, 2017

mihir0x69 commented Jan 30, 2017

gihrig Jan 30, 2017 • edited Loading

Choose a reason for hiding this comment

gihrig commented Jan 30, 2017

mihir0x69 commented Jan 31, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gihrig commented Jan 31, 2017 • edited Loading

mihir0x69 commented Feb 1, 2017

mihir0x69 commented Feb 1, 2017

gihrig commented Feb 1, 2017

mihir0x69 commented Feb 2, 2017

gihrig commented Feb 2, 2017

mihir0x69 commented Feb 2, 2017

gihrig commented Feb 2, 2017

mihir0x69 commented Feb 2, 2017

gihrig left a comment

Choose a reason for hiding this comment

mihir0x69 commented Feb 3, 2017

coveralls commented Feb 6, 2017 • edited Loading

gihrig commented Feb 11, 2017

lock bot commented May 29, 2018

mihir0x69 commented Jan 29, 2017 •

edited

Loading

gihrig Jan 31, 2017 •

edited

Loading

gihrig Jan 30, 2017 •

edited

Loading

gihrig commented Jan 31, 2017 •

edited

Loading

coveralls commented Feb 6, 2017 •

edited

Loading