Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container template doesn't normalize name in mapStateToProps #2353

Closed
2manyvcos opened this issue Sep 28, 2018 · 9 comments
Closed

Container template doesn't normalize name in mapStateToProps #2353

2manyvcos opened this issue Sep 28, 2018 · 9 comments

Comments

@2manyvcos
Copy link
Contributor

{{name}}: makeSelect{{properCase name}}(),

I think this should be:

- {{name}}: makeSelect{{properCase name}}(), 
+ {{camelCase name}}: makeSelect{{properCase name}}(),

This is the only case where name is not normalized.

@gretzky
Copy link
Member

gretzky commented Sep 28, 2018

Good catch, feel free to open a PR!

@heyrict
Copy link

heyrict commented Sep 30, 2018

I just come up here confused about why components don't update upon redux state change. Good 👍

@2manyvcos
Copy link
Contributor Author

2manyvcos commented Sep 30, 2018

@gretzky #offtopic
I previously submitted PR #1799 (added in milestone v3.6) but it seems that it got lost. Would there be any chance that it could be added again?

@gretzky
Copy link
Member

gretzky commented Oct 1, 2018

Hi @hatsuo, feel free to open a separate issue on this so I can investigate what happened

@2manyvcos
Copy link
Contributor Author

Hello @gretzky.
Thanks, the new issue is at #2361.

@julienben
Copy link
Member

Closing as this has been fixed in #2367

@2manyvcos
Copy link
Contributor Author

Hello @julienben,

the PR you mentioned was related to #2361.
The PR for this issue is #2357 and is still open.

Would you please reopen the issue?

Thanks.

@julienben
Copy link
Member

My bad. Will merge #2357 instead.

@lock
Copy link

lock bot commented Nov 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants