Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix container template not normalizing name #2357

Merged
merged 3 commits into from
Oct 9, 2018
Merged

Fix container template not normalizing name #2357

merged 3 commits into from
Oct 9, 2018

Conversation

2manyvcos
Copy link
Contributor

Resolves #2353

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6e76abf on hatsuo:dev into 9610bdc on react-boilerplate:dev.

@coveralls
Copy link

coveralls commented Sep 30, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 3549f84 on hatsuo:dev into 114b57d on react-boilerplate:dev.

@2manyvcos 2manyvcos mentioned this pull request Oct 8, 2018
Closed
julienben
julienben approved these changes Oct 8, 2018
View reviewed changes
Copy link
Member

@julienben julienben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @hatsuo!

@julienben julienben merged commit 1b77c9c into react-boilerplate:dev Oct 9, 2018
@2manyvcos 2manyvcos deleted the dev branch October 9, 2018 07:12
gretzky pushed a commit that referenced this pull request Oct 24, 2018
@2manyvcos @gretzky
Fix container template not normalizing name (#2357)
312426d 
Resolves #2353
@lock
Copy link

lock bot commented Nov 8, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@julienben julienben julienben approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@2manyvcos @coveralls @julienben