Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature/add redux toolkit #2807
Thank you for contributing! Please take a moment to review our contributing guidelines
Please open an issue before embarking on any significant pull request, especially those that
Before opening a pull request, please ensure:
Be kind to code reviewers, please try to keep pull requests as small and focused as possible :)
IMPORTANT: By submitting a patch, you agree to allow the project
This PR demonstrates how to convert part of the built-in example application to use Redux Toolkit, as described in #2806 .
It is not meant to be complete and merged as-is, but rather to serve as a starting point for conversion if the maintainers choose.
I have some other changes I'd like to suggest as well, which I'll write up in the issue rather than here.
julienben left a comment •
This looks great!
As you mention, it's a WIP and requires more work before being ready but unless somebody would like to argue against this switch I think we can safely proceed with the additional changes required for it.
@markerikson Would you like to continue this work or would you like local contributors to take it on?
Quick list of things which still need to be done:
I'd like to turn the PR over to you folks at this point. You know the
Happy to answer any questions about using RTK as you work through this, though!
It's likely that you can remove Immer as a direct dependency once the other reducers have been converted. Reselect might not be removable, given that there are uses of
hi @markerikson thank you for this PR!
i don't think it's a huge deal to keep reselect dependency, but would you consider adding
We do re-export everything from Redux already.
I'd like to avoid explicitly re-exporting