Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REDUX TOOLKIT] Update generators #2811

Merged
merged 3 commits into from
Nov 21, 2019

Conversation

julienben
Copy link
Member

React Boilerplate

Continuing the work done in #2807 and #2808. The base branch is redux-toolkit-switch where we're aggregating all the work for the switch. This PR contains the generator updates.

@coveralls
Copy link

coveralls commented Nov 21, 2019

Coverage Status

Coverage remained the same at 99.552% when pulling ddec5d5 on rtk-generators-update into 3618574 on redux-toolkit-switch.

@julienben julienben changed the title Update generators for switch to Redux Toolkit [REDUX TOOLKIT] Update generators Nov 21, 2019
Copy link
Collaborator

@BenLorantfy BenLorantfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

expect(reducer(undefined, {})).toEqual(expectedResult);
});

/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor thing but I don't think you can uncomment multi-line comments with CMD + /

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@julienben julienben merged commit 4d6fd9a into redux-toolkit-switch Nov 21, 2019
@julienben julienben deleted the rtk-generators-update branch November 21, 2019 15:05
@lock
Copy link

lock bot commented Dec 21, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants