Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(site): git url in GettingStarted component #16

Merged
merged 2 commits into from
Jan 26, 2017
Merged

fix(site): git url in GettingStarted component #16

merged 2 commits into from
Jan 26, 2017

Conversation

Dalanir
Copy link
Contributor

@Dalanir Dalanir commented Jan 25, 2017 •
edited
Loading

Just fix the mini typo on the website in git url to clone

I hope to contribute more in the future ! :)

Edit : #17

@mihir0x69
Copy link
Member

mihir0x69 commented Jan 25, 2017 •
edited
Loading

Thanks so much @Dalanir! :) ✨ Would you mind creating an issue and linking it here, please?

gihrig
gihrig previously requested changes Jan 25, 2017
View reviewed changes
Copy link

@gihrig gihrig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dalanir Good catch on that one, but this fix belongs on the react-boilerplate/site repo...

I guess it is. Sorry confused by

react-boilerplate:master

Missed:

react-boilerplate/site

@gihrig gihrig dismissed their stale review January 25, 2017 19:25

Change request was in error (I think...)

@gihrig
Copy link

gihrig commented Jan 25, 2017

@Dalanir Even though it's not part of your change, This single quote needs to be changed to an html entity:

image

e.g. change
haven't" to
haven't.

@gihrig gihrig changed the title fix git url in GettingStarted component fix(site): git url in GettingStarted component Jan 25, 2017
@Dalanir
Copy link
Contributor Author

Dalanir commented Jan 26, 2017

Thanks for your time, i'll push the fix for single quote too in the same branch if you don't mind

mihir0x69
mihir0x69 approved these changes Jan 26, 2017
View reviewed changes
Copy link
Member

@mihir0x69 mihir0x69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mxstbr
mxstbr approved these changes Jan 26, 2017
View reviewed changes
Copy link
Member

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@mxstbr mxstbr merged commit 974c340 into react-boilerplate:master Jan 26, 2017
@mxstbr mxstbr mentioned this pull request Jan 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxstbr mxstbr mxstbr approved these changes

@mihir0x69 mihir0x69 mihir0x69 approved these changes

@gihrig gihrig gihrig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dalanir @mihir0x69 @gihrig @mxstbr