Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various text and code fixes #1418

Merged
merged 1 commit into from
Jul 19, 2020
Merged

Various text and code fixes #1418

merged 1 commit into from
Jul 19, 2020

Conversation

FrancescoGd
Copy link

Fixed some typos, reworded some phrases and corrected a couple lines in example code

Fixed some typos, reworded some phrases and corrected a couple lines in example code
@AllenFang AllenFang changed the base branch from master to develop July 12, 2020 06:40
@AllenFang
Copy link
Member

@FrancescoGd hi, I change your base to develop but please rebase your branch, thanks!

@FrancescoGd
Copy link
Author

FrancescoGd commented Jul 13, 2020

Yes, sorry, I thought that would be applicable just to code contributions and not to documentaion too... not a problem :)

Regards,
F.

@AllenFang AllenFang merged commit e96916b into react-bootstrap-table:develop Jul 19, 2020
@AllenFang
Copy link
Member

thanks your contribution @FrancescoGd

@FrancescoGd
Copy link
Author

FrancescoGd commented Jul 22, 2020

Thank you @AllenFang for accepting it even though I messed with branching :D

@FrancescoGd FrancescoGd deleted the editor-doc-fixes branch July 22, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants