Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont show empty indication #275

Merged
merged 1 commit into from
Apr 1, 2018
Merged

Dont show empty indication #275

merged 1 commit into from
Apr 1, 2018

Conversation

patrickomeara
Copy link
Contributor

No description provided.

@patrickomeara
empty noDataIndication when empty
6e27ba0 
* don't display unneeded empty row when noDataIndication isn't set
@patrickomeara patrickomeara mentioned this pull request Mar 25, 2018
Closed
@AllenFang AllenFang self-requested a review April 1, 2018 05:31
@AllenFang AllenFang added this to To do in 20180331-sprint via automation Apr 1, 2018
AllenFang
AllenFang approved these changes Apr 1, 2018
View reviewed changes
Copy link
Member

@AllenFang AllenFang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AllenFang AllenFang merged commit 41dc3ef into react-bootstrap-table:develop Apr 1, 2018
20180331-sprint automation moved this from To do to Done Apr 1, 2018
@AllenFang
Copy link
Member

AllenFang commented Apr 1, 2018 •
edited

@patrickomeara Fixed on react-bootstrap-table-next@0.1.6, check release note.

let me know if you still have any issues, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllenFang AllenFang AllenFang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
20180331-sprint
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrickomeara @AllenFang