-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(NavbarOffcanvas): fix rendering of nav items when expand is used
- Loading branch information
Showing
5 changed files
with
133 additions
and
42 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,38 +1,49 @@ | ||
<Navbar bg="light" expand={false}> | ||
<Container fluid> | ||
<Navbar.Brand href="#">Navbar Offcanvas</Navbar.Brand> | ||
<Navbar.Toggle aria-controls="offcanvasNavbar" /> | ||
<Navbar.Offcanvas | ||
id="offcanvasNavbar" | ||
aria-labelledby="offcanvasNavbarLabel" | ||
placement="end" | ||
> | ||
<Offcanvas.Header closeButton> | ||
<Offcanvas.Title id="offcanvasNavbarLabel">Offcanvas</Offcanvas.Title> | ||
</Offcanvas.Header> | ||
<Offcanvas.Body> | ||
<Nav className="justify-content-end flex-grow-1 pe-3"> | ||
<Nav.Link href="#action1">Home</Nav.Link> | ||
<Nav.Link href="#action2">Link</Nav.Link> | ||
<NavDropdown title="Dropdown" id="offcanvasNavbarDropdown"> | ||
<NavDropdown.Item href="#action3">Action</NavDropdown.Item> | ||
<NavDropdown.Item href="#action4">Another action</NavDropdown.Item> | ||
<NavDropdown.Divider /> | ||
<NavDropdown.Item href="#action5"> | ||
Something else here | ||
</NavDropdown.Item> | ||
</NavDropdown> | ||
</Nav> | ||
<Form className="d-flex"> | ||
<FormControl | ||
type="search" | ||
placeholder="Search" | ||
className="me-2" | ||
aria-label="Search" | ||
/> | ||
<Button variant="outline-success">Search</Button> | ||
</Form> | ||
</Offcanvas.Body> | ||
</Navbar.Offcanvas> | ||
</Container> | ||
</Navbar>; | ||
<> | ||
{[false, 'sm', 'md', 'lg', 'xl', 'xxl'].map((expand) => ( | ||
<Navbar key={expand} bg="light" expand={expand} className="mb-3"> | ||
<Container fluid> | ||
<Navbar.Brand href="#">Navbar Offcanvas</Navbar.Brand> | ||
<Navbar.Toggle aria-controls={`offcanvasNavbar-expand-${expand}`} /> | ||
<Navbar.Offcanvas | ||
id={`offcanvasNavbar-expand-${expand}`} | ||
aria-labelledby={`offcanvasNavbarLabel-expand-${expand}`} | ||
placement="end" | ||
> | ||
<Offcanvas.Header closeButton> | ||
<Offcanvas.Title id={`offcanvasNavbarLabel-expand-${expand}`}> | ||
Offcanvas | ||
</Offcanvas.Title> | ||
</Offcanvas.Header> | ||
<Offcanvas.Body> | ||
<Nav className="justify-content-end flex-grow-1 pe-3"> | ||
<Nav.Link href="#action1">Home</Nav.Link> | ||
<Nav.Link href="#action2">Link</Nav.Link> | ||
<NavDropdown | ||
title="Dropdown" | ||
id={`offcanvasNavbarDropdown-expand-${expand}`} | ||
> | ||
<NavDropdown.Item href="#action3">Action</NavDropdown.Item> | ||
<NavDropdown.Item href="#action4"> | ||
Another action | ||
</NavDropdown.Item> | ||
<NavDropdown.Divider /> | ||
<NavDropdown.Item href="#action5"> | ||
Something else here | ||
</NavDropdown.Item> | ||
</NavDropdown> | ||
</Nav> | ||
<Form className="d-flex"> | ||
<FormControl | ||
type="search" | ||
placeholder="Search" | ||
className="me-2" | ||
aria-label="Search" | ||
/> | ||
<Button variant="outline-success">Search</Button> | ||
</Form> | ||
</Offcanvas.Body> | ||
</Navbar.Offcanvas> | ||
</Container> | ||
</Navbar> | ||
))} | ||
</>; |