Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.11.1 npm common.js doesn't work #218

Closed
bovard opened this issue Sep 5, 2014 · 2 comments
Closed

v0.11.1 npm common.js doesn't work #218

bovard opened this issue Sep 5, 2014 · 2 comments

Comments

@bovard
Copy link

bovard commented Sep 5, 2014

v0.11.0 works swell

LS2-00133:test bovardtiberi$ npm install react-bootstrap@0.11.0
npm WARN package.json react-bootstrap@0.11.1 No repository field.
npm http GET https://registry.npmjs.org/react-bootstrap/0.11.0
npm http 304 https://registry.npmjs.org/react-bootstrap/0.11.0
npm http GET https://registry.npmjs.org/react
npm http 304 https://registry.npmjs.org/react
npm http GET https://registry.npmjs.org/envify
npm http 304 https://registry.npmjs.org/envify
npm http GET https://registry.npmjs.org/esprima-fb
npm http GET https://registry.npmjs.org/xtend
npm http GET https://registry.npmjs.org/through
npm http GET https://registry.npmjs.org/jstransform
npm http 304 https://registry.npmjs.org/through
npm http 304 https://registry.npmjs.org/esprima-fb
npm http 304 https://registry.npmjs.org/xtend
npm http 304 https://registry.npmjs.org/jstransform
npm http GET https://registry.npmjs.org/object-keys
npm http GET https://registry.npmjs.org/base62/0.1.1
npm http GET https://registry.npmjs.org/source-map/0.1.31
npm http 304 https://registry.npmjs.org/source-map/0.1.31
npm http 304 https://registry.npmjs.org/object-keys
npm http 304 https://registry.npmjs.org/base62/0.1.1
npm http GET https://registry.npmjs.org/amdefine
npm http 304 https://registry.npmjs.org/amdefine
react@0.11.1 node_modules/react
└── envify@2.0.1 (through@2.3.4, esprima-fb@3001.1.0-dev-harmony-fb, xtend@2.1.2, jstransform@3.0.0)

react-bootstrap@0.11.0 node_modules/react-bootstrap
LS2-00133:test bovardtiberi$ node
> var Nav = require('react-bootstrap').Nav;
undefined
>
(^C again to quit)
>

v 0.11.1 does not work :(

LS2-00133:test bovardtiberi$ rm -rf node_modules/
LS2-00133:test bovardtiberi$ npm install react-bootstrap@0.11.1
npm WARN package.json react-bootstrap@0.11.1 No repository field.
npm http GET https://registry.npmjs.org/react-bootstrap/0.11.1
npm http 304 https://registry.npmjs.org/react-bootstrap/0.11.1
npm http GET https://registry.npmjs.org/react
npm http 304 https://registry.npmjs.org/react
npm http GET https://registry.npmjs.org/envify
npm http 304 https://registry.npmjs.org/envify
npm http GET https://registry.npmjs.org/esprima-fb
npm http GET https://registry.npmjs.org/jstransform
npm http GET https://registry.npmjs.org/xtend
npm http GET https://registry.npmjs.org/through
npm http 304 https://registry.npmjs.org/through
npm http 304 https://registry.npmjs.org/xtend
npm http 304 https://registry.npmjs.org/jstransform
npm http 304 https://registry.npmjs.org/esprima-fb
npm http GET https://registry.npmjs.org/object-keys
npm http GET https://registry.npmjs.org/base62/0.1.1
npm http GET https://registry.npmjs.org/source-map/0.1.31
npm http 304 https://registry.npmjs.org/object-keys
npm http 304 https://registry.npmjs.org/base62/0.1.1
npm http 304 https://registry.npmjs.org/source-map/0.1.31
npm http GET https://registry.npmjs.org/amdefine
npm http 304 https://registry.npmjs.org/amdefine
react@0.11.1 node_modules/react
└── envify@2.0.1 (through@2.3.4, esprima-fb@3001.1.0-dev-harmony-fb, xtend@2.1.2, jstransform@3.0.0)

react-bootstrap@0.11.1 node_modules/react-bootstrap
LS2-00133:test bovardtiberi$ node
> var Nav = require('react-bootstrap').Nav;
Error: Cannot find module 'react-bootstrap'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at repl:1:11
    at REPLServer.self.eval (repl.js:110:21)
    at repl.js:249:20
    at REPLServer.self.eval (repl.js:122:7)
    at Interface.<anonymous> (repl.js:239:12)
    at Interface.EventEmitter.emit (events.js:95:17)
>
@bovard bovard mentioned this issue Sep 5, 2014
Closed
@bovard
Copy link
Author

bovard commented Sep 5, 2014

Pulling in the latest from the react-bootstrap-npm in package.json is a workaround for this for those looking to get the newest features:
"react-bootstrap": "git://github.com/pieterv/react-bootstrap-npm",

@stevoland
Copy link
Contributor

Hi, have just released 0.12.0. Hopefully this sorts the problem.

@mtscout6 mtscout6 mentioned this issue Jan 2, 2015
Closed
mtscout6 added a commit to mtscout6/react-bootstrap that referenced this issue Jan 2, 2015
@mtscout6
Add pre-publish script call, rename cjs/ -> lib/
48e79cb 
Addresses concerns like react-bootstrap#325, react-bootstrap#218, and any others like them that I have
missed. In particular this is the fix for an automated setup as
mentioned in react-bootstrap#292.
@mtscout6 mtscout6 mentioned this issue Jan 2, 2015
Merged
mtscout6 added a commit to mtscout6/react-bootstrap that referenced this issue Jan 2, 2015
@mtscout6
Add pre-publish script call, rename cjs/ -> lib/
a306f50 
Addresses concerns like react-bootstrap#325, react-bootstrap#218, and any others like them that I have
missed. In particular this is the fix for an automated setup as
mentioned in react-bootstrap#292.
mtscout6 added a commit that referenced this issue Jan 23, 2015
@mtscout6
Add pre-publish script call, rename cjs/ -> lib/
77ee480 
Addresses concerns like #325, #218, and any others like them that I have
missed. In particular this is the fix for an automated setup as
mentioned in #292.
mtscout6 added a commit to mtscout6/react-bootstrap that referenced this issue Feb 13, 2015
@mtscout6
Add pre-publish script call, rename cjs/ -> lib/
c7544b7 
Addresses concerns like react-bootstrap#325, react-bootstrap#218, and any others like them that I have
missed. In particular this is the fix for an automated setup as
mentioned in react-bootstrap#292.
mtscout6 added a commit to mtscout6/react-bootstrap that referenced this issue Feb 15, 2015
@mtscout6
[changed] Move built components to lib directory
907b7b2 
In the past this library has suffered from accidentally pushing this
repo directly to npm without the built components. There has been a
separate repo to which the built source has been pushed and later
deployed from. While the approach is feasible it prevents you from using
the `npm link` feature, for easy testing of changes in your own
application.  This should address concerns like react-bootstrap#325, react-bootstrap#218, and any
others like them that I have missed. In particular this is the fix for
an automated setup as mentioned in react-bootstrap#292.

If you are currently using components directly from this library, then
you will need to change your reference path. For example
`require('react-bootstrap/Alert')` should now be `require('react-bootstrap/lib/Alert')`.
`require('react-bootstrap').Alert` will still work. This applies to both
CommonJS and AMD usages.
mtscout6 added a commit to mtscout6/react-bootstrap that referenced this issue Feb 16, 2015
@mtscout6
[changed] Move built components to lib directory
0193046 
In the past this library has suffered from accidentally pushing this
repo directly to npm without the built components. There has been a
separate repo to which the built source has been pushed and later
deployed from. While the approach is feasible it prevents you from using
the `npm link` feature, for easy testing of changes in your own
application.  This should address concerns like react-bootstrap#325, react-bootstrap#218, and any
others like them that I have missed. In particular this is the fix for
an automated setup as mentioned in react-bootstrap#292.

If you are currently using components directly from this library, then
you will need to change your reference path. For example
`require('react-bootstrap/Alert')` should now be `require('react-bootstrap/lib/Alert')`.
`require('react-bootstrap').Alert` will still work. This applies to both
CommonJS and AMD usages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevoland @bovard