Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm release v0.13.0 is raw source code #325

Closed
dashed opened this issue Jan 2, 2015 · 2 comments
Closed

npm release v0.13.0 is raw source code #325

dashed opened this issue Jan 2, 2015 · 2 comments

Comments

@dashed
Copy link

dashed commented Jan 2, 2015

npm release v0.13.0 is raw source code. Thus, I can't require('react-bootstrap').

At the moment only v0.12 is viable.
@mtscout6
Copy link
Member

mtscout6 commented Jan 2, 2015

👍

This could be cleaned up and automated with a pre-publish script as I proposed in #292.

@mtscout6 mtscout6 mentioned this issue Jan 2, 2015
Closed
mtscout6 added a commit to mtscout6/react-bootstrap that referenced this issue Jan 2, 2015
@mtscout6
Add pre-publish script call, rename cjs/ -> lib/
48e79cb 
Addresses concerns like react-bootstrap#325, react-bootstrap#218, and any others like them that I have
missed. In particular this is the fix for an automated setup as
mentioned in react-bootstrap#292.
@mtscout6 mtscout6 mentioned this issue Jan 2, 2015
Merged
mtscout6 added a commit to mtscout6/react-bootstrap that referenced this issue Jan 2, 2015
@mtscout6
Add pre-publish script call, rename cjs/ -> lib/
a306f50 
Addresses concerns like react-bootstrap#325, react-bootstrap#218, and any others like them that I have
missed. In particular this is the fix for an automated setup as
mentioned in react-bootstrap#292.
@mtscout6
Copy link
Member

@dashed 0.13.1 should be good to go :)

mtscout6 added a commit that referenced this issue Jan 23, 2015
@mtscout6
Add pre-publish script call, rename cjs/ -> lib/
77ee480 
Addresses concerns like #325, #218, and any others like them that I have
missed. In particular this is the fix for an automated setup as
mentioned in #292.
mtscout6 added a commit to mtscout6/react-bootstrap that referenced this issue Feb 13, 2015
@mtscout6
Add pre-publish script call, rename cjs/ -> lib/
c7544b7 
Addresses concerns like react-bootstrap#325, react-bootstrap#218, and any others like them that I have
missed. In particular this is the fix for an automated setup as
mentioned in react-bootstrap#292.
mtscout6 added a commit to mtscout6/react-bootstrap that referenced this issue Feb 15, 2015
@mtscout6
[changed] Move built components to lib directory
907b7b2 
In the past this library has suffered from accidentally pushing this
repo directly to npm without the built components. There has been a
separate repo to which the built source has been pushed and later
deployed from. While the approach is feasible it prevents you from using
the `npm link` feature, for easy testing of changes in your own
application.  This should address concerns like react-bootstrap#325, react-bootstrap#218, and any
others like them that I have missed. In particular this is the fix for
an automated setup as mentioned in react-bootstrap#292.

If you are currently using components directly from this library, then
you will need to change your reference path. For example
`require('react-bootstrap/Alert')` should now be `require('react-bootstrap/lib/Alert')`.
`require('react-bootstrap').Alert` will still work. This applies to both
CommonJS and AMD usages.
mtscout6 added a commit to mtscout6/react-bootstrap that referenced this issue Feb 16, 2015
@mtscout6
[changed] Move built components to lib directory
0193046 
In the past this library has suffered from accidentally pushing this
repo directly to npm without the built components. There has been a
separate repo to which the built source has been pushed and later
deployed from. While the approach is feasible it prevents you from using
the `npm link` feature, for easy testing of changes in your own
application.  This should address concerns like react-bootstrap#325, react-bootstrap#218, and any
others like them that I have missed. In particular this is the fix for
an automated setup as mentioned in react-bootstrap#292.

If you are currently using components directly from this library, then
you will need to change your reference path. For example
`require('react-bootstrap/Alert')` should now be `require('react-bootstrap/lib/Alert')`.
`require('react-bootstrap').Alert` will still work. This applies to both
CommonJS and AMD usages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dashed @mtscout6