React 16.9.x deprecation warnings with 0.32.4

[lvpro]

React 16.9 is now spamming the console with warnings regarding the use of componentWillMount, componentWillReceiveProps, and componentWillUpdate.

Apparently rbs 0.32.4 still uses these in most of the components. Since seamlessly moving to BS4 is no small feat styling-rule wise, I'm curious .... is there any chance the BS3 based release will be updated to replace these calls to make React happy?

I believe these calls will stop working all together in React 17.

[jquense]

I believe someone recently did the work of swapping out for UNSAFE_ prefixed versions, and we need to release that. In terms of proper migration via switching to gDSFP, that is less likely from the maintainers here, since most (all?) of us are using v4 now. We would happily accept PR's tho!

[MatthewHerbst]

@jquense is there anything blocking that release from going out?

[mturley]

+1 for releasing the version with UNSAFE_ prefixes. My team is maintaining a legacy version of our component library that depends on react-bootstrap and bootstrap v3, and we need to support newer React versions. @jquense is there anything we can do to help with that release? Our alternative is to make a copy of the source in-house, which obviously isn't ideal.

[mxschmitt]

We also use the v3 variant of react-bootstrap in production and would benefit of a new release.

[wheeler]

UNSAFE_ prefixes were introduced in react@16.3 so we would need to bump the min version in package.json. I'm happy to prepare a PR against the bs3-dev branch.

[taion]

sounds good

[wheeler]

React required version PR here: #4530

[nortonwong]

The remaining lifecycle warnings are from the higher-order-component Uncontrollable. I've submitted a pull request at jquense/uncontrollable#40 which migrates those usages.

[nortonwong]

Thanks for merging both #4244 (repo-internal warnings) and #4597 (uncontrollable warnings)!

There are a few more unsafe warnings due to the dependency on react-overlays ^0.8.0. This library is used by the DropdownMenu, Modal, and Overlay. Since 1.x and 2.x both contain breaking changes, the upgrade looks more complicated.

[nortonwong]

Opened a react-overlays upgrade PR at #4639. Some breaking changes are involved.

[kimyu92]

@taion @bpas247 would it be possible to publish an official npm package release v0.32.5 which include changes of https://github.com/react-bootstrap/react-bootstrap/commits/bs3-dev up till f6c861c before breaking changes from #4639

[ElScorxcho]

@taion With #4760 being merged are there any plans to release a new version anytime soon? Our team has turned off warnings in the console altogether because we have to use BS3, and this fix would be immensely helpful for us.

[taion]

released v0.33.0

[abhinavsingi]

But react-bootstrap@0.33.0 depends on react-overlays older version which is using deprecated methods, so essentially react-bootstrap@0.33.0 is not usable with react@16.9.0.

[taion]

it's compatible with newer R-O versions that drop the deprecated methods