Consider implementing simple components

[stevoland]

There's a lot of components with no interactivity that would just be wrappers around DOM elements with certain class names: badge, label, well, icon etc.

Should we add these? I'm in 2 minds, it adds a level of abstraction that might be useful if the classes change but creates another, albeit simple, API to learn.

Any comments?

EDIT:

In summation of current state:

• Badge
• Label
• Well
• Icon
• Media
• Thumbnail (See [added] Thumbnail component including docs and tests #488)
• Breadcrumb (See [added] Breadcrumb Component #1273 and Fixes for Breadcrumbs components #1354)
• Pager
• Pagination (See Implement Pagination #22 PR [added] Pagination component #786)
• Responsive Embed (See Add 'Responsive embed' component #1359)
• Images (See [added] Images Component with Sample and Docs #1293)
• Affix (See Implement affix #200)

[pieterv]

It would be nice to have them as React components as in most cases it will mean you will end up with a little less JSX code, <Label bsStyle="primary">Primary</Label> seems nicer than <span class="label label-primary">Primary</span>. But yes there is certainly a trade off in that we will need to create and maintain this abstraction and even more time consuming will be documenting them :P

I like the idea of creating these (even with extremely minimal docs) but i guess it would be pretty low priority.

[stevoland]

Yeah I'd like to add them. I was hoping this ticket would encourage someone else to help! :)

[stevoland]

Cool, not many simple components left: Table, Pagination, Pager, Breadcrumb is about it

[mathieumg]

What about Media?

[stevie-mayhew]

Yes, that one too. Obviously I'm not very good at reading documentation ;)

So: Media, Table, Pagination, Pager, Breadcrumb

Are there any others? I will hopefully have time to implement at these this weekend, clients be willing.

[mathieumg]

Nice, thanks!

Perhaps there is also Thumbnails. (Other than the ones for which there is a specific issue already opened)

There is Nav that's broken when displaying responsively, but I need to open a separate issue for that. Really looking forward to your additions!

[DinoJay]

And what is about the container element? I'm transforming a layout into react-bootstrap components right now and still need to import the bootstrap css file.

[JordanTheriault]

I'd like to do the Thumbnail if that's okay. I'm new to this repo but would love to get involved @mtscout6

[mtscout6]

@JordanTheriault That'd be great!

[ivan-kleshnin]

@mathieumg media is the worst Bootstrap part ever. It's totally broken in responsive aspect.
Not recommend.

[dozoisch]

@mtscout6 Do we add embeds? http://getbootstrap.com/components/#responsive-embed
images? http://getbootstrap.com/css/#images

[mtscout6]

Both of those seem reasonable.

[dozoisch]

should add affix to the list

#200

[dozoisch]

#488 resolves thumbnails

[AlexKVal]

/cc @react-bootstrap/collaborators
Do we really want this issue as a condition for the Milestone 1.0.0 ?

In my opinion if nobody is interested in those additional components,
so there is no value to make them.

And Steve named topic as 'Consider..', i.e. it doesn't mean that they 'must' be implemented.

I propose to remove it from the Milestone 1.0.0. 🍒

[mathieumg]

I think they should be in 1.0, otherwise 1.0 wouldn't be 1.0. To me, 1.0 means "some stability" and "feature parity with Bootstrap". There is a need with regards to these components, but the implementation of some of them brings no challenge (or even benefits per se) to the table, probably a reason why they've been overlooked. Once we set to implement them, it shouldn't be too long, for most anyway.

[AlexKVal]

Then:
We are working on getting through the backlogged tickets like this, but are short on time.
If anyone is interested and would like to help out we are very open to pull requests ❇️

[dozoisch]

yeah I have the same opinion as @mathieumg on this. 1.0 should mean parity.

[deerawan]

Hi @dozoisch @mtscout6 I'm interested to help with images component. I'm working on it.

[dozoisch]

@deerawan awesome!

[AlexKVal]

And.. here we are 😄 Just a Media component left

though the comment about it:

@mathieumg media is the worst Bootstrap part ever. It's totally broken in responsive aspect.
Not recommend.

#56 (comment)

[mathieumg]

It shouldn't be hard to implement, even though we know it's getting taken out of Bootstrap 4.

[dozoisch]

If it's getting taken out of BS4, I would just ignore it. Else we're going to end up adding it, and deprecating it in 2 months.

[taion]

Media is not getting taken out of BS4: http://v4-alpha.getbootstrap.com/layout/media-object/

[dozoisch]

Guess it makes sense to add it then!

[taion]

sadface

[alphashuro]

Why hasn't media been added yet? I think I'll give it a go

[taion]

I'd appreciate that. Thanks.

[alphashuro]

Why is there a completely misleading "Media content" section in the docs? I think that the elements in there deserve their own sections in the nav, and that "Media content/objects" should have the actual media objects. Can I fix this as well?

[taion]

They're for various sorts of media – carousels, responsive embeds, &c. That is the relevant category.

[alphashuro]

Other than the fact that it makes the documentation inconsistent with bootstrap's documentation, this leaves media objects with no section. unless I either create a new section or add them at the bottom of the Media content section, which would you suggest?

[taion]

They should go into that top-level "media" section.

[alphashuro]

Done #1707

[alphashuro]

I suppose that means this issue is done then?

[taion]

Thanks @alphashuro!