Add 'active' prop to NavDropdown component #2015
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the 'active' prop to the NavDropdown component, which
when true adds the 'active' class to the component.
Note that this does not automatically fix react-bootstrap/react-router-bootstrap#167, because the
LinkContainer
does not wrap the entire NavDropdown, but only the individual items.Personally I fixed this by using a wrapper component wrapping the NavDropdown which checks in the render() if the path of any of its children currently is active (the same check the LinkContainer performs) like so:
(in the above code
this.props.menuItems
is a list of MenuItem wrappers which have thepath
prop which is passed to the LinkContainer as theto
prop)