Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): optimized style and script loading #3713

Merged
merged 1 commit into from May 2, 2019
Merged

Conversation

@mxschmitt
Copy link
Member

mxschmitt commented Apr 27, 2019

Changes:

  • Moved all external assets into local bundle
  • Reduced resource size from 1.9 MB to 1.7 MB at e.g. Alerts page (I know, that's less, but we now not using external CDNs => DNS etc.)
  • Now using Bootstrap 4.3.1 (latest) instead of 4.2.1 for the docs
@taion
taion approved these changes Apr 27, 2019
Copy link
Member

taion left a comment

cc @jquense, because i don't understand the idiomatic way to do this with gatsby

@mxschmitt mxschmitt requested a review from jquense May 2, 2019
@jquense
jquense approved these changes May 2, 2019
Copy link
Member

jquense left a comment

this seems like a good change to me 👍 I don't think gatsby has an opinion here on a better way.

@mxschmitt mxschmitt merged commit 4b362a3 into master May 2, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@mxschmitt mxschmitt deleted the feature/optimize-docs branch May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.