Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): optimized style and script loading #3713

Merged
merged 1 commit into from
May 2, 2019

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Apr 27, 2019

Changes:

  • Moved all external assets into local bundle
  • Reduced resource size from 1.9 MB to 1.7 MB at e.g. Alerts page (I know, that's less, but we now not using external CDNs => DNS etc.)
  • Now using Bootstrap 4.3.1 (latest) instead of 4.2.1 for the docs

Copy link
Member

@taion taion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jquense, because i don't understand the idiomatic way to do this with gatsby

@mxschmitt mxschmitt requested a review from jquense May 2, 2019 12:25
Copy link
Member

@jquense jquense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like a good change to me 👍 I don't think gatsby has an opinion here on a better way.

@mxschmitt mxschmitt merged commit 4b362a3 into master May 2, 2019
@mxschmitt mxschmitt deleted the feature/optimize-docs branch May 2, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants