Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): add scrollable to ModalProps interface to match component #3742

Merged
merged 1 commit into from May 3, 2019
Merged

fix(types): add scrollable to ModalProps interface to match component #3742

merged 1 commit into from May 3, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 3, 2019

This is to resolve issue #3741 where the Modal.d.ts file is missing the scrollable flag in the ModalProps interface, while the proptypes for the component have the flag.

@jquense jquense changed the title Add scrollable to ModalProps interface to match component fix(types): add scrollable to ModalProps interface to match component May 3, 2019
@jquense jquense merged commit 57e7bf4 into react-bootstrap:master May 3, 2019
@jquense
Copy link
Member

jquense commented May 3, 2019

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jquense @taion