Return <DOCTYPE!> back and little refactoring of docs/build.js #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are two merge conflicts with |
| return new Promise((resolve, reject) => { | ||
| Router.run(routes, '/' + fileName, Handler => { | ||
| let html = React.renderToString(React.createElement(Handler)); | ||
| html = '<!doctype html>' + html; |
There was a problem hiding this comment.
should that be DOCTYPE in caps?
There was a problem hiding this comment.
It was originally in lowercase
react-bootstrap/docs/src/Root.js
Line 45 in 120ba6d
And I'm looking at
source tab in browser, all html code is lowercased.The same
style 😄
There was a problem hiding this comment.
I don't think that it's important either way: http://stackoverflow.com/questions/7020961/uppercase-or-lowercase-doctype
First time it was introduced here https://github.com/react-bootstrap/react-bootstrap/blob/120ba6d38a4/Gruntfile.js#L204 Then it was moved here react-bootstrap@addc396#diff-31cfa4797a188b7ab32b049b80c82ea6R63 And finally it was lost here react-bootstrap@804c24a#diff-4cd8a3a29faaf037ff2ec547bf1635abL10 and here react-bootstrap@804c24a#diff-ce9d98be04f7a23d325c274fc1a0a089L21 After that `Root.renderToString()` method (and some others) became unused.
Add more clarity about what's going on.
|
Rewritten for merging. |
|
LGTM |
mtscout6
added a commit
that referenced
this pull request
May 12, 2015
Return <DOCTYPE!> back and little refactoring of docs/build.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return
<DOCTYPE!>to pages.First time it was introduced here
https://github.com/react-bootstrap/react-bootstrap/blob/120ba6d38a4/Gruntfile.js#L204
Then it was moved here
addc396#diff-31cfa4797a188b7ab32b049b80c82ea6R63
And finally it was lost
Root=>Reacteasy to overlookfrom
var RootHTML = Root.renderToString()to
var RootHTML = React.renderToString()here
804c24a#diff-4cd8a3a29faaf037ff2ec547bf1635abL10
and here
804c24a#diff-ce9d98be04f7a23d325c274fc1a0a089L21
After that
Root.renderToString()method (and some others) became unused.And I've moved out html generating code for all docs - pages into standalone function
for clarity.
Those
spagettydrives me crazy.Less complexity promotes easier entrance for new contributors.