Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Use Lerna to manage repo #784

Closed
wants to merge 1 commit into from
Closed

WIP - Use Lerna to manage repo #784

wants to merge 1 commit into from

Conversation

skevy
Copy link
Member

@skevy skevy commented Mar 22, 2017

** DO NOT MERGE **

Just testing out using Lerna for managing react-navigation as a monorepo.

We have the want/need to separate packages out of react-navigation core to encourage better code reuse and sharing throughout the community.

cc @ericvicenti

@skevy
Copy link
Member Author

skevy commented Mar 23, 2017

Update: got stuck because symlink fixes in the packager aren't landed in RN stable. Need to do some crazy hacks, and that's just bad.

Will come back to this when I have a better story on how to deal with the packager.

@satya164
Copy link
Member

Ref #321 (comment)

@ericvicenti
Copy link
Contributor

Will come back to this when I have a better story on how to deal with the packager.

Maybe with @satya164's help we can unblock ourselves with haul on this repo 😄

@skevy
Copy link
Member Author

skevy commented Apr 5, 2017

Hmm. That's an interesting idea.

@grabbou
Copy link

grabbou commented Apr 13, 2017

@ericvicenti I think now that haul keeps stabilising, I think we can try to ship an initial take to see if it works.

@grabbou
Copy link

grabbou commented Apr 24, 2017

I am going to close this for now - will send a follow-up tomorrow that tries to set it up with Haul. Thanks @skevy for the work here, will use it as a great example!

@ericvicenti mind describing what's the desired packages structure?

@grabbou grabbou closed this Apr 24, 2017
@satya164
Copy link
Member

Before we do that, do we have an answer to this question?

Recently at callstack we needed to use a new unpublished commit in jest and were unable to install it from GIT because it uses lerna. I think this will be a problem too, unless there's a solution I'm not aware of.

@ericvicenti
Copy link
Contributor

Lerna can be problematic with unpublished modules :-/

I don't really care how we structure things, as long as we can put several packages in the repo

@grabbou grabbou deleted the lerna branch April 26, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants